René's URL Explorer Experiment


Title: Fix TwitterBenchmark which only measured a validation error by Meemaw · Pull Request #4499 · graphql-java/graphql-java · GitHub

Open Graph Title: Fix TwitterBenchmark which only measured a validation error by Meemaw · Pull Request #4499 · graphql-java/graphql-java

X Title: Fix TwitterBenchmark which only measured a validation error by Meemaw · Pull Request #4499 · graphql-java/graphql-java

Description: Problem TwitterBenchmark builds a query that is 150 levels deep. Since e4c287c ("Add query depth and field count limits to Validator") validation enforces QueryComplexityLimits with a default maxDepth of 100, so every benchmark execution fails with: MaxQueryDepthExceeded: Query depth 101 exceeds maximum allowed depth 100 and returns data == null. Because the benchmark uses a persisted query cache, it has been measuring the return of a cached validation error (~8M ops/s) rather than execution, and those numbers flow into the performance results history. Fix Pass a QueryComplexityLimits with maxDepth(DEPTH + 1) through the request's GraphQLContext (QueryComplexityLimits.KEY) rather than changing the global default, so other benchmarks in the same JVM are unaffected. Execute the query once during class initialisation and fail fast if it returns errors, so the benchmark cannot silently degrade into measuring an error path again. Verification Before: query returns MaxQueryDepthExceeded, data == null; benchmark reports ~8,090,000 ops/s. After: query returns no errors and fully nested data (150 levels, 150 leaves at the bottom); benchmark reports 359 ± 12 ops/s (~2.8 ms per ~22.6k field query, Apple Silicon, JDK 21). Temporarily lowering the limit to DEPTH - 1 makes class initialisation throw ExceptionInInitializerError, confirming the fail-fast check works. graphql.archunit.* tests pass (JMH fork rule). Note: the historical TwitterBenchmark numbers recorded since the limits were introduced are not comparable with results after this change.

Open Graph Description: Problem TwitterBenchmark builds a query that is 150 levels deep. Since e4c287c ("Add query depth and field count limits to Validator") validation enforces QueryComplexityLimits with a def...

X Description: Problem TwitterBenchmark builds a query that is 150 levels deep. Since e4c287c ("Add query depth and field count limits to Validator") validation enforces QueryComplexityLimits wi...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4499

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4acfdc06-6780-2bfb-a9c9-1b819bd2cdcd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC96:F7C4C:1ED03DB:2932A3A:6B017C75
html-safe-noncef44836e4661a97adfc1c8c5470ece55d3659073a59b10a3985469df27063ea24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzk2OkY3QzRDOjFFRDAzREI6MjkzMkEzQTo2QjAxN0M3NSIsInZpc2l0b3JfaWQiOiI0ODU0MzUwNDI1ODgzNTk3OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2154c35ecaa8a09f6e6478311c40fcd8280ad3e22a36b36bf428c1d6e3a2e077
hovercard-subject-tagpull_request:4903399668
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4499/files
twitter:imagehttps://avatars.githubusercontent.com/u/8524109?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8524109?s=400&v=4
og:image:altProblem TwitterBenchmark builds a query that is 150 levels deep. Since e4c287c ("Add query depth and field count limits to Validator") validation enforces QueryComplexityLimits with a def...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4499/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4499%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4499%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4499/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4499/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4499/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
Meemawhttps://github.com/Meemaw
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
Meemaw:fix/twitter-benchmark-depth-limithttps://github.com/Meemaw/graphql-java/tree/fix/twitter-benchmark-depth-limit
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4499
Commits 1 https://github.com/graphql-java/graphql-java/pull/4499/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4499/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4499/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4499/files
Fix TwitterBenchmark which only measured a validation error https://github.com/graphql-java/graphql-java/pull/4499/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4499/files
193286f Fix TwitterBenchmark which only measured a validation error Meemaw Oct 17, 2026 https://github.com/graphql-java/graphql-java/pull/4499/commits/193286f19b9e2b975270f744aba4ba85ab1f2a47
Clear filters https://github.com/graphql-java/graphql-java/pull/4499/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4499/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4499/files
src/jmh/java/benchmark/TwitterBenchmark.javahttps://github.com/graphql-java/graphql-java/pull/4499/files#diff-91786d55e85a26d5f94a3432d2ec6b4b2d1ee065cf19a7d9a9692c7d9689872a
View file https://github.com/graphql-java/graphql-java/blob/193286f19b9e2b975270f744aba4ba85ab1f2a47/src/jmh/java/benchmark/TwitterBenchmark.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4499/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4499/files#diff-91786d55e85a26d5f94a3432d2ec6b4b2d1ee065cf19a7d9a9692c7d9689872a
https://github.com/graphql-java/graphql-java/pull/4499/files#diff-91786d55e85a26d5f94a3432d2ec6b4b2d1ee065cf19a7d9a9692c7d9689872a
https://github.com/graphql-java/graphql-java/pull/4499/files#diff-91786d55e85a26d5f94a3432d2ec6b4b2d1ee065cf19a7d9a9692c7d9689872a
https://github.com/graphql-java/graphql-java/pull/4499/files#diff-91786d55e85a26d5f94a3432d2ec6b4b2d1ee065cf19a7d9a9692c7d9689872a
https://github.com/graphql-java/graphql-java/pull/4499/files#diff-91786d55e85a26d5f94a3432d2ec6b4b2d1ee065cf19a7d9a9692c7d9689872a
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4499/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.