René's URL Explorer Experiment


Title: let known queries take precedence in InMemoryPersistedQueryCache by nab-iha3 · Pull Request #4489 · graphql-java/graphql-java · GitHub

Open Graph Title: let known queries take precedence in InMemoryPersistedQueryCache by nab-iha3 · Pull Request #4489 · graphql-java/graphql-java

X Title: let known queries take precedence in InMemoryPersistedQueryCache by nab-iha3 · Pull Request #4489 · graphql-java/graphql-java

Description: with a query registered in InMemoryPersistedQueryCache for an id, and a request that sends that id together with its own query text: InMemoryPersistedQueryCacheTest > known queries take precedence over the query text in the execution input Condition not satisfied: printAstCompact(doc) == "{foo bar baz}" | | | {somethingElse} | false getPersistedQueryDocumentAsync reads executionInput.getQuery() first and only falls back to knownQueries when that text is null, empty or the APQ marker. so on a cache miss the request's text is what gets compiled and stored under the id, and every later caller that sends only the id is served that document. ApolloPersistedQuerySupport is not exposed because persistedQueryIdIsInvalid rejects text whose sha256 differs from the id, but the base PersistedQuerySupport returns false there, so with any other id scheme a client can replace a server registered query by sending its own text next to a known id. the custom cache in ApolloPersistedQuerySupportTest ("will use query hash in preference to query text") already treats the registered text as authoritative; the in memory cache did the opposite. look the id up in knownQueries first and only register text from the execution input for an id that is not known. the apollo flow is unchanged, since text that passes the hash check is the registered text anyway.

Open Graph Description: with a query registered in InMemoryPersistedQueryCache for an id, and a request that sends that id together with its own query text: InMemoryPersistedQueryCacheTest > known queries take preceden...

X Description: with a query registered in InMemoryPersistedQueryCache for an id, and a request that sends that id together with its own query text: InMemoryPersistedQueryCacheTest > known queries take prec...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4489

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aa4f9dff-3832-fb60-b63d-4c469c46ade3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1C4:842EC:1F98C94:2A13736:6B017C6D
html-safe-nonce497a255e37c9b361482830afa22117e73cb7f2874e138ff4227a5be6ec2b1579
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUM0Ojg0MkVDOjFGOThDOTQ6MkExMzczNjo2QjAxN0M2RCIsInZpc2l0b3JfaWQiOiIxMjI5MzgxODk3MTg0OTY3Nzg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0eb1f4bfbbe4e1324f97496f9ae2ef6391dc57c4ee997132c2d3d9c41c12187d
hovercard-subject-tagpull_request:4719251665
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4489/files
twitter:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
og:image:altwith a query registered in InMemoryPersistedQueryCache for an id, and a request that sends that id together with its own query text: InMemoryPersistedQueryCacheTest > known queries take preceden...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4489/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4489%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4489%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4489/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4489/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4489/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
nab-iha3https://github.com/nab-iha3
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
nab-iha3:persisted-cache-known-queries-firsthttps://github.com/nab-iha3/graphql-java/tree/persisted-cache-known-queries-first
Conversation 2 https://github.com/graphql-java/graphql-java/pull/4489
Commits 1 https://github.com/graphql-java/graphql-java/pull/4489/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4489/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4489/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4489/files
let known queries take precedence in InMemoryPersistedQueryCache https://github.com/graphql-java/graphql-java/pull/4489/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4489/files
28ec095 let known queries take precedence in InMemoryPersistedQueryCache nab-iha3 Oct 2, 2026 https://github.com/graphql-java/graphql-java/pull/4489/commits/28ec095299814e34aaf0c0780a75fa7542531a0e
Clear filters https://github.com/graphql-java/graphql-java/pull/4489/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4489/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4489/files
InMemoryPersistedQueryCache.java https://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
InMemoryPersistedQueryCacheTest.groovy https://github.com/graphql-java/graphql-java/pull/4489/files#diff-a94d5b8a5aabe91afb17c0537d6b79dfffb77621f0c42cc8d18a4be221d8ec1d
src/main/java/graphql/execution/preparsed/persisted/InMemoryPersistedQueryCache.javahttps://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
View file https://github.com/graphql-java/graphql-java/blob/28ec095299814e34aaf0c0780a75fa7542531a0e/src/main/java/graphql/execution/preparsed/persisted/InMemoryPersistedQueryCache.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4489/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
https://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
https://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
https://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
https://github.com/graphql-java/graphql-java/pull/4489/files#diff-1b767fa7c6a132b163c960f01967737fd77886f4f55870d3d4ce42d444c23424
src/test/groovy/graphql/execution/preparsed/persisted/InMemoryPersistedQueryCacheTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4489/files#diff-a94d5b8a5aabe91afb17c0537d6b79dfffb77621f0c42cc8d18a4be221d8ec1d
View file https://github.com/graphql-java/graphql-java/blob/28ec095299814e34aaf0c0780a75fa7542531a0e/src/test/groovy/graphql/execution/preparsed/persisted/InMemoryPersistedQueryCacheTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4489/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4489/files#diff-a94d5b8a5aabe91afb17c0537d6b79dfffb77621f0c42cc8d18a4be221d8ec1d
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4489/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.