René's URL Explorer Experiment


Title: Fix non-null union field implements nullable union interface field by tonyghita · Pull Request #4467 · graphql-java/graphql-java · GitHub

Open Graph Title: Fix non-null union field implements nullable union interface field by tonyghita · Pull Request #4467 · graphql-java/graphql-java

X Title: Fix non-null union field implements nullable union interface field by tonyghita · Pull Request #4467 · graphql-java/graphql-java

Description: According to the spec IsValidImplementationFieldType(), concrete type fields are able to strengthen the nullability guarantees made by an interface type field. interface I { f: F } type T implements I { f: F! } This mostly happens, except when the field is a Union type. type A { a: ID } union U = A interface I { u: U } type B implements I { u: U! # valid, but treated as invalid } schema { query: B } This change moves the branch for isNonNull up so that non-null unions fall-through hit the unwrap case first. This is closer to how the specification is written.

Open Graph Description: According to the spec IsValidImplementationFieldType(), concrete type fields are able to strengthen the nullability guarantees made by an interface type field. interface I { f: F } type T implement...

X Description: According to the spec IsValidImplementationFieldType(), concrete type fields are able to strengthen the nullability guarantees made by an interface type field. interface I { f: F } type T implement...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4467

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9c3e1b65-8c26-592c-b207-ae1145e3e297
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCEC:3E4205:1F16A94:2989560:6B017C79
html-safe-nonce7612c2879f9b85612f51f8cfe6ba7c2e397a0991d999ef772fa00d9586f4794d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0VDOjNFNDIwNToxRjE2QTk0OjI5ODk1NjA6NkIwMTdDNzkiLCJ2aXNpdG9yX2lkIjoiOTIxMTU2MTQyODM0MTg0OTIwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8448c7952a79ba6a4e2f0a51fbe920b8f44a226abf2b0a7056dd869f10f61ca6
hovercard-subject-tagpull_request:4388248254
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4467/files
twitter:imagehttps://avatars.githubusercontent.com/u/779738?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/779738?s=400&v=4
og:image:altAccording to the spec IsValidImplementationFieldType(), concrete type fields are able to strengthen the nullability guarantees made by an interface type field. interface I { f: F } type T implement...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4467/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4467%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4467%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4467/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4467/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4467/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
tonyghitahttps://github.com/tonyghita
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
tonyghita:fix-interface-union-nullabilityhttps://github.com/tonyghita/graphql-java/tree/fix-interface-union-nullability
Conversation 10 https://github.com/graphql-java/graphql-java/pull/4467
Commits 10 https://github.com/graphql-java/graphql-java/pull/4467/commits
Checks 9 https://github.com/graphql-java/graphql-java/pull/4467/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4467/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4467/files
Fix non-null union field implements nullable union interface field https://github.com/graphql-java/graphql-java/pull/4467/files#top
Show all changes 10 commits https://github.com/graphql-java/graphql-java/pull/4467/files
f6e7ca7 Fix non-null union field implements nullable union interface field tonyghita Aug 28, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/f6e7ca707bc457593159ec49b9034dd8f50629b1
2e21d2a Add test coverage for all nullabilty strengthening cases tonyghita Aug 31, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/2e21d2a86462cd9f505da3e123d204256207525f
ed84963 Move unwrap non-null first so we're closer to spec tonyghita Aug 31, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/ed849630e4c15614a1698964edb9d3b4fe76f214
cca8408 Merge branch 'master' into fix-interface-union-nullability tonyghita Sep 2, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/cca8408cc604654086ed2c92b505fff61e4446a6
38e843e Add test coverage for TypesImplementInterfaces branches tonyghita Sep 8, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/38e843e069a432aa5737e8eda0482dda580d9df7
19c01c2 Merge branch 'master' into fix-interface-union-nullability tonyghita Oct 1, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/19c01c20309b45c743480facc8aa102f73bb3354
5ed8988 Merge branch 'master' into fix-interface-union-nullability tonyghita Oct 2, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/5ed8988d6be3c3d624f6ddd992d4087bb1b0aa2d
371322c Merge branch 'master' into fix-interface-union-nullability tonyghita Oct 11, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/371322c3a38bc7698118c61ec681e9563b8bf02a
73583b8 Merge branch 'master' into fix-interface-union-nullability tonyghita Oct 26, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/73583b8dee02f2e023bafcf48a8a1d419044f749
081c438 Merge branch 'master' into fix-interface-union-nullability bbakerman Nov 5, 2026 https://github.com/graphql-java/graphql-java/pull/4467/commits/081c4380a5f723509963a87653a4f80aef694a9f
Clear filters https://github.com/graphql-java/graphql-java/pull/4467/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4467/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4467/files
TypesImplementInterfaces.java https://github.com/graphql-java/graphql-java/pull/4467/files#diff-d7b59e9ffa2734af2d2f7d808f53f58a717c9db19ed7b71bc66d2e00b61cdc55
TypesImplementInterfacesTest.groovy https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
src/main/java/graphql/schema/validation/TypesImplementInterfaces.javahttps://github.com/graphql-java/graphql-java/pull/4467/files#diff-d7b59e9ffa2734af2d2f7d808f53f58a717c9db19ed7b71bc66d2e00b61cdc55
View file https://github.com/graphql-java/graphql-java/blob/081c4380a5f723509963a87653a4f80aef694a9f/src/main/java/graphql/schema/validation/TypesImplementInterfaces.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4467/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-d7b59e9ffa2734af2d2f7d808f53f58a717c9db19ed7b71bc66d2e00b61cdc55
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-d7b59e9ffa2734af2d2f7d808f53f58a717c9db19ed7b71bc66d2e00b61cdc55
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-d7b59e9ffa2734af2d2f7d808f53f58a717c9db19ed7b71bc66d2e00b61cdc55
src/test/groovy/graphql/schema/validation/TypesImplementInterfacesTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
View file https://github.com/graphql-java/graphql-java/blob/081c4380a5f723509963a87653a4f80aef694a9f/src/test/groovy/graphql/schema/validation/TypesImplementInterfacesTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4467/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
bbakermanhttps://github.com/bbakerman
Nov 4, 2026https://github.com/graphql-java/graphql-java/pull/4467/files#r4464285336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4467/files
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
https://github.com/graphql-java/graphql-java/pull/4467/files#diff-b0010bf336a9032f22279338d5dc7012144ba62e5409aa3e506e970d34a2c06a
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4467/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.