René's URL Explorer Experiment


Title: Fix shaded Guava annotation refs breaking -Xlint:classfile consumers by kalayciburak · Pull Request #4437 · graphql-java/graphql-java · GitHub

Open Graph Title: Fix shaded Guava annotation refs breaking -Xlint:classfile consumers by kalayciburak · Pull Request #4437 · graphql-java/graphql-java

X Title: Fix shaded Guava annotation refs breaking -Xlint:classfile consumers by kalayciburak · Pull Request #4437 · graphql-java/graphql-java

Description: Summary Fixes #4436. The published jar shades a minimized subset of Guava under graphql.com.google.common, but classfiles such as ImmutableList keep RuntimeInvisibleAnnotations that reference annotation types that were never included: com.google.common.annotations.GwtCompatible (and related) com.google.errorprone.annotations.DoNotCall / InlineMe / … com.google.j2objc.annotations.* org.checkerframework.* javax.annotation.* Consumers that compile with -Xlint:classfile -Werror (reported from Spring for GraphQL against 26.0) fail with Cannot find annotation method … class file for … not found. Change Relocate those annotation packages alongside Guava and include the corresponding jars in shadowJar (with minimize excludes so they are retained). Keep OSGi Import-Package from re-exporting the shaded packages. Exclude the new shaded trees from JaCoCo class directories. Add verifyShadedJarAnnotationRefs (wired into check / after buildNewJar) and ShadedJarAnnotationRefsTest so a regression fails the packaging pipeline. Test plan Executed locally: RED: javac --release 17 -Xlint:classfile -Werror -cp … against graphql.com.google.common.collect.ImmutableList failed with missing GwtCompatible / DoNotCall / InlineMe classfiles GREEN: same consumer compile after the change (exit 0) ./gradlew shadowJar verifyShadedJarAnnotationRefs SUCCESS ./gradlew test --tests graphql.ShadedJarAnnotationRefsTest --tests graphql.GuavaLimitCheck --tests 'graphql.collect.*' --tests 'graphql.relay.*' — 38 tests GREEN

Open Graph Description: Summary Fixes #4436. The published jar shades a minimized subset of Guava under graphql.com.google.common, but classfiles such as ImmutableList keep RuntimeInvisibleAnnotations that reference annot...

X Description: Summary Fixes #4436. The published jar shades a minimized subset of Guava under graphql.com.google.common, but classfiles such as ImmutableList keep RuntimeInvisibleAnnotations that reference annot...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4437

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:947d11cb-02ec-1224-55e1-07b020655104
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2FC:3075D4:D883CE:11B1BD2:6AED53E3
html-safe-nonce14eb8e3948a9b68a9b3508f4c0b611ca42fea748950e953845e5468a17837d99
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkZDOjMwNzVENDpEODgzQ0U6MTFCMUJEMjo2QUVENTNFMyIsInZpc2l0b3JfaWQiOiI2OTE1MDQ2NTg5ODc3NTM5ODExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace317de0a6d8b326fc4adddd2474d407c8f3be80dac870ee22b970c89af02c409
hovercard-subject-tagpull_request:4238683471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4437/files
twitter:imagehttps://avatars.githubusercontent.com/u/61664693?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61664693?s=400&v=4
og:image:altSummary Fixes #4436. The published jar shades a minimized subset of Guava under graphql.com.google.common, but classfiles such as ImmutableList keep RuntimeInvisibleAnnotations that reference annot...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4437/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4437%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4437%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4437/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4437/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4437/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
kalayciburakhttps://github.com/kalayciburak
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
kalayciburak:fix/4436-shadow-annotation-refshttps://github.com/kalayciburak/graphql-java/tree/fix/4436-shadow-annotation-refs
Conversation 5 https://github.com/graphql-java/graphql-java/pull/4437
Commits 1 https://github.com/graphql-java/graphql-java/pull/4437/commits
Checks 1 https://github.com/graphql-java/graphql-java/pull/4437/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4437/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4437/files
Fix shaded Guava annotation refs breaking -Xlint:classfile consumers https://github.com/graphql-java/graphql-java/pull/4437/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4437/files
72559d7 Fix shaded Guava annotation refs breaking -Xlint:classfile consumers kalayciburak Aug 9, 2026 https://github.com/graphql-java/graphql-java/pull/4437/commits/72559d7c255b84152cb2f29ceca4a8a333bb9762
Clear filters https://github.com/graphql-java/graphql-java/pull/4437/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4437/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4437/files
build.gradle https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
ShadedJarAnnotationRefsTest.groovy https://github.com/graphql-java/graphql-java/pull/4437/files#diff-6575acd835ddd31de8a0bba945f500f5b7757f9891693759c204bd3f9d9fc513
build.gradlehttps://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
View file https://github.com/kalayciburak/graphql-java/blob/72559d7c255b84152cb2f29ceca4a8a333bb9762/build.gradle
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4437/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
https://github.com/graphql-java/graphql-java/pull/4437/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7
src/test/groovy/graphql/ShadedJarAnnotationRefsTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4437/files#diff-6575acd835ddd31de8a0bba945f500f5b7757f9891693759c204bd3f9d9fc513
View file https://github.com/kalayciburak/graphql-java/blob/72559d7c255b84152cb2f29ceca4a8a333bb9762/src/test/groovy/graphql/ShadedJarAnnotationRefsTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4437/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.