René's URL Explorer Experiment


Title: fix: mark InstrumentationState callback params as @Nullable by arimu1 · Pull Request #4435 · graphql-java/graphql-java · GitHub

Open Graph Title: fix: mark InstrumentationState callback params as @Nullable by arimu1 · Pull Request #4435 · graphql-java/graphql-java

X Title: fix: mark InstrumentationState callback params as @Nullable by arimu1 · Pull Request #4435 · graphql-java/graphql-java

Description: Summary Fixes #4433 After the JSpecify instrumentation annotations in #4272, SimplePerformantInstrumentation (and related @NullMarked instrumentation types) exposed unannotated InstrumentationState callback parameters as non-null to Kotlin. At runtime, createState() / createStateAsync() remain nullable and SimplePerformantInstrumentation.createState() returns null by default, so Kotlin subclasses that override hooks without providing a marker state fail with: Parameter specified as non-null is null: method … beginExecution, parameter state This change annotates callback state parameters as @Nullable to match the existing optional-state runtime contract (preferred fix from the issue). Changes Annotate InstrumentationState callback parameters @Nullable on Instrumentation, SimplePerformantInstrumentation, ChainedInstrumentation, NoContextChainedInstrumentation, and built-in implementors that override those hooks ChainedInstrumentation asserts non-null when casting to its own ChainedInstrumentationState (always materialized via createStateAsync) Spock coverage for null default createState and full execution with a stateless SimplePerformantInstrumentation subclass Test plan ./gradlew test --tests graphql.execution.instrumentation.InstrumentationDefaultMethodsTest --tests graphql.execution.instrumentation.InstrumentationTest --tests graphql.execution.instrumentation.ChainedInstrumentationStateTest --tests graphql.execution.instrumentation.NoContextChainedInstrumentationTest --tests graphql.execution.instrumentation.TracingInstrumentationTest (36 tests, Temurin 21) ./gradlew compileJava (NullAway / ErrorProne clean)

Open Graph Description: Summary Fixes #4433 After the JSpecify instrumentation annotations in #4272, SimplePerformantInstrumentation (and related @NullMarked instrumentation types) exposed unannotated InstrumentationState...

X Description: Summary Fixes #4433 After the JSpecify instrumentation annotations in #4272, SimplePerformantInstrumentation (and related @NullMarked instrumentation types) exposed unannotated InstrumentationState...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4435

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eeab31c2-3549-f55b-dfe6-16fd3a8e8cb3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90B2:2CAC94:AF28AE:E569EA:6AED46B4
html-safe-nonce91fdf342a5e3e252e51888daf5dbd6fbfe8b70d4631feb86bc4b2cc94714d613
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEIyOjJDQUM5NDpBRjI4QUU6RTU2OUVBOjZBRUQ0NkI0IiwidmlzaXRvcl9pZCI6IjQyNDM5NDAzODA0ODgwNTg1NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac80b5efc6bcbe862c7122826ae880d206c771048438577440f6b72b446f85d2fb
hovercard-subject-tagpull_request:4213410190
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4435/files
twitter:imagehttps://avatars.githubusercontent.com/u/19286898?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19286898?s=400&v=4
og:image:altSummary Fixes #4433 After the JSpecify instrumentation annotations in #4272, SimplePerformantInstrumentation (and related @NullMarked instrumentation types) exposed unannotated InstrumentationState...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4435/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4435%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4435%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4435/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4435/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4435/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
arimu1:fix/4433-nullable-instrumentation-statehttps://github.com/arimu1/graphql-java/tree/fix/4433-nullable-instrumentation-state
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4435
Commits 2 https://github.com/graphql-java/graphql-java/pull/4435/commits
Checks 11 https://github.com/graphql-java/graphql-java/pull/4435/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4435/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4435/files
fix: mark InstrumentationState callback params as @Nullable https://github.com/graphql-java/graphql-java/pull/4435/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/4435/files
79423f0 fix: mark InstrumentationState callback params as @Nullable arimu1 Aug 5, 2026 https://github.com/graphql-java/graphql-java/pull/4435/commits/79423f0b5fbe99db6a059e5991153df4967e92c7
b7bb74e Propagate nullable chained instrumentation state andimarek Aug 22, 2026 https://github.com/graphql-java/graphql-java/pull/4435/commits/b7bb74e223703badf9a1678bb9cb6132050c24ec
Clear filters https://github.com/graphql-java/graphql-java/pull/4435/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4435/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4435/files
MaxQueryComplexityInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
MaxQueryDepthInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
ChainedInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
Instrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
NoContextChainedInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-459659067e9535e1092db1146e4dba6dba82a5e41f1fef9ff85771b66077737e
SimplePerformantInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-6499bea408dbce71c903fa245398d9fd16ab0dc43481ec2ee96d3f3a219184b4
FieldValidationInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-471d3138f07fdc2cd335b1b5864c20bfc15024a260cc4c9165f4a94dee03f300
TracingInstrumentation.java https://github.com/graphql-java/graphql-java/pull/4435/files#diff-f079b472d438a589a24a6924fe1dadf2d2e686dd12847ec150eff68d727244db
InstrumentationDefaultMethodsTest.groovy https://github.com/graphql-java/graphql-java/pull/4435/files#diff-947e10b2d622f61684e36703213604ea1786e5b04fdee7ff79b9037aaace0c47
KotlinInstrumentationStateFixtures.kt https://github.com/graphql-java/graphql-java/pull/4435/files#diff-ad6765675fd51e6f4b1d957b25cd03d689e6562491ce3e8471ff0fe5f05165f5
src/main/java/graphql/analysis/MaxQueryComplexityInstrumentation.javahttps://github.com/graphql-java/graphql-java/pull/4435/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
View file https://github.com/arimu1/graphql-java/blob/b7bb74e223703badf9a1678bb9cb6132050c24ec/src/main/java/graphql/analysis/MaxQueryComplexityInstrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4435/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2696e88b9e4d095eea4d0e47b1c98ea872bfce3642c5aaee7317b1c3c2c478a5
src/main/java/graphql/analysis/MaxQueryDepthInstrumentation.javahttps://github.com/graphql-java/graphql-java/pull/4435/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
View file https://github.com/arimu1/graphql-java/blob/b7bb74e223703badf9a1678bb9cb6132050c24ec/src/main/java/graphql/analysis/MaxQueryDepthInstrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4435/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-2ccabc2bfeb67e15323d9185290e6c739eaec2aa1c1bdca1cecbdd9978a7fa40
src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.javahttps://github.com/graphql-java/graphql-java/pull/4435/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
View file https://github.com/arimu1/graphql-java/blob/b7bb74e223703badf9a1678bb9cb6132050c24ec/src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4435/files
src/main/java/graphql/execution/instrumentation/Instrumentation.javahttps://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
View file https://github.com/arimu1/graphql-java/blob/b7bb74e223703badf9a1678bb9cb6132050c24ec/src/main/java/graphql/execution/instrumentation/Instrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4435/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/4435/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4435/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4435/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.