René's URL Explorer Experiment


Title: Reject cyclical SDL directive definitions by andimarek · Pull Request #4385 · graphql-java/graphql-java · GitHub

Open Graph Title: Reject cyclical SDL directive definitions by andimarek · Pull Request #4385 · graphql-java/graphql-java

X Title: Reject cyclical SDL directive definitions by andimarek · Pull Request #4385 · graphql-java/graphql-java

Description: Summary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect references. Add checker-level and schema-generation regression coverage for #4201. Fixes #4201 Testing ./gradlew test --tests graphql.schema.idl.SchemaTypeDirectivesCheckerTest --tests graphql.schema.idl.SchemaGeneratorTest."#4201 indirect cyclical directive definitions are rejected without stack overflow" ./gradlew clean test --tests graphql.archunit.JMHForkArchRuleTest ./gradlew test

Open Graph Description: Summary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect referen...

X Description: Summary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect referen...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4385

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f051da49-57be-69a9-d17d-d06386003bef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F5C:F5278:EA93BE:1378FB4:6AED47BD
html-safe-noncecff9740f63feedae90c7752f8b1602fd684e7b49f98c226171bdf2635ef921ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjVDOkY1Mjc4OkVBOTNCRToxMzc4RkI0OjZBRUQ0N0JEIiwidmlzaXRvcl9pZCI6IjY0NTIxNzU2MjM2MzA0NDAzODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9bc41c85df7c4dd37d9aeeea5c04a2b6df15500f35cfde357379eab33c44acf6
hovercard-subject-tagpull_request:3705374485
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4385/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altSummary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect referen...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4385/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4385%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4385%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4385/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4385/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4385/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
reproduce-4201-cyclical-directiveshttps://github.com/graphql-java/graphql-java/tree/reproduce-4201-cyclical-directives
Conversation 5 https://github.com/graphql-java/graphql-java/pull/4385
Commits 1 https://github.com/graphql-java/graphql-java/pull/4385/commits
Checks 12 https://github.com/graphql-java/graphql-java/pull/4385/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4385/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385/files
Reject cyclical SDL directive definitions https://github.com/graphql-java/graphql-java/pull/4385/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4385/files
c58ab2a Reject indirect directive definition cycles andimarek May 18, 2026 https://github.com/graphql-java/graphql-java/pull/4385/commits/c58ab2a6941450d428990a892a416264daa7755a
Clear filters https://github.com/graphql-java/graphql-java/pull/4385/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385/files
SchemaTypeDirectivesChecker.java https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
DirectiveIllegalReferenceError.java https://github.com/graphql-java/graphql-java/pull/4385/files#diff-a4ba79fed1bd51cb8eec44018cc1681dbf1068a198e9d35c3cf91b34baa06dcc
SchemaGeneratorTest.groovy https://github.com/graphql-java/graphql-java/pull/4385/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
SchemaTypeDirectivesCheckerTest.groovy https://github.com/graphql-java/graphql-java/pull/4385/files#diff-a37820d6ba4c91ab6d6e9ce3e8f1d5bda21f3f00b2c4897ac79e8c52c41d6f92
src/main/java/graphql/schema/idl/SchemaTypeDirectivesChecker.javahttps://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
View file https://github.com/graphql-java/graphql-java/blob/c58ab2a6941450d428990a892a416264daa7755a/src/main/java/graphql/schema/idl/SchemaTypeDirectivesChecker.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4385/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
bbakermanhttps://github.com/bbakerman
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385/files#r3262784864
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385/files
andimarekhttps://github.com/andimarek
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385/files#r3262862613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c58ab2ahttps://github.com/graphql-java/graphql-java/commit/c58ab2a6941450d428990a892a416264daa7755a
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385/files
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
src/main/java/graphql/schema/idl/errors/DirectiveIllegalReferenceError.javahttps://github.com/graphql-java/graphql-java/pull/4385/files#diff-a4ba79fed1bd51cb8eec44018cc1681dbf1068a198e9d35c3cf91b34baa06dcc
View file https://github.com/graphql-java/graphql-java/blob/c58ab2a6941450d428990a892a416264daa7755a/src/main/java/graphql/schema/idl/errors/DirectiveIllegalReferenceError.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4385/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-a4ba79fed1bd51cb8eec44018cc1681dbf1068a198e9d35c3cf91b34baa06dcc
src/test/groovy/graphql/schema/idl/SchemaGeneratorTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4385/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
View file https://github.com/graphql-java/graphql-java/blob/c58ab2a6941450d428990a892a416264daa7755a/src/test/groovy/graphql/schema/idl/SchemaGeneratorTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4385/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-2936f6e762b5a3f1aa5570476494746c8b8125e8f8a48bc6567fdc746a87b65a
src/test/groovy/graphql/schema/idl/SchemaTypeDirectivesCheckerTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4385/files#diff-a37820d6ba4c91ab6d6e9ce3e8f1d5bda21f3f00b2c4897ac79e8c52c41d6f92
View file https://github.com/graphql-java/graphql-java/blob/c58ab2a6941450d428990a892a416264daa7755a/src/test/groovy/graphql/schema/idl/SchemaTypeDirectivesCheckerTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4385/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-a37820d6ba4c91ab6d6e9ce3e8f1d5bda21f3f00b2c4897ac79e8c52c41d6f92
https://github.com/graphql-java/graphql-java/pull/4385/files#diff-a37820d6ba4c91ab6d6e9ce3e8f1d5bda21f3f00b2c4897ac79e8c52c41d6f92
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.