René's URL Explorer Experiment


Title: Reject cyclical SDL directive definitions by andimarek · Pull Request #4385 · graphql-java/graphql-java · GitHub

Open Graph Title: Reject cyclical SDL directive definitions by andimarek · Pull Request #4385 · graphql-java/graphql-java

X Title: Reject cyclical SDL directive definitions by andimarek · Pull Request #4385 · graphql-java/graphql-java

Description: GraphQL Java implementation. Contribute to graphql-java/graphql-java development by creating an account on GitHub.

Open Graph Description: Summary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect referen...

X Description: Summary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect referen...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4385

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7a1e8c64-e258-a83d-9c53-9dc2345759b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8EE:137C1B:A137EA:D2E742:6AED417B
html-safe-nonced4e187bbb5fe1ff5106a9b05edf00e6f82a74334a2abbf8a21217ecd1de1217b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEVFOjEzN0MxQjpBMTM3RUE6RDJFNzQyOjZBRUQ0MTdCIiwidmlzaXRvcl9pZCI6IjE3NDMzMTAzNTY2MDg3OTUwMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac433e4c966285ecb48916513c19c177a83e0803254431454f5e289582df21da40
hovercard-subject-tagpull_request:3705374485
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/4385/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8ccfe423b3d0f05b87b144f7f1db5cc0bc980c8d3d84e7d26902b9761be13627/graphql-java/graphql-java/pull/4385
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ccfe423b3d0f05b87b144f7f1db5cc0bc980c8d3d84e7d26902b9761be13627/graphql-java/graphql-java/pull/4385
og:image:altSummary Detect indirect cycles between SDL directive definitions before schema generation. Preserve the existing direct self-reference error while adding a cycle-aware message for indirect referen...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandimarek
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-cache
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4385#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4385
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4385
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4385
Reloadhttps://github.com/graphql-java/graphql-java/pull/4385
Reloadhttps://github.com/graphql-java/graphql-java/pull/4385
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/pulse
https://github.com/graphql-java/graphql-java
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
reproduce-4201-cyclical-directiveshttps://github.com/graphql-java/graphql-java/tree/reproduce-4201-cyclical-directives
Conversationhttps://github.com/graphql-java/graphql-java/pull/4385
Commits1 (1)https://github.com/graphql-java/graphql-java/pull/4385/commits
Checkshttps://github.com/graphql-java/graphql-java/pull/4385/checks
Files changedhttps://github.com/graphql-java/graphql-java/pull/4385/files
Reject cyclical SDL directive definitionshttps://github.com/graphql-java/graphql-java/pull/4385#top
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
reproduce-4201-cyclical-directiveshttps://github.com/graphql-java/graphql-java/tree/reproduce-4201-cyclical-directives
https://github.com/andimarek
andimarekhttps://github.com/andimarek
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385#issue-4473221154
Improper handling of cyclical directive defs (spec issue) #4201https://github.com/graphql-java/graphql-java/issues/4201
#4201https://github.com/graphql-java/graphql-java/issues/4201
Improper handling of cyclical directive defs (spec issue) #4201https://github.com/graphql-java/graphql-java/issues/4201
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385#issuecomment-4483105853
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
May 18, 2026 https://github.com/graphql-java/graphql-java/pull/4385#pullrequestreview-4314661788
View reviewed changes https://github.com/graphql-java/graphql-java/pull/4385/files
src/main/java/graphql/schema/idl/SchemaTypeDirectivesChecker.javahttps://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
bbakermanhttps://github.com/bbakerman
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385#discussion_r3262781101
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
andimarekhttps://github.com/andimarek
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385#discussion_r3262862610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c58ab2ahttps://github.com/graphql-java/graphql-java/commit/c58ab2a6941450d428990a892a416264daa7755a
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
May 18, 2026 https://github.com/graphql-java/graphql-java/pull/4385#pullrequestreview-4314666817
View reviewed changes https://github.com/graphql-java/graphql-java/pull/4385/files
src/main/java/graphql/schema/idl/SchemaTypeDirectivesChecker.javahttps://github.com/graphql-java/graphql-java/pull/4385/files#diff-076201794f563cccc94a6e218d870de42c2911450c68ef73c046680794d79f61
bbakermanhttps://github.com/bbakerman
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385#discussion_r3262784864
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
andimarekhttps://github.com/andimarek
May 18, 2026https://github.com/graphql-java/graphql-java/pull/4385#discussion_r3262862613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c58ab2ahttps://github.com/graphql-java/graphql-java/commit/c58ab2a6941450d428990a892a416264daa7755a
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
https://github.com/andimarek
andimarekhttps://github.com/andimarek
force-pushedhttps://github.com/graphql-java/graphql-java/compare/179dacf23a9d671f6fc807aafd0b1584ea605630..b2b2d8fe7f2e6bd292e9d45fccd3361ca47912ea
179dacfhttps://github.com/graphql-java/graphql-java/commit/179dacf23a9d671f6fc807aafd0b1584ea605630
b2b2d8fhttps://github.com/graphql-java/graphql-java/commit/b2b2d8fe7f2e6bd292e9d45fccd3361ca47912ea
Compare https://github.com/graphql-java/graphql-java/compare/179dacf23a9d671f6fc807aafd0b1584ea605630..b2b2d8fe7f2e6bd292e9d45fccd3361ca47912ea
May 18, 2026 23:45https://github.com/graphql-java/graphql-java/pull/4385#event-25682078678
https://github.com/andimarek
Reject indirect directive definition cycleshttps://github.com/graphql-java/graphql-java/pull/4385/commits/c58ab2a6941450d428990a892a416264daa7755a
c58ab2ahttps://github.com/graphql-java/graphql-java/pull/4385/commits/c58ab2a6941450d428990a892a416264daa7755a
https://github.com/andimarek
andimarekhttps://github.com/andimarek
force-pushedhttps://github.com/graphql-java/graphql-java/compare/b2b2d8fe7f2e6bd292e9d45fccd3361ca47912ea..c58ab2a6941450d428990a892a416264daa7755a
b2b2d8fhttps://github.com/graphql-java/graphql-java/commit/b2b2d8fe7f2e6bd292e9d45fccd3361ca47912ea
c58ab2ahttps://github.com/graphql-java/graphql-java/commit/c58ab2a6941450d428990a892a416264daa7755a
Compare https://github.com/graphql-java/graphql-java/compare/b2b2d8fe7f2e6bd292e9d45fccd3361ca47912ea..c58ab2a6941450d428990a892a416264daa7755a
May 18, 2026 23:48https://github.com/graphql-java/graphql-java/pull/4385#event-25682133041
https://github.com/andimarek
andimarekhttps://github.com/andimarek
May 19, 2026 https://github.com/graphql-java/graphql-java/pull/4385#ref-issue-3778645604
Improper handling of cyclical directive defs (spec issue) #4201 https://github.com/graphql-java/graphql-java/issues/4201
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
May 19, 2026 https://github.com/graphql-java/graphql-java/pull/4385#pullrequestreview-4316448084
View reviewed changes https://github.com/graphql-java/graphql-java/pull/4385/files/c58ab2a6941450d428990a892a416264daa7755a
https://github.com/andimarek
andimarekhttps://github.com/andimarek
a943664https://github.com/graphql-java/graphql-java/commit/a9436647823ab49bc2522fd7402351bffbf5a6c4
May 19, 2026https://github.com/graphql-java/graphql-java/pull/4385#event-25699861290
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
https://github.com/andimarek
andimarekhttps://github.com/andimarek
Aug 20, 2026 https://github.com/graphql-java/graphql-java/pull/4385#ref-pullrequest-5198378820
Backport 26.1: Reject cyclical SDL directive definitions #4451 https://github.com/graphql-java/graphql-java/pull/4451
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4385
https://github.com/bbakerman
bbakerman https://github.com/bbakerman
https://github.com/graphql-java/graphql-java/pull/4385/files/c58ab2a6941450d428990a892a416264daa7755a
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
Improper handling of cyclical directive defs (spec issue) https://github.com/graphql-java/graphql-java/issues/4201
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4385
https://github.com/andimarek
https://github.com/bbakerman
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.