René's URL Explorer Experiment


Title: validate circular default values by jbellenger · Pull Request #4253 · graphql-java/graphql-java · GitHub

Open Graph Title: validate circular default values by jbellenger · Pull Request #4253 · graphql-java/graphql-java

X Title: validate circular default values by jbellenger · Pull Request #4253 · graphql-java/graphql-java

Description: Input object fields can define default values in ways that form cycles. For example in this schema: input A { b: B = {} } input B { a: A = {} } types A and B form a cycle with their default values, such that the coerced default value of A.b is an infinitely nested ObjectValue like {a: {b: {a: {...}}} Today, this sdl can be parsed into a GraphQLSchema object, though a StackOverflow will be thrown during execution if the system encounters a value for one of these types. The spec added an InputObjectDefaultValueHasCycle algorithm to handle this case. This PR implements this algorithm as a NoDefaultValueCircularRefs validator which allows these cyclic schemas to be rejected during validation. This behavior matches graphql-js v17, which added a similar validation in this pr

Open Graph Description: Input object fields can define default values in ways that form cycles. For example in this schema: input A { b: B = {} } input B { a: A = {} } types A and B form a cycle with their default values,...

X Description: Input object fields can define default values in ways that form cycles. For example in this schema: input A { b: B = {} } input B { a: A = {} } types A and B form a cycle with their default values,...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4253

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e3915a6a-bb22-5ae6-4032-ffa068a25f25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD692:1BB194:AFA786:E48A2A:6AED4398
html-safe-noncedfcbfaa7fb0f839ed27da6501da87d7d14aa16595017bb18006a4b35964c2b3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjkyOjFCQjE5NDpBRkE3ODY6RTQ4QTJBOjZBRUQ0Mzk4IiwidmlzaXRvcl9pZCI6IjkxNDg5MTc5Mzg3NTg5NjAwMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc241c033b7fa67434931df654a80e6b4d341ec03494ef01ce41fa15597f1d47e
hovercard-subject-tagpull_request:3302515487
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4253/files
twitter:imagehttps://avatars.githubusercontent.com/u/1391805?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1391805?s=400&v=4
og:image:altInput object fields can define default values in ways that form cycles. For example in this schema: input A { b: B = {} } input B { a: A = {} } types A and B form a cycle with their default values,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4253/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4253%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4253%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4253/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4253/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4253/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests32 (32)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
jbellenger:jbellenger-circular-input-defaultshttps://github.com/jbellenger/graphql-java/tree/jbellenger-circular-input-defaults
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4253
Commits 3 https://github.com/graphql-java/graphql-java/pull/4253/commits
Checks 11 https://github.com/graphql-java/graphql-java/pull/4253/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4253/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4253/files
validate circular default values https://github.com/graphql-java/graphql-java/pull/4253/files#top
Show all changes 3 commits https://github.com/graphql-java/graphql-java/pull/4253/files
72e2fdb init jbellenger Feb 19, 2026 https://github.com/graphql-java/graphql-java/pull/4253/commits/72e2fdb1b95ea06e550d64c58f37277798d9fb2a
b46ccac improve spec alignment jbellenger Feb 19, 2026 https://github.com/graphql-java/graphql-java/pull/4253/commits/b46ccacdddfa9eca9c6437cdbfc5f79faf523901
1b6f904 Avoid unnecessary circular default validation work andimarek May 19, 2026 https://github.com/graphql-java/graphql-java/pull/4253/commits/1b6f9045ad3c89ff9e1b0093bb59e217b07bfcec
Clear filters https://github.com/graphql-java/graphql-java/pull/4253/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4253/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4253/files
NoDefaultValueCircularRefs.java https://github.com/graphql-java/graphql-java/pull/4253/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
SchemaValidationErrorType.java https://github.com/graphql-java/graphql-java/pull/4253/files#diff-e015b8eb00c7046bc43599f58d9919c119cf35d33f2177e18d608fd1bb9ab4f8
SchemaValidator.java https://github.com/graphql-java/graphql-java/pull/4253/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
CircularInputDefaultValuesTest.groovy https://github.com/graphql-java/graphql-java/pull/4253/files#diff-ea435b9661f665ddaea91ccd31fe6294902841eefb2b04c414a3372c829d1637
SchemaDiffingTest.groovy https://github.com/graphql-java/graphql-java/pull/4253/files#diff-c0c2d7fb8e186f128f734e6fd2b7512916d951c8eebb5376e77e2f6385cae525
NoDefaultValueCircularRefsTest.groovy https://github.com/graphql-java/graphql-java/pull/4253/files#diff-835bbc969285cd4534e681979cafc50064e8f0a76f79ae967eb65d62b09a3d29
SchemaValidatorTest.groovy https://github.com/graphql-java/graphql-java/pull/4253/files#diff-05d8104f949be383f380a7f78a265bda004f807396548ff874d6b2337376db70
src/main/java/graphql/schema/validation/NoDefaultValueCircularRefs.javahttps://github.com/graphql-java/graphql-java/pull/4253/files#diff-3632ac24a39cb30dc4901f8d09f502139b8cf6be9c4d655464462b9899e69a54
View file https://github.com/jbellenger/graphql-java/blob/1b6f9045ad3c89ff9e1b0093bb59e217b07bfcec/src/main/java/graphql/schema/validation/NoDefaultValueCircularRefs.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4253/{{ revealButtonHref }}
src/main/java/graphql/schema/validation/SchemaValidationErrorType.javahttps://github.com/graphql-java/graphql-java/pull/4253/files#diff-e015b8eb00c7046bc43599f58d9919c119cf35d33f2177e18d608fd1bb9ab4f8
View file https://github.com/jbellenger/graphql-java/blob/1b6f9045ad3c89ff9e1b0093bb59e217b07bfcec/src/main/java/graphql/schema/validation/SchemaValidationErrorType.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4253/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4253/files#diff-e015b8eb00c7046bc43599f58d9919c119cf35d33f2177e18d608fd1bb9ab4f8
src/main/java/graphql/schema/validation/SchemaValidator.javahttps://github.com/graphql-java/graphql-java/pull/4253/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
View file https://github.com/jbellenger/graphql-java/blob/1b6f9045ad3c89ff9e1b0093bb59e217b07bfcec/src/main/java/graphql/schema/validation/SchemaValidator.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4253/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4253/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
https://github.com/graphql-java/graphql-java/pull/4253/files#diff-c61128ed45b5042860e141f937a41901bfd98ce1561c282107e8f51c7d762035
src/test/groovy/graphql/CircularInputDefaultValuesTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4253/files#diff-ea435b9661f665ddaea91ccd31fe6294902841eefb2b04c414a3372c829d1637
View file https://github.com/jbellenger/graphql-java/blob/1b6f9045ad3c89ff9e1b0093bb59e217b07bfcec/src/test/groovy/graphql/CircularInputDefaultValuesTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4253/{{ revealButtonHref }}
src/test/groovy/graphql/schema/diffing/SchemaDiffingTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4253/files#diff-c0c2d7fb8e186f128f734e6fd2b7512916d951c8eebb5376e77e2f6385cae525
View file https://github.com/jbellenger/graphql-java/blob/1b6f9045ad3c89ff9e1b0093bb59e217b07bfcec/src/test/groovy/graphql/schema/diffing/SchemaDiffingTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4253/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4253/files#diff-c0c2d7fb8e186f128f734e6fd2b7512916d951c8eebb5376e77e2f6385cae525
https://github.com/graphql-java/graphql-java/pull/4253/files#diff-c0c2d7fb8e186f128f734e6fd2b7512916d951c8eebb5376e77e2f6385cae525
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4253/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.