René's URL Explorer Experiment


Title: avoid wrapping materialized fieldValueObject in a CompletableFuture by samuelAndalon · Pull Request #3943 · graphql-java/graphql-java · GitHub

Open Graph Title: avoid wrapping materialized fieldValueObject in a CompletableFuture by samuelAndalon · Pull Request #3943 · graphql-java/graphql-java

X Title: avoid wrapping materialized fieldValueObject in a CompletableFuture by samuelAndalon · Pull Request #3943 · graphql-java/graphql-java

Description: While updating graphql-kotlin to graphql-java 23 found that completeField is still wrapping FieldValueInfo.fieldValueObject in a CompletableFuture for objects already materialized / in memory this ...

Open Graph Description: While updating graphql-kotlin to graphql-java 23 found that completeField is still wrapping FieldValueInfo.fieldValueObject in a CompletableFuture for objects already materialized / in memory this ...

X Description: While updating graphql-kotlin to graphql-java 23 found that completeField is still wrapping FieldValueInfo.fieldValueObject in a CompletableFuture for objects already materialized / in memory this ...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/3943

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a337fcd2-8869-f392-7425-a1c0dba07502
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85DC:62C58:86FF3D:BFD7B1:696F8A68
html-safe-nonce23a1f77fdb2524a67c444b2e944224ab35db4dd50ed27036f055603b6c21d921
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NURDOjYyQzU4Ojg2RkYzRDpCRkQ3QjE6Njk2RjhBNjgiLCJ2aXNpdG9yX2lkIjoiNzM2NzEwMTcxNDc5MjE0Njk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde4381bc1afe128336a673f78197090ad3a9e0c794396bcf2f92f879d9da7433
hovercard-subject-tagpull_request:2489972990
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/3943/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/474bb34d2c1d92252475b55cef43c8d686e80fd844a9f091773a8bb82d9004c2/graphql-java/graphql-java/pull/3943
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/474bb34d2c1d92252475b55cef43c8d686e80fd844a9f091773a8bb82d9004c2/graphql-java/graphql-java/pull/3943
og:image:altWhile updating graphql-kotlin to graphql-java 23 found that completeField is still wrapping FieldValueInfo.fieldValueObject in a CompletableFuture for objects already materialized / in memory this ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesamuelAndalon
hostnamegithub.com
expected-hostnamegithub.com
None0ca8d8c65612640b9a1a588b3eed68222ca723ed2d028b18fe81b28936d535eb
turbo-cache-controlno-preview
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release95f60616ce2765d1114fe6da4af405a58c6d26d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/3943#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3943
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3943
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/3943
Reloadhttps://github.com/graphql-java/graphql-java/pull/3943
Reloadhttps://github.com/graphql-java/graphql-java/pull/3943
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 40 https://github.com/graphql-java/graphql-java/issues
Pull requests 17 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects 0 https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/graphql-java/graphql-java/security
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/graphql-java/graphql-java/pull/3943#issue-comment-box
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
samuelAndalon:avoid-wrapping-fvi-completable-futurehttps://github.com/samuelAndalon/graphql-java/tree/avoid-wrapping-fvi-completable-future
avoid wrapping materialized fieldValueObject in a CompletableFuture https://github.com/graphql-java/graphql-java/pull/3943#top
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
samuelAndalon:avoid-wrapping-fvi-completable-futurehttps://github.com/samuelAndalon/graphql-java/tree/avoid-wrapping-fvi-completable-future
Conversation 4 https://github.com/graphql-java/graphql-java/pull/3943
Commits 1 https://github.com/graphql-java/graphql-java/pull/3943/commits
Checks 2 https://github.com/graphql-java/graphql-java/pull/3943/checks
Files changed https://github.com/graphql-java/graphql-java/pull/3943/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }}
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
Apr 29, 2025https://github.com/graphql-java/graphql-java/pull/3943#issue-3029574740
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/graphql-java/graphql-java/releases/tag/v22.0https://github.com/graphql-java/graphql-java/releases/tag/v22.0
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
avoid wrapping materialized fieldValueObject in a completable futurehttps://github.com/graphql-java/graphql-java/pull/3943/commits/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
2e25aa8https://github.com/graphql-java/graphql-java/pull/3943/commits/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
Apr 29, 2025https://github.com/graphql-java/graphql-java/pull/3943#event-17463192895
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
Apr 29, 2025 https://github.com/graphql-java/graphql-java/pull/3943#pullrequestreview-2805168889
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3943/files/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
src/main/java/graphql/execution/ExecutionStrategy.javahttps://github.com/graphql-java/graphql-java/pull/3943/files/2e25aa8f47da1f3257e184658d14b6e42e7de2d3#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
samuelAndalonhttps://github.com/samuelAndalon
Apr 29, 2025https://github.com/graphql-java/graphql-java/pull/3943#discussion_r2067483753
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/Samjin
Samjinhttps://github.com/Samjin
Apr 29, 2025 https://github.com/graphql-java/graphql-java/pull/3943#pullrequestreview-2805187507
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3943/files/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Apr 29, 2025 https://github.com/graphql-java/graphql-java/pull/3943#pullrequestreview-2805318914
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3943/files/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
bbakermanhttps://github.com/bbakerman
https://github.com/graphql-java/graphql-java/pull/3943#pullrequestreview-2805318914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
performance https://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3Aperformance
Apr 29, 2025https://github.com/graphql-java/graphql-java/pull/3943#event-17464000587
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
Apr 29, 2025https://github.com/graphql-java/graphql-java/pull/3943#issuecomment-2840483005
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
23.1 non-breaking changes and bugfixeshttps://github.com/graphql-java/graphql-java/milestone/82
Apr 30, 2025https://github.com/graphql-java/graphql-java/pull/3943#event-17464755992
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
ea9104dhttps://github.com/graphql-java/graphql-java/commit/ea9104d897954f2fb2c16c94e9b7b88e2c90aff5
Apr 30, 2025https://github.com/graphql-java/graphql-java/pull/3943#event-17464798231
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
April 30, 2025 16:34https://github.com/graphql-java/graphql-java/pull/3943#event-17476477720
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
Apr 30, 2025https://github.com/graphql-java/graphql-java/pull/3943#issuecomment-2842588859
@bbakermanhttps://github.com/bbakerman
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/samuelAndalon
samuelAndalonhttps://github.com/samuelAndalon
Apr 30, 2025 https://github.com/graphql-java/graphql-java/pull/3943#ref-pullrequest-3032131362
avoid wrapping materialized fieldValueObject in a completable future #3944 https://github.com/graphql-java/graphql-java/pull/3944
https://github.com/dondonz
dondonzhttps://github.com/dondonz
23.x non-breaking changes and bugfixeshttps://github.com/graphql-java/graphql-java/milestone/82
23.2https://github.com/graphql-java/graphql-java/milestone/84
24.0https://github.com/graphql-java/graphql-java/milestone/83
May 11, 2025https://github.com/graphql-java/graphql-java/pull/3943#event-17604197491
dondonzhttps://github.com/dondonz
May 13, 2025 https://github.com/graphql-java/graphql-java/pull/3943#ref-commit-3ae003d
https://github.com/dondonz
Backport ofhttps://github.com/graphql-java/graphql-java/commit/3ae003d74c090dd5fd3fb9dee01149783a2173ff
#3943https://github.com/graphql-java/graphql-java/pull/3943
3ae003dhttps://github.com/graphql-java/graphql-java/commit/3ae003d74c090dd5fd3fb9dee01149783a2173ff
https://github.com/dondonz
dondonzhttps://github.com/dondonz
May 13, 2025 https://github.com/graphql-java/graphql-java/pull/3943#ref-pullrequest-3059311247
24.x Backport of avoid wrapping materialised value #3962 https://github.com/graphql-java/graphql-java/pull/3962
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3943
https://github.com/bbakerman
bbakerman https://github.com/bbakerman
https://github.com/graphql-java/graphql-java/pull/3943/files/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
https://github.com/Samjin
Samjin https://github.com/Samjin
https://github.com/graphql-java/graphql-java/pull/3943/files/2e25aa8f47da1f3257e184658d14b6e42e7de2d3
performance https://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3Aperformance
24.0 https://github.com/graphql-java/graphql-java/milestone/83
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3943
https://github.com/samuelAndalon
https://github.com/bbakerman
https://github.com/Samjin
https://github.com/dondonz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.