| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:16aade66-2f99-7baa-ad6a-62dac20384f2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DCF8:45A6C:CFE6E1:127336E:696F4C7F |
| html-safe-nonce | bba43b75582528240ad5441fedfd737a6498a07f7d57f2b39835a16a76af814d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Y4OjQ1QTZDOkNGRTZFMToxMjczMzZFOjY5NkY0QzdGIiwidmlzaXRvcl9pZCI6IjM1ODIzMjIzNzUyNzg5MzkyNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2e5e8ce8d5030c196fc67cc3e966a13e7286b8b56e95e35476fbfae8dc6a25d2 |
| hovercard-subject-tag | pull_request:2488796004 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/3942/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3ead9aff8e9cc221dc823028907560eac5da8671ff54794d6046f78f29f77501/graphql-java/graphql-java/pull/3942 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3ead9aff8e9cc221dc823028907560eac5da8671ff54794d6046f78f29f77501/graphql-java/graphql-java/pull/3942 |
| og:image:alt | This was always the intention here when we created #3754 to have a singleton property fetcher instance
However we didnt do the factory right and hence DataFetcherFactoryEnvironment are created when... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bbakerman |
| hostname | github.com |
| expected-hostname | github.com |
| None | 49bb2ee76ae1b4ec758faefafda636ff20b05a9708bb290d28422cdf542ae979 |
| turbo-cache-control | no-preview |
| go-import | github.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git |
| octolytics-dimension-user_id | 14289921 |
| octolytics-dimension-user_login | graphql-java |
| octolytics-dimension-repository_id | 38602457 |
| octolytics-dimension-repository_nwo | graphql-java/graphql-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38602457 |
| octolytics-dimension-repository_network_root_nwo | graphql-java/graphql-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 036f37fe552777ac9c6ee661957f947285aab936 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/graphql-java/graphql-java/pull/3942#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3942 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3942 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java |
| Reload | https://github.com/graphql-java/graphql-java/pull/3942 |
| Reload | https://github.com/graphql-java/graphql-java/pull/3942 |
| Reload | https://github.com/graphql-java/graphql-java/pull/3942 |
|
graphql-java
| https://github.com/graphql-java |
| graphql-java | https://github.com/graphql-java/graphql-java |
|
Notifications
| https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java |
|
Fork
1.2k
| https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java |
|
Star
6.2k
| https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java |
|
Code
| https://github.com/graphql-java/graphql-java |
|
Issues
40
| https://github.com/graphql-java/graphql-java/issues |
|
Pull requests
17
| https://github.com/graphql-java/graphql-java/pulls |
|
Discussions
| https://github.com/graphql-java/graphql-java/discussions |
|
Actions
| https://github.com/graphql-java/graphql-java/actions |
|
Projects
0
| https://github.com/graphql-java/graphql-java/projects |
|
Wiki
| https://github.com/graphql-java/graphql-java/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/graphql-java/graphql-java/security |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
|
Insights
| https://github.com/graphql-java/graphql-java/pulse |
|
Code
| https://github.com/graphql-java/graphql-java |
|
Issues
| https://github.com/graphql-java/graphql-java/issues |
|
Pull requests
| https://github.com/graphql-java/graphql-java/pulls |
|
Discussions
| https://github.com/graphql-java/graphql-java/discussions |
|
Actions
| https://github.com/graphql-java/graphql-java/actions |
|
Projects
| https://github.com/graphql-java/graphql-java/projects |
|
Wiki
| https://github.com/graphql-java/graphql-java/wiki |
|
Security
| https://github.com/graphql-java/graphql-java/security |
|
Insights
| https://github.com/graphql-java/graphql-java/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/graphql-java/graphql-java/pull/3942#issue-comment-box |
| dondonz | https://github.com/dondonz |
| master | https://github.com/graphql-java/graphql-java/tree/master |
| fix-to-singleton-property-to-not-create-objects | https://github.com/graphql-java/graphql-java/tree/fix-to-singleton-property-to-not-create-objects |
|
Retriveing singleton property fetchers will not create DataFetcherFactoryEnvironment objects
| https://github.com/graphql-java/graphql-java/pull/3942#top |
| dondonz | https://github.com/dondonz |
| master | https://github.com/graphql-java/graphql-java/tree/master |
| fix-to-singleton-property-to-not-create-objects | https://github.com/graphql-java/graphql-java/tree/fix-to-singleton-property-to-not-create-objects |
|
Conversation
4
| https://github.com/graphql-java/graphql-java/pull/3942 |
|
Commits
1
| https://github.com/graphql-java/graphql-java/pull/3942/commits |
|
Checks
3
| https://github.com/graphql-java/graphql-java/pull/3942/checks |
|
Files changed
1
| https://github.com/graphql-java/graphql-java/pull/3942/files |
| https://github.co/hiddenchars |
| https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }} |
|
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
| Apr 29, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#issue-3028254597 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| #3754 | https://github.com/graphql-java/graphql-java/pull/3754 |
| #3939 | https://github.com/graphql-java/graphql-java/issues/3939 |
| #3941 | https://github.com/graphql-java/graphql-java/issues/3941 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
|
| https://github.com/bbakerman |
| This is a performance improvement for property data fetchers to not c… | https://github.com/graphql-java/graphql-java/pull/3942/commits/ade6100ff573e35e8f3e55ba3570be624ad24e5d |
| ade6100 | https://github.com/graphql-java/graphql-java/pull/3942/commits/ade6100ff573e35e8f3e55ba3570be624ad24e5d |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
performance
| https://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3Aperformance |
| Apr 29, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#event-17454729393 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
| andimarek | https://github.com/andimarek |
| dondonz | https://github.com/dondonz |
| April 29, 2025 13:00 | https://github.com/graphql-java/graphql-java/pull/3942#event-17454729406 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Apr 29, 2025
| https://github.com/graphql-java/graphql-java/pull/3942#pullrequestreview-2803358012 |
|
View reviewed changes
| https://github.com/graphql-java/graphql-java/pull/3942/files/ade6100ff573e35e8f3e55ba3570be624ad24e5d |
| src/main/java/graphql/schema/SingletonPropertyDataFetcher.java | https://github.com/graphql-java/graphql-java/pull/3942/files/ade6100ff573e35e8f3e55ba3570be624ad24e5d#diff-bd871df5158ddbd26a8225cbfe2d91e5afb313a2b58e39c92fcdb6e9a0bc0ce2 |
| bbakerman | https://github.com/bbakerman |
| Apr 29, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#discussion_r2066297007 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| bbakerman | https://github.com/bbakerman |
| Apr 29, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#discussion_r2066298024 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| dondonz | https://github.com/dondonz |
| May 14, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#discussion_r2088234355 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 29, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#issuecomment-2838807202 |
| ade6100 | https://github.com/graphql-java/graphql-java/commit/ade6100ff573e35e8f3e55ba3570be624ad24e5d |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| https://github.com/dondonz |
| dondonz | https://github.com/dondonz |
| 24.x non-breaking changes and bugfixes | https://github.com/graphql-java/graphql-java/milestone/82 |
| 25.x breaking changes | https://github.com/graphql-java/graphql-java/milestone/82 |
| 24.0 | https://github.com/graphql-java/graphql-java/milestone/83 |
| May 11, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#event-17604237282 |
| https://github.com/dondonz |
| dondonz | https://github.com/dondonz |
|
May 14, 2025
| https://github.com/graphql-java/graphql-java/pull/3942#pullrequestreview-2839034734 |
|
View reviewed changes
| https://github.com/graphql-java/graphql-java/pull/3942/files/ade6100ff573e35e8f3e55ba3570be624ad24e5d |
| https://github.com/dondonz |
| dondonz | https://github.com/dondonz |
| d5b6498 | https://github.com/graphql-java/graphql-java/commit/d5b64982dfed0b307dbfd701658c33fce37fee82 |
| May 14, 2025 | https://github.com/graphql-java/graphql-java/pull/3942#event-17647845088 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
| https://github.com/dondonz |
| dondonz | https://github.com/dondonz |
|
May 15, 2025
| https://github.com/graphql-java/graphql-java/pull/3942#ref-pullrequest-3065153656 |
|
Cherry pick PR 3942 To add singleton to factory method
#3968
| https://github.com/graphql-java/graphql-java/pull/3968 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3942 |
|
| https://github.com/dondonz |
|
dondonz
| https://github.com/dondonz |
|
| https://github.com/graphql-java/graphql-java/pull/3942/files/ade6100ff573e35e8f3e55ba3570be624ad24e5d |
|
| https://github.com/andimarek |
|
andimarek
| https://github.com/andimarek |
|
performance
| https://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3Aperformance |
|
24.0
| https://github.com/graphql-java/graphql-java/milestone/83 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/3942 |
|
| https://github.com/bbakerman |
|
| https://github.com/dondonz |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |