René's URL Explorer Experiment


Title: validate non-nullable directive args by jbellenger · Pull Request #3551 · graphql-java/graphql-java · GitHub

Open Graph Title: validate non-nullable directive args by jbellenger · Pull Request #3551 · graphql-java/graphql-java

X Title: validate non-nullable directive args by jbellenger · Pull Request #3551 · graphql-java/graphql-java

Description: In putting together a fuzz tester for graphql-java schemas, I noticed that applied directives were not failing when they were missing values for non-nullable arguments. I put together a fix and a test case. This test case fails against master and passes with the changes to AppliedDirectiveArgumentsAreValid. I'm unsure about a couple of things in this PR and am open to feedback: GraphQLDirective.toAppliedDirective() makes it easy to forget to provide directive argument values, and I didn't see a straight-forward way to go from a GraphQLDirective -> GraphQLAppliedDirective with input values. Am I misunderstanding how this is supposed to be used? AppliedDirectiveArgumentsAreValid used to exit early if no input value was set. I think that was an implicit (and incorrect?) assumption that a applied directive arg always had a default value or was nullable, though I'm not sure. Is this right?

Open Graph Description: In putting together a fuzz tester for graphql-java schemas, I noticed that applied directives were not failing when they were missing values for non-nullable arguments. I put together a fix and a t...

X Description: In putting together a fuzz tester for graphql-java schemas, I noticed that applied directives were not failing when they were missing values for non-nullable arguments. I put together a fix and a t...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/3551

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:854a3f82-b66a-6c45-6f46-ae17d7b84604
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E94:1F542C:1274D93:18E2090:6A606C52
html-safe-noncec38c8587e5c29f2545ded696bf110bf370b96e59f01f6e03ca55c4efc099ed88
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTk0OjFGNTQyQzoxMjc0RDkzOjE4RTIwOTA6NkE2MDZDNTIiLCJ2aXNpdG9yX2lkIjoiODY5NzI5MjE0NjA3MTMzMzk3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac989385f7ff72e7b92b687f3c80123af182478bef2fa3fcd3df60f0e22f7ac8a5
hovercard-subject-tagpull_request:1799480520
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/3551/files
twitter:imagehttps://avatars.githubusercontent.com/u/1391805?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1391805?s=400&v=4
og:image:altIn putting together a fuzz tester for graphql-java schemas, I noticed that applied directives were not failing when they were missing values for non-nullable arguments. I put together a fix and a t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None60da8c2a42fa2bbf5f7567474990ec467836a84444262a58e200fa91b7f3d2d0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9824515e740d83d5eb82168a089b806ab0fe04a1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/3551/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3551%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3551%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/3551/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/3551/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/3551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
jbellenger:jbellenger-validate-dir-argshttps://github.com/jbellenger/graphql-java/tree/jbellenger-validate-dir-args
Conversation 11 https://github.com/graphql-java/graphql-java/pull/3551
Commits 3 https://github.com/graphql-java/graphql-java/pull/3551/commits
Checks 0 https://github.com/graphql-java/graphql-java/pull/3551/checks
Files changed https://github.com/graphql-java/graphql-java/pull/3551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
validate non-nullable directive args https://github.com/graphql-java/graphql-java/pull/3551/files#top
Show all changes 3 commits https://github.com/graphql-java/graphql-java/pull/3551/files
d843a30 validate non-nullable directive args jbellenger Mar 31, 2024 https://github.com/graphql-java/graphql-java/pull/3551/commits/d843a3004f9e5b0e8e24b977c1843abb866b5c9e
0dac307 remove wildcard import jbellenger Apr 1, 2024 https://github.com/graphql-java/graphql-java/pull/3551/commits/0dac3075c10090d0de33c90562b7f2a4967548c4
b906880 fix merge conflict jbellenger Apr 2, 2024 https://github.com/graphql-java/graphql-java/pull/3551/commits/b9068808a4706dca415d41ac18ccaed6a3795319
Clear filters https://github.com/graphql-java/graphql-java/pull/3551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
AppliedDirectiveArgumentsAreValid.java https://github.com/graphql-java/graphql-java/pull/3551/files#diff-ae3f95bf487dda61da2b8a799f3f44f348b927049cb44743f186a1bf94db202b
GraphQLArgumentTest.groovy https://github.com/graphql-java/graphql-java/pull/3551/files#diff-0d448dca3f74fad5710a72f885217faa1c14f40d4637c51008fd997bb67f04b7
src/main/java/graphql/schema/validation/AppliedDirectiveArgumentsAreValid.javahttps://github.com/graphql-java/graphql-java/pull/3551/files#diff-ae3f95bf487dda61da2b8a799f3f44f348b927049cb44743f186a1bf94db202b
View file https://github.com/jbellenger/graphql-java/blob/b9068808a4706dca415d41ac18ccaed6a3795319/src/main/java/graphql/schema/validation/AppliedDirectiveArgumentsAreValid.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/3551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/3551/files#diff-ae3f95bf487dda61da2b8a799f3f44f348b927049cb44743f186a1bf94db202b
https://github.com/graphql-java/graphql-java/pull/3551/files#diff-ae3f95bf487dda61da2b8a799f3f44f348b927049cb44743f186a1bf94db202b
bbakermanhttps://github.com/bbakerman
Apr 2, 2024https://github.com/graphql-java/graphql-java/pull/3551/files#r1547212272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
bbakermanhttps://github.com/bbakerman
Apr 2, 2024https://github.com/graphql-java/graphql-java/pull/3551/files#r1547216251
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
https://github.com/graphql-java/graphql-java/pull/3551/files#diff-ae3f95bf487dda61da2b8a799f3f44f348b927049cb44743f186a1bf94db202b
src/test/groovy/graphql/schema/GraphQLArgumentTest.groovyhttps://github.com/graphql-java/graphql-java/pull/3551/files#diff-0d448dca3f74fad5710a72f885217faa1c14f40d4637c51008fd997bb67f04b7
View file https://github.com/jbellenger/graphql-java/blob/b9068808a4706dca415d41ac18ccaed6a3795319/src/test/groovy/graphql/schema/GraphQLArgumentTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/3551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/3551/files#diff-0d448dca3f74fad5710a72f885217faa1c14f40d4637c51008fd997bb67f04b7
jbellengerhttps://github.com/jbellenger
Mar 31, 2024https://github.com/graphql-java/graphql-java/pull/3551/files#r1545784510
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
bbakermanhttps://github.com/bbakerman
Apr 2, 2024https://github.com/graphql-java/graphql-java/pull/3551/files#r1547190638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
bbakermanhttps://github.com/bbakerman
Apr 2, 2024https://github.com/graphql-java/graphql-java/pull/3551/files#r1547191155
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3551/files
https://github.com/graphql-java/graphql-java/pull/3551/files#diff-0d448dca3f74fad5710a72f885217faa1c14f40d4637c51008fd997bb67f04b7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.