René's URL Explorer Experiment


Title: Allow schema diff to use SDL document to enforce directives by ndejaco2 · Pull Request #3344 · graphql-java/graphql-java · GitHub

Open Graph Title: Allow schema diff to use SDL document to enforce directives by ndejaco2 · Pull Request #3344 · graphql-java/graphql-java

X Title: Allow schema diff to use SDL document to enforce directives by ndejaco2 · Pull Request #3344 · graphql-java/graphql-java

Description: This PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet interface in place of it. There are two implementations of SchemaDiffSet provided: IntrospectionSchemaDiffSet and SDLSchemaDiffSet. Since introspection query does not return which elements directives are applied on, it does not properly enforce directives. The SDL schema diff set should always be used when attempting to enforce directives in a schema diff. I updated the unit tests to use both methods and validate that the response is equivalent for all but the directives use case. I am not super familiar with how major versioning is managed in this package, but I left the old implementation available and just marked it as Deprecated so let me know if there is any other way of going about this.

Open Graph Description: This PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet inter...

X Description: This PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet inter...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/3344

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:06264853-e8c9-a071-916c-cf2ee9e677a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC55A:1CFF52:4B1177:6652DC:6A62D44B
html-safe-nonce8962ff1cd9c584f460d5166020c0bf766eaf519d15fa91bd0dcc7847fa35d771
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTVBOjFDRkY1Mjo0QjExNzc6NjY1MkRDOjZBNjJENDRCIiwidmlzaXRvcl9pZCI6IjU3NDE1NDc4MzY4MTY5MzgwNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd57960bb6301de1c7723293dd9dd3817eb669595355572690ee718b76e9c2357
hovercard-subject-tagpull_request:1542456031
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/3344/files
twitter:imagehttps://avatars.githubusercontent.com/u/54116900?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/54116900?s=400&v=4
og:image:altThis PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet inter...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedf33b1b61ee7b9a0af988199bfc3503c9c1acafb1f1d40e1f140ea7c84f890dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released41cd1bdb290013455c0ac430fa755621733f5eb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/3344/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3344%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3344%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/3344/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/3344/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/3344/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344/files
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
Conversation 5 https://github.com/graphql-java/graphql-java/pull/3344
Commits 4 https://github.com/graphql-java/graphql-java/pull/3344/commits
Checks 0 https://github.com/graphql-java/graphql-java/pull/3344/checks
Files changed https://github.com/graphql-java/graphql-java/pull/3344/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344/files
Allow schema diff to use SDL document to enforce directives https://github.com/graphql-java/graphql-java/pull/3344/files#top
Show all changes 4 commits https://github.com/graphql-java/graphql-java/pull/3344/files
4b8537f Allow schema diff to use SDL document rather than requiring introspec… ndejaco2 Oct 4, 2023 https://github.com/graphql-java/graphql-java/pull/3344/commits/4b8537fda4df3e89873232d4765bfaccc90c8cda
69fb911 Fixup import ndejaco2 Oct 4, 2023 https://github.com/graphql-java/graphql-java/pull/3344/commits/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
3c49ca0 Use private constructor and store document directly based on PR comments ndejaco2 Oct 9, 2023 https://github.com/graphql-java/graphql-java/pull/3344/commits/3c49ca03d788d5e1f4ac6495fef1f1870e46f643
fcef0ef Re-use common builder code ndejaco2 Oct 9, 2023 https://github.com/graphql-java/graphql-java/pull/3344/commits/fcef0eff9260c73455429729c5288d04bed6cbad
Clear filters https://github.com/graphql-java/graphql-java/pull/3344/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344/files
DiffSet.java https://github.com/graphql-java/graphql-java/pull/3344/files#diff-8667a9adecfea1fae9389e95d59802afad5f4a256d3d1f0cd79711dc2a042bbf
SchemaDiff.java https://github.com/graphql-java/graphql-java/pull/3344/files#diff-f8ae67800bc6ccf812835aeaf9af66047050b36c94c1c529e6e8924baebdbcb9
SchemaDiffSet.java https://github.com/graphql-java/graphql-java/pull/3344/files#diff-52e22756f5d1127bd555bce29e6a4bd6ba12292ec1e95be689e6b685c1b1c969
SchemaDiffTest.groovy https://github.com/graphql-java/graphql-java/pull/3344/files#diff-9f79a913fba89ef2e355d4f62cb4e701993f24be9d88f94f86fbd33851bf674e
src/main/java/graphql/schema/diff/DiffSet.javahttps://github.com/graphql-java/graphql-java/pull/3344/files#diff-8667a9adecfea1fae9389e95d59802afad5f4a256d3d1f0cd79711dc2a042bbf
View file https://github.com/graphql-java/graphql-java/blob/fcef0eff9260c73455429729c5288d04bed6cbad/src/main/java/graphql/schema/diff/DiffSet.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/3344/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/3344/files#diff-8667a9adecfea1fae9389e95d59802afad5f4a256d3d1f0cd79711dc2a042bbf
https://github.com/graphql-java/graphql-java/pull/3344/files#diff-8667a9adecfea1fae9389e95d59802afad5f4a256d3d1f0cd79711dc2a042bbf
https://github.com/graphql-java/graphql-java/pull/3344/files#diff-8667a9adecfea1fae9389e95d59802afad5f4a256d3d1f0cd79711dc2a042bbf
src/main/java/graphql/schema/diff/SchemaDiff.javahttps://github.com/graphql-java/graphql-java/pull/3344/files#diff-f8ae67800bc6ccf812835aeaf9af66047050b36c94c1c529e6e8924baebdbcb9
View file https://github.com/graphql-java/graphql-java/blob/fcef0eff9260c73455429729c5288d04bed6cbad/src/main/java/graphql/schema/diff/SchemaDiff.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/3344/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/3344/files#diff-f8ae67800bc6ccf812835aeaf9af66047050b36c94c1c529e6e8924baebdbcb9
https://github.com/graphql-java/graphql-java/pull/3344/files#diff-f8ae67800bc6ccf812835aeaf9af66047050b36c94c1c529e6e8924baebdbcb9
https://github.com/graphql-java/graphql-java/pull/3344/files#diff-f8ae67800bc6ccf812835aeaf9af66047050b36c94c1c529e6e8924baebdbcb9
src/main/java/graphql/schema/diff/SchemaDiffSet.javahttps://github.com/graphql-java/graphql-java/pull/3344/files#diff-52e22756f5d1127bd555bce29e6a4bd6ba12292ec1e95be689e6b685c1b1c969
View file https://github.com/graphql-java/graphql-java/blob/fcef0eff9260c73455429729c5288d04bed6cbad/src/main/java/graphql/schema/diff/SchemaDiffSet.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/3344/{{ revealButtonHref }}
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.