René's URL Explorer Experiment


Title: Allow schema diff to use SDL document to enforce directives by ndejaco2 · Pull Request #3344 · graphql-java/graphql-java · GitHub

Open Graph Title: Allow schema diff to use SDL document to enforce directives by ndejaco2 · Pull Request #3344 · graphql-java/graphql-java

X Title: Allow schema diff to use SDL document to enforce directives by ndejaco2 · Pull Request #3344 · graphql-java/graphql-java

Description: GraphQL Java implementation. Contribute to graphql-java/graphql-java development by creating an account on GitHub.

Open Graph Description: This PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet inter...

X Description: This PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet inter...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/3344

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f005b48e-1ec9-137a-0b52-99f9e9c8fffb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9AE:17B75A:1EAA53:293F67:6A60240A
html-safe-nonce36cc71a58b722cdd99f256de50b7fa1fc66c617193246a78aafbf5e90ad1652b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUFFOjE3Qjc1QToxRUFBNTM6MjkzRjY3OjZBNjAyNDBBIiwidmlzaXRvcl9pZCI6IjI1MTg2MTUzNzczMDk2MDY5MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca6ed384e8821d6f7b1d4923d91f84ce13d20403242759c1504ad9989c777670d
hovercard-subject-tagpull_request:1542456031
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/3344/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9cf62b0789b5d81a0332cf764f2e3698955570c12a89c1b3987c4b6be4a63fed/graphql-java/graphql-java/pull/3344
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9cf62b0789b5d81a0332cf764f2e3698955570c12a89c1b3987c4b6be4a63fed/graphql-java/graphql-java/pull/3344
og:image:altThis PR is made to fix a bug (#3343) with SchemaDiff where the enforceDirectives option is not working properly. In this PR, I deprecate the DiffSet class and introduce the new SchemaDiffSet inter...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamendejaco2
hostnamegithub.com
expected-hostnamegithub.com
None60da8c2a42fa2bbf5f7567474990ec467836a84444262a58e200fa91b7f3d2d0
turbo-cache-controlno-cache
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9824515e740d83d5eb82168a089b806ab0fe04a1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/3344#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3344
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3344
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/3344
Reloadhttps://github.com/graphql-java/graphql-java/pull/3344
Reloadhttps://github.com/graphql-java/graphql-java/pull/3344
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
Conversationhttps://github.com/graphql-java/graphql-java/pull/3344
Commits4 (4)https://github.com/graphql-java/graphql-java/pull/3344/commits
Checkshttps://github.com/graphql-java/graphql-java/pull/3344/checks
Files changedhttps://github.com/graphql-java/graphql-java/pull/3344/files
Allow schema diff to use SDL document to enforce directiveshttps://github.com/graphql-java/graphql-java/pull/3344#top
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
https://github.com/ndejaco2
ndejaco2https://github.com/ndejaco2
Oct 4, 2023https://github.com/graphql-java/graphql-java/pull/3344#issue-1926905606
#3343https://github.com/graphql-java/graphql-java/issues/3343
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
ndejaco2https://github.com/ndejaco2
October 4, 2023 12:58https://github.com/graphql-java/graphql-java/pull/3344#commits-pushed-4b8537f
https://github.com/ndejaco2
Allow schema diff to use SDL document rather than requiring introspec…https://github.com/graphql-java/graphql-java/pull/3344/commits/4b8537fda4df3e89873232d4765bfaccc90c8cda
4b8537fhttps://github.com/graphql-java/graphql-java/pull/3344/commits/4b8537fda4df3e89873232d4765bfaccc90c8cda
https://github.com/ndejaco2
Fixup importhttps://github.com/graphql-java/graphql-java/pull/3344/commits/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
69fb911https://github.com/graphql-java/graphql-java/pull/3344/commits/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 7, 2023https://github.com/graphql-java/graphql-java/pull/3344#issuecomment-1751842988
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 7, 2023 https://github.com/graphql-java/graphql-java/pull/3344#pullrequestreview-1663116511
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
src/main/java/graphql/schema/diff/SDLSchemaDiffSet.javahttps://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa#diff-41c1a2dc09f07e9f6ecd5706b450071e89e2e3944b5381178809e6680c6531db
bbakermanhttps://github.com/bbakerman
Oct 7, 2023https://github.com/graphql-java/graphql-java/pull/3344#discussion_r1349581977
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
ndejaco2https://github.com/ndejaco2
Oct 9, 2023https://github.com/graphql-java/graphql-java/pull/3344#discussion_r1350724191
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
bbakermanhttps://github.com/bbakerman
Oct 11, 2023https://github.com/graphql-java/graphql-java/pull/3344#discussion_r1353822594
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 7, 2023 https://github.com/graphql-java/graphql-java/pull/3344#pullrequestreview-1663116566
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
src/main/java/graphql/schema/diff/IntrospectionSchemaDiffSet.javahttps://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa#diff-004a9a66e5114ef6c5639a8ed0d05a90685b6f70218b278211284cacc6817ad4
bbakermanhttps://github.com/bbakerman
Oct 7, 2023https://github.com/graphql-java/graphql-java/pull/3344#discussion_r1349582091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 7, 2023 https://github.com/graphql-java/graphql-java/pull/3344#pullrequestreview-1663116601
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
src/main/java/graphql/schema/diff/IntrospectionSchemaDiffSet.javahttps://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa#diff-004a9a66e5114ef6c5639a8ed0d05a90685b6f70218b278211284cacc6817ad4
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
ndejaco2https://github.com/ndejaco2
October 9, 2023 14:05https://github.com/graphql-java/graphql-java/pull/3344#commits-pushed-3c49ca0
https://github.com/ndejaco2
Use private constructor and store document directly based on PR commentshttps://github.com/graphql-java/graphql-java/pull/3344/commits/3c49ca03d788d5e1f4ac6495fef1f1870e46f643
3c49ca0https://github.com/graphql-java/graphql-java/pull/3344/commits/3c49ca03d788d5e1f4ac6495fef1f1870e46f643
https://github.com/ndejaco2
Re-use common builder codehttps://github.com/graphql-java/graphql-java/pull/3344/commits/fcef0eff9260c73455429729c5288d04bed6cbad
fcef0efhttps://github.com/graphql-java/graphql-java/pull/3344/commits/fcef0eff9260c73455429729c5288d04bed6cbad
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
2023 Octoberhttps://github.com/graphql-java/graphql-java/milestone/50
Oct 11, 2023https://github.com/graphql-java/graphql-java/pull/3344#event-10611978037
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 11, 2023https://github.com/graphql-java/graphql-java/pull/3344#event-10611978892
41ee58chttps://github.com/graphql-java/graphql-java/commit/41ee58cacad4c4bf5e5bd73b4bf863cebcdbd36b
Oct 11, 2023https://github.com/graphql-java/graphql-java/pull/3344#event-10611980937
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3344
https://github.com/bbakerman
bbakerman https://github.com/bbakerman
https://github.com/graphql-java/graphql-java/pull/3344/files/69fb9113a7d1d1c6a3af11f86d68604c84abdbaa
21.2 https://github.com/graphql-java/graphql-java/milestone/50
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3344
https://github.com/ndejaco2
https://github.com/bbakerman
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.