René's URL Explorer Experiment


Title: deprecated default value method produces bad results by bbakerman · Pull Request #3286 · graphql-java/graphql-java · GitHub

Open Graph Title: deprecated default value method produces bad results by bbakerman · Pull Request #3286 · graphql-java/graphql-java

X Title: deprecated default value method produces bad results by bbakerman · Pull Request #3286 · graphql-java/graphql-java

Description: GraphQL Java implementation. Contribute to graphql-java/graphql-java development by creating an account on GitHub.

Open Graph Description: This fixes the deprecated defaultValue input of null values when an AST literal is required - eg in schema printing and introspection. see #3285

X Description: This fixes the deprecated defaultValue input of null values when an AST literal is required - eg in schema printing and introspection. see #3285

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/3286

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:33b8881f-f762-5caa-8ad2-c79a6ab2fe59
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92D2:3C912D:2EFBE17:4428611:6A60EA97
html-safe-nonced7d6528c6586cc00d2500c8feacdd6d444f4ea5b5df3f3169bf1ea497ef8e90f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkQyOjNDOTEyRDoyRUZCRTE3OjQ0Mjg2MTE6NkE2MEVBOTciLCJ2aXNpdG9yX2lkIjoiNDgyOTI0MjYyNzkwMzc3NzQzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1747f311902cf9603c6ead0c7455878c31a394fb8967fb1b6f5ab3cbab566750
hovercard-subject-tagpull_request:1467865078
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/3286/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bd00706890019d746ef1f578a967497df2545fc0c00da5f38a93ca1d9b4d90e7/graphql-java/graphql-java/pull/3286
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd00706890019d746ef1f578a967497df2545fc0c00da5f38a93ca1d9b4d90e7/graphql-java/graphql-java/pull/3286
og:image:altThis fixes the deprecated defaultValue input of null values when an AST literal is required - eg in schema printing and introspection. see #3285
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebbakerman
hostnamegithub.com
expected-hostnamegithub.com
None3ba36a464b9464992131f4003292a219fc87f92404b0dbe3fd1ef07f11102d0f
turbo-cache-controlno-cache
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2cc5e4f897a27632dd600edfec4c737bea2f8338
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/3286#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3286
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3286
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/3286
Reloadhttps://github.com/graphql-java/graphql-java/pull/3286
Reloadhttps://github.com/graphql-java/graphql-java/pull/3286
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
dondonzhttps://github.com/dondonz
masterhttps://github.com/graphql-java/graphql-java/tree/master
3285_default_value_problemshttps://github.com/graphql-java/graphql-java/tree/3285_default_value_problems
Conversationhttps://github.com/graphql-java/graphql-java/pull/3286
Commits2 (2)https://github.com/graphql-java/graphql-java/pull/3286/commits
Checkshttps://github.com/graphql-java/graphql-java/pull/3286/checks
Files changedhttps://github.com/graphql-java/graphql-java/pull/3286/files
deprecated default value method produces bad resultshttps://github.com/graphql-java/graphql-java/pull/3286#top
dondonzhttps://github.com/dondonz
masterhttps://github.com/graphql-java/graphql-java/tree/master
3285_default_value_problemshttps://github.com/graphql-java/graphql-java/tree/3285_default_value_problems
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 9, 2023https://github.com/graphql-java/graphql-java/pull/3286#issue-1842395370
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
#3285https://github.com/graphql-java/graphql-java/issues/3285
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
bbakermanhttps://github.com/bbakerman
August 9, 2023 13:27https://github.com/graphql-java/graphql-java/pull/3286#commits-pushed-f112054
https://github.com/bbakerman
deprecated default value method produces bad resultshttps://github.com/graphql-java/graphql-java/pull/3286/commits/f11205448c990b0a2ad3ced48fa9dae055aa92ab
f112054https://github.com/graphql-java/graphql-java/pull/3286/commits/f11205448c990b0a2ad3ced48fa9dae055aa92ab
https://github.com/bbakerman
Fixed the ValuesResolverConversion to handle programmatically set nullshttps://github.com/graphql-java/graphql-java/pull/3286/commits/b79540b1db0a9fffe02765205762391c1271673b
b79540bhttps://github.com/graphql-java/graphql-java/pull/3286/commits/b79540b1db0a9fffe02765205762391c1271673b
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 10, 2023 https://github.com/graphql-java/graphql-java/pull/3286#pullrequestreview-1570994298
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b
src/main/java/graphql/execution/ValuesResolverConversion.javahttps://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
bbakermanhttps://github.com/bbakerman
Aug 10, 2023https://github.com/graphql-java/graphql-java/pull/3286#discussion_r1289531880
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 10, 2023 https://github.com/graphql-java/graphql-java/pull/3286#pullrequestreview-1570994736
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b
src/test/groovy/graphql/introspection/IntrospectionTest.groovyhttps://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b#diff-1fc092bbd53604c038f6b3286870ff2cbdc13cddfaf6b2532ebb45286a1f2786
bbakermanhttps://github.com/bbakerman
Aug 10, 2023https://github.com/graphql-java/graphql-java/pull/3286#discussion_r1289532188
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 10, 2023 https://github.com/graphql-java/graphql-java/pull/3286#pullrequestreview-1570995150
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b
src/test/groovy/graphql/introspection/IntrospectionTest.groovyhttps://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b#diff-1fc092bbd53604c038f6b3286870ff2cbdc13cddfaf6b2532ebb45286a1f2786
bbakermanhttps://github.com/bbakerman
Aug 10, 2023https://github.com/graphql-java/graphql-java/pull/3286#discussion_r1289532550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
2023 Octoberhttps://github.com/graphql-java/graphql-java/milestone/50
Aug 10, 2023https://github.com/graphql-java/graphql-java/pull/3286#event-10054495455
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
needs to be backported https://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3A%22needs%20to%20be%20backported%22
Aug 10, 2023https://github.com/graphql-java/graphql-java/pull/3286#event-10054496164
https://github.com/dondonz
dondonzhttps://github.com/dondonz
Aug 21, 2023 https://github.com/graphql-java/graphql-java/pull/3286#pullrequestreview-1586253512
View reviewed changes https://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b
https://github.com/dondonz
dondonzhttps://github.com/dondonz
Aug 21, 2023https://github.com/graphql-java/graphql-java/pull/3286#event-10141349032
a54bb43https://github.com/graphql-java/graphql-java/commit/a54bb43936a3b68fe44ee55032e407c8a703c263
Aug 21, 2023https://github.com/graphql-java/graphql-java/pull/3286#event-10141351049
dondonzhttps://github.com/dondonz
Aug 21, 2023 https://github.com/graphql-java/graphql-java/pull/3286#ref-commit-43f479e
https://github.com/dondonz
Backport null value bugfix to v20, PRhttps://github.com/graphql-java/graphql-java/commit/43f479e16aad87724b1ef29a9a279ef57b50b942
#3286https://github.com/graphql-java/graphql-java/pull/3286
https://github.com/graphq…https://github.com/graphql-java/graphql-java/pull/3286/files
43f479ehttps://github.com/graphql-java/graphql-java/commit/43f479e16aad87724b1ef29a9a279ef57b50b942
…l-java/graphql-java/pull/3286/fileshttps://github.com/graphql-java/graphql-java/pull/3286/files
20.x backport of #3286 null default value bugfix #3293 https://github.com/graphql-java/graphql-java/pull/3293
19.x backport of #3286 null default value bugfix #3294 https://github.com/graphql-java/graphql-java/pull/3294
Remove deprecated .defaultValue() method #3285 https://github.com/graphql-java/graphql-java/issues/3285
bbakermanhttps://github.com/bbakerman
Aug 22, 2023 https://github.com/graphql-java/graphql-java/pull/3286#ref-commit-3c3d875
https://github.com/dondonz
Backport null value bugfix to v20, PRhttps://github.com/graphql-java/graphql-java/commit/3c3d87537f3491adf12dc11315c3243f7f68c933
#3286https://github.com/graphql-java/graphql-java/pull/3286
https://github.com/graphq…https://github.com/graphql-java/graphql-java/pull/3286/files
3c3d875https://github.com/graphql-java/graphql-java/commit/3c3d87537f3491adf12dc11315c3243f7f68c933
…l-java/graphql-java/pull/3286/fileshttps://github.com/graphql-java/graphql-java/pull/3286/files
#3293https://github.com/graphql-java/graphql-java/pull/3293
bbakermanhttps://github.com/bbakerman
Aug 22, 2023 https://github.com/graphql-java/graphql-java/pull/3286#ref-commit-3e7f0e8
https://github.com/dondonz
19.x backport ofhttps://github.com/graphql-java/graphql-java/commit/3e7f0e870cfa2aa7e43396f829570909265c2ac5
#3286https://github.com/graphql-java/graphql-java/pull/3286
null default value bugfix (https://github.com/graphql-java/graphql-java/commit/3e7f0e870cfa2aa7e43396f829570909265c2ac5
#3294https://github.com/graphql-java/graphql-java/pull/3294
)https://github.com/graphql-java/graphql-java/commit/3e7f0e870cfa2aa7e43396f829570909265c2ac5
3e7f0e8https://github.com/graphql-java/graphql-java/commit/3e7f0e870cfa2aa7e43396f829570909265c2ac5
https://github.com/graphql-java/graphql-java/pull/3286/fileshttps://github.com/graphql-java/graphql-java/pull/3286/files
https://github.com/dondonz
dondonzhttps://github.com/dondonz
August 29, 2023 00:59https://github.com/graphql-java/graphql-java/pull/3286#event-10215198325
dondonzhttps://github.com/dondonz
Aug 31, 2023 https://github.com/graphql-java/graphql-java/pull/3286#ref-commit-e11e254
https://github.com/dondonz
Merge pull requesthttps://github.com/graphql-java/graphql-java/commit/e11e254fc38d4a09d8f0f47725c6bb451bc0e3ee
#3286https://github.com/graphql-java/graphql-java/pull/3286
from graphql-java/3285_default_value_problemshttps://github.com/graphql-java/graphql-java/commit/e11e254fc38d4a09d8f0f47725c6bb451bc0e3ee
e11e254https://github.com/graphql-java/graphql-java/commit/e11e254fc38d4a09d8f0f47725c6bb451bc0e3ee
a54bb43https://github.com/graphql-java/graphql-java/commit/a54bb43936a3b68fe44ee55032e407c8a703c263
https://github.com/dondonz
dondonzhttps://github.com/dondonz
Aug 31, 2023 https://github.com/graphql-java/graphql-java/pull/3286#ref-pullrequest-1874864431
21.x Cherry pick pull request #3286 #3315 https://github.com/graphql-java/graphql-java/pull/3315
dondonzhttps://github.com/dondonz
Sep 4, 2023 https://github.com/graphql-java/graphql-java/pull/3286#ref-commit-ff491fe
https://github.com/dondonz
Merge pull requesthttps://github.com/graphql-java/graphql-java/commit/ff491fed4f6b999035d0c4c88f8fa76eeeedb3db
#3315https://github.com/graphql-java/graphql-java/pull/3315
from graphql-java/21.x-backport-of-3286-null…https://github.com/graphql-java/graphql-java/commit/ff491fed4f6b999035d0c4c88f8fa76eeeedb3db
ff491fehttps://github.com/graphql-java/graphql-java/commit/ff491fed4f6b999035d0c4c88f8fa76eeeedb3db
#3286https://github.com/graphql-java/graphql-java/pull/3286
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F3286
https://github.com/dondonz
dondonz https://github.com/dondonz
https://github.com/graphql-java/graphql-java/pull/3286/files/b79540b1db0a9fffe02765205762391c1271673b
needs to be backported https://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3A%22needs%20to%20be%20backported%22
21.2 https://github.com/graphql-java/graphql-java/milestone/50
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/3286
https://github.com/bbakerman
https://github.com/dondonz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.