René's URL Explorer Experiment

Title: Max query depth called later in beginExecuteOperation by bbakerman · Pull Request #2773 · graphql-java/graphql-java · GitHub

Open Graph Title: Max query depth called later in beginExecuteOperation by bbakerman · Pull Request #2773 · graphql-java/graphql-java

X Title: Max query depth called later in beginExecuteOperation by bbakerman · Pull Request #2773 · graphql-java/graphql-java

Description: Previously the MaxQuery depth instrumentation was called on the end of the validation step. But this is too early if there are null / non null variables mismatched. This caused and exception to be thrown and not a graphql error. We now call the instrumentation during the beginExecuteOperation which is JUST before execution proper and not after validation - because the Execution code does some more sensibility checks on the state of the call I started this branch from #2763 which showed the problem happening I am leaving that PR so we can improve the error messages - but this PR fixes the actual problem in the sense query checks are done a smidge later and avoid the problem all together

Open Graph Description: Previously the MaxQuery depth instrumentation was called on the end of the validation step. But this is too early if there are null / non null variables mismatched. This caused and exception to b...

X Description: Previously the MaxQuery depth instrumentation was called on the end of the validation step. But this is too early if there are null / non null variables mismatched. This caused and exception to b...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/2773

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width