René's URL Explorer Experiment


Title: SPIKE - WIP - Another PR that shows how we could transition to the new idea of state per instrumentation method call by bbakerman · Pull Request #2747 · graphql-java/graphql-java · GitHub

Open Graph Title: SPIKE - WIP - Another PR that shows how we could transition to the new idea of state per instrumentation method call by bbakerman · Pull Request #2747 · graphql-java/graphql-java

X Title: SPIKE - WIP - Another PR that shows how we could transition to the new idea of state per instrumentation method call by bbakerman · Pull Request #2747 · graphql-java/graphql-java

Description: I wanted to spike whether we can transition to passing "state" to each instrumentation method call rather than creating an object. I think this works really well and is NON API breaking. If we did this I think we would deprecated the old methods that only take a "parameter with state" object deprecater the getState on the parameter objects create side line default methods for each instrumentation method so it takes state but it calls back like these do go through the provided graphql-java instrumentations and make them only use the new methods

Open Graph Description: I wanted to spike whether we can transition to passing "state" to each instrumentation method call rather than creating an object. I think this works really well and is NON API breaking. ...

X Description: I wanted to spike whether we can transition to passing "state" to each instrumentation method call rather than creating an object. I think this works really well and is NON API br...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/2747

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9026a943-9062-bfc5-ba70-b4fd2edb1856
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D9E:DC4AA:23B71F:2F1E3C:6A615E01
html-safe-nonce250e16bc651a617187841c9f7e49b6581abb2d66ee474261ab0b366b34e58d43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDlFOkRDNEFBOjIzQjcxRjoyRjFFM0M6NkE2MTVFMDEiLCJ2aXNpdG9yX2lkIjoiMzYxMjU3NDUzNTc4OTkyNzkzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98cbabe540693289f2e5a244961e2e2ed6a0bfe8b467fd2a1c12fd6f4959b7cb
hovercard-subject-tagpull_request:866208230
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/2747/files
twitter:imagehttps://avatars.githubusercontent.com/u/1661769?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1661769?s=400&v=4
og:image:altI wanted to spike whether we can transition to passing "state" to each instrumentation method call rather than creating an object. I think this works really well and is NON API breaking. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec258d2b06b498220e3b94af28b26bbbf58f4203a6373725f779afcc867afd263
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5f67bc431418961e0814f1eb30a4231250e4726d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/2747/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2747%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2747%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/2747/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/2747/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/2747/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2747/files
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
masterhttps://github.com/graphql-java/graphql-java/tree/master
spike_new_intrumentation_methodshttps://github.com/graphql-java/graphql-java/tree/spike_new_intrumentation_methods
Conversation 3 https://github.com/graphql-java/graphql-java/pull/2747
Commits 2 https://github.com/graphql-java/graphql-java/pull/2747/commits
Checks 0 https://github.com/graphql-java/graphql-java/pull/2747/checks
Files changed https://github.com/graphql-java/graphql-java/pull/2747/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2747/files
SPIKE - WIP - Another PR that shows how we could transition to the new idea of state per instrumentation method call https://github.com/graphql-java/graphql-java/pull/2747/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/2747/files
003bfdc Another WIP PR that shows how we could transition to the new idea of … bbakerman Feb 27, 2022 https://github.com/graphql-java/graphql-java/pull/2747/commits/003bfdc27ddc571142bcc322093aa847d799e2ff
3cb1003 Opps didnt write it right bbakerman Feb 27, 2022 https://github.com/graphql-java/graphql-java/pull/2747/commits/3cb1003f1c396592b0dfce3b958fa1013c607c0f
Clear filters https://github.com/graphql-java/graphql-java/pull/2747/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2747/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2747/files
ExecutionStrategy.java https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
SubscriptionExecutionStrategy.java https://github.com/graphql-java/graphql-java/pull/2747/files#diff-da691711ac23bdc55fd1249f5b2730f7cc880ce1fa553e17af2bb1fac9fdb62f
ChainedInstrumentation.java https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
Instrumentation.java https://github.com/graphql-java/graphql-java/pull/2747/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
src/main/java/graphql/execution/ExecutionStrategy.javahttps://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
View file https://github.com/graphql-java/graphql-java/blob/3cb1003f1c396592b0dfce3b958fa1013c607c0f/src/main/java/graphql/execution/ExecutionStrategy.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/2747/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
src/main/java/graphql/execution/SubscriptionExecutionStrategy.javahttps://github.com/graphql-java/graphql-java/pull/2747/files#diff-da691711ac23bdc55fd1249f5b2730f7cc880ce1fa553e17af2bb1fac9fdb62f
View file https://github.com/graphql-java/graphql-java/blob/3cb1003f1c396592b0dfce3b958fa1013c607c0f/src/main/java/graphql/execution/SubscriptionExecutionStrategy.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/2747/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-da691711ac23bdc55fd1249f5b2730f7cc880ce1fa553e17af2bb1fac9fdb62f
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-da691711ac23bdc55fd1249f5b2730f7cc880ce1fa553e17af2bb1fac9fdb62f
src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.javahttps://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
View file https://github.com/graphql-java/graphql-java/blob/3cb1003f1c396592b0dfce3b958fa1013c607c0f/src/main/java/graphql/execution/instrumentation/ChainedInstrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/2747/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
bbakermanhttps://github.com/bbakerman
Feb 27, 2022https://github.com/graphql-java/graphql-java/pull/2747/files#r815502212
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2747/files
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-7ed3ed5d020e3ef59d0ea9d8377462c57344297c79152be0d5f4a43d75514488
src/main/java/graphql/execution/instrumentation/Instrumentation.javahttps://github.com/graphql-java/graphql-java/pull/2747/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
View file https://github.com/graphql-java/graphql-java/blob/3cb1003f1c396592b0dfce3b958fa1013c607c0f/src/main/java/graphql/execution/instrumentation/Instrumentation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/2747/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com/graphql-java/graphql-java/pull/2747/files#diff-3bddad0fe837b5f4e9f8eb4a91b944e1aa5bc74563c63481e4d66af028a6787b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.