| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dd273def-d7e2-4a71-2128-bf8cfa4673aa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C76E:29843:3CFC8C:50A30E:6A614F81 |
| html-safe-nonce | 1610d10ac2458d7195c480355a8a2b176ffd3d8f7f259ba9c57cd5836703b471 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzZFOjI5ODQzOjNDRkM4Qzo1MEEzMEU6NkE2MTRGODEiLCJ2aXNpdG9yX2lkIjoiNTc3MTc3NzM4NDMwOTE0OTU2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 967cdf958791b98ce990ff7bb17c94055b6fa758fa3f48b5da2c6fe1411a2e98 |
| hovercard-subject-tag | pull_request:749862831 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/2573/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9c7851918c7ee52a420bb1a6f9cfdce77916ac78a1eb1f43b3145b6c0e4f53ff/graphql-java/graphql-java/pull/2573 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9c7851918c7ee52a420bb1a6f9cfdce77916ac78a1eb1f43b3145b6c0e4f53ff/graphql-java/graphql-java/pull/2573 |
| og:image:alt | Hi folks!
Problem
Graphql-java currently fails the document validation for queries that use nullable types for non-nullable schema field arguments with default values. As per spec:
A notable excep... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | folone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 35b919fdb8e6752d2ed95a144e761ca5e924557563e2ed0a5ebf6c4430cdeeb6 |
| turbo-cache-control | no-cache |
| go-import | github.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git |
| octolytics-dimension-user_id | 14289921 |
| octolytics-dimension-user_login | graphql-java |
| octolytics-dimension-repository_id | 38602457 |
| octolytics-dimension-repository_nwo | graphql-java/graphql-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38602457 |
| octolytics-dimension-repository_network_root_nwo | graphql-java/graphql-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1e22b08b60ccb67c3791f565bed248565260e611 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/graphql-java/graphql-java/pull/2573#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2573 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2573 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java |
| Reload | https://github.com/graphql-java/graphql-java/pull/2573 |
| Reload | https://github.com/graphql-java/graphql-java/pull/2573 |
| Reload | https://github.com/graphql-java/graphql-java/pull/2573 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
|
graphql-java
| https://github.com/graphql-java |
| graphql-java | https://github.com/graphql-java/graphql-java |
|
Notifications
| https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java |
|
Fork
1.1k
| https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java |
|
Star
6.2k
| https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java |
|
Code
| https://github.com/graphql-java/graphql-java |
|
Issues
26
| https://github.com/graphql-java/graphql-java/issues |
|
Pull requests
11
| https://github.com/graphql-java/graphql-java/pulls |
|
Discussions
| https://github.com/graphql-java/graphql-java/discussions |
|
Actions
| https://github.com/graphql-java/graphql-java/actions |
|
Projects
| https://github.com/graphql-java/graphql-java/projects |
|
Wiki
| https://github.com/graphql-java/graphql-java/wiki |
|
Security and quality
0
| https://github.com/graphql-java/graphql-java/security |
|
Insights
| https://github.com/graphql-java/graphql-java/pulse |
|
Code
| https://github.com/graphql-java/graphql-java |
|
Issues
| https://github.com/graphql-java/graphql-java/issues |
|
Pull requests
| https://github.com/graphql-java/graphql-java/pulls |
|
Discussions
| https://github.com/graphql-java/graphql-java/discussions |
|
Actions
| https://github.com/graphql-java/graphql-java/actions |
|
Projects
| https://github.com/graphql-java/graphql-java/projects |
|
Wiki
| https://github.com/graphql-java/graphql-java/wiki |
|
Security and quality
| https://github.com/graphql-java/graphql-java/security |
|
Insights
| https://github.com/graphql-java/graphql-java/pulse |
| bbakerman | https://github.com/bbakerman |
| graphql-java:master | https://github.com/graphql-java/graphql-java/tree/master |
| folone:gleontiev/schema-default-value | https://github.com/folone/graphql-java/tree/gleontiev/schema-default-value |
| Conversation | https://github.com/graphql-java/graphql-java/pull/2573 |
| Commits2 (2) | https://github.com/graphql-java/graphql-java/pull/2573/commits |
| Checks | https://github.com/graphql-java/graphql-java/pull/2573/checks |
| Files changed | https://github.com/graphql-java/graphql-java/pull/2573/files |
| Bugfix: spec-compliant behaviour for non-nullable types with default values. | https://github.com/graphql-java/graphql-java/pull/2573#top |
| bbakerman | https://github.com/bbakerman |
| graphql-java:master | https://github.com/graphql-java/graphql-java/tree/master |
| folone:gleontiev/schema-default-value | https://github.com/folone/graphql-java/tree/gleontiev/schema-default-value |
|
| https://github.com/folone |
| folone | https://github.com/folone |
| Oct 5, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#issue-1016313923 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| spec | https://spec.graphql.org/June2018/#sec-All-Variable-Usages-are-Allowed |
| graphql/graphql-spec#418 | https://github.com/graphql/graphql-spec/pull/418 |
| test in the reference GraphQL implementation | https://github.com/graphql/graphql-js/blob/main/src/execution/__tests__/variables-test.ts#L994-L1008 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| October 5, 2021 14:04 | https://github.com/graphql-java/graphql-java/pull/2573#commits-pushed-4528bb2 |
| Bugfix: don't fail document validation when nullable type is provided… | https://github.com/graphql-java/graphql-java/pull/2573/commits/4528bb2925f2f3b8acda40d19610a2b085a6bbd7 |
| 4528bb2 | https://github.com/graphql-java/graphql-java/pull/2573/commits/4528bb2925f2f3b8acda40d19610a2b085a6bbd7 |
| Fix failing tests. | https://github.com/graphql-java/graphql-java/pull/2573/commits/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
| e5d0db5 | https://github.com/graphql-java/graphql-java/pull/2573/commits/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
| https://github.com/folone |
| folone | https://github.com/folone |
| October 5, 2021 13:37 | https://github.com/graphql-java/graphql-java/pull/2573#event-5410856130 |
| https://github.com/folone |
| folone | https://github.com/folone |
| Oct 5, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#event-5411094345 |
| https://github.com/jbellenger |
| jbellenger | https://github.com/jbellenger |
| Oct 5, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#issuecomment-934522872 |
| a test case in graphql-js | https://github.com/graphql/graphql-js/blob/main/src/execution/__tests__/variables-test.ts#L994-L1008 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| https://github.com/folone |
| folone | https://github.com/folone |
| Oct 6, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#event-5420486951 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Oct 9, 2021
| https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-775537446 |
|
View reviewed changes
| https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
| src/main/java/graphql/validation/rules/VariableTypesMatchRule.java | https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030#diff-e3626ca5d1799f3b213fb8bf2e24db41acb47965bb57eeba256473d6a036a563 |
| bbakerman | https://github.com/bbakerman |
| Oct 9, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#discussion_r725425151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @andimarek | https://github.com/andimarek |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| andimarek | https://github.com/andimarek |
| Dec 20, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#discussion_r772066159 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| folone | https://github.com/folone |
| Dec 22, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#discussion_r773836543 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @andimarek | https://github.com/andimarek |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Oct 9, 2021
| https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-775537523 |
|
View reviewed changes
| https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
| https://github.com/andimarek |
| andimarek | https://github.com/andimarek |
|
Dec 20, 2021
| https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-835978900 |
|
View reviewed changes
| https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
| andimarek | https://github.com/andimarek |
| https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-835978900 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
| 18.0 | https://github.com/graphql-java/graphql-java/milestone/34 |
| Dec 27, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#event-5816364409 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
| 309fb9e | https://github.com/graphql-java/graphql-java/commit/309fb9e1747f05ce0f3c52c6aa92570a11144dab |
| Dec 27, 2021 | https://github.com/graphql-java/graphql-java/pull/2573#event-5816364525 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Aug 3, 2023
| https://github.com/graphql-java/graphql-java/pull/2573#ref-pullrequest-1832114356 |
|
Bug 3276 - default values not being used correctly during validation
#3278
| https://github.com/graphql-java/graphql-java/pull/3278 |
| https://github.co/hiddenchars |
| https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2573 |
|
| https://github.com/andimarek |
|
andimarek
| https://github.com/andimarek |
|
| https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
|
| https://github.com/bbakerman |
|
bbakerman
| https://github.com/bbakerman |
|
| https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030 |
|
18.0
| https://github.com/graphql-java/graphql-java/milestone/34 |
| Please reload this page | https://github.com/graphql-java/graphql-java/pull/2573 |
|
| https://github.com/folone |
|
| https://github.com/jbellenger |
|
| https://github.com/bbakerman |
|
| https://github.com/andimarek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |