René's URL Explorer Experiment


Title: Bugfix: spec-compliant behaviour for non-nullable types with default values. by folone · Pull Request #2573 · graphql-java/graphql-java · GitHub

Open Graph Title: Bugfix: spec-compliant behaviour for non-nullable types with default values. by folone · Pull Request #2573 · graphql-java/graphql-java

X Title: Bugfix: spec-compliant behaviour for non-nullable types with default values. by folone · Pull Request #2573 · graphql-java/graphql-java

Description: GraphQL Java implementation. Contribute to graphql-java/graphql-java development by creating an account on GitHub.

Open Graph Description: Hi folks! Problem Graphql-java currently fails the document validation for queries that use nullable types for non-nullable schema field arguments with default values. As per spec: A notable excep...

X Description: Hi folks! Problem Graphql-java currently fails the document validation for queries that use nullable types for non-nullable schema field arguments with default values. As per spec: A notable excep...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/2573

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dd273def-d7e2-4a71-2128-bf8cfa4673aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC76E:29843:3CFC8C:50A30E:6A614F81
html-safe-nonce1610d10ac2458d7195c480355a8a2b176ffd3d8f7f259ba9c57cd5836703b471
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzZFOjI5ODQzOjNDRkM4Qzo1MEEzMEU6NkE2MTRGODEiLCJ2aXNpdG9yX2lkIjoiNTc3MTc3NzM4NDMwOTE0OTU2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac967cdf958791b98ce990ff7bb17c94055b6fa758fa3f48b5da2c6fe1411a2e98
hovercard-subject-tagpull_request:749862831
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/graphql-java/2573/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c7851918c7ee52a420bb1a6f9cfdce77916ac78a1eb1f43b3145b6c0e4f53ff/graphql-java/graphql-java/pull/2573
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c7851918c7ee52a420bb1a6f9cfdce77916ac78a1eb1f43b3145b6c0e4f53ff/graphql-java/graphql-java/pull/2573
og:image:altHi folks! Problem Graphql-java currently fails the document validation for queries that use nullable types for non-nullable schema field arguments with default values. As per spec: A notable excep...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefolone
hostnamegithub.com
expected-hostnamegithub.com
None35b919fdb8e6752d2ed95a144e761ca5e924557563e2ed0a5ebf6c4430cdeeb6
turbo-cache-controlno-cache
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1e22b08b60ccb67c3791f565bed248565260e611
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/2573#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2573
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2573
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/2573
Reloadhttps://github.com/graphql-java/graphql-java/pull/2573
Reloadhttps://github.com/graphql-java/graphql-java/pull/2573
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
folone:gleontiev/schema-default-valuehttps://github.com/folone/graphql-java/tree/gleontiev/schema-default-value
Conversationhttps://github.com/graphql-java/graphql-java/pull/2573
Commits2 (2)https://github.com/graphql-java/graphql-java/pull/2573/commits
Checkshttps://github.com/graphql-java/graphql-java/pull/2573/checks
Files changedhttps://github.com/graphql-java/graphql-java/pull/2573/files
Bugfix: spec-compliant behaviour for non-nullable types with default values.https://github.com/graphql-java/graphql-java/pull/2573#top
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
folone:gleontiev/schema-default-valuehttps://github.com/folone/graphql-java/tree/gleontiev/schema-default-value
https://github.com/folone
folonehttps://github.com/folone
Oct 5, 2021https://github.com/graphql-java/graphql-java/pull/2573#issue-1016313923
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
spechttps://spec.graphql.org/June2018/#sec-All-Variable-Usages-are-Allowed
graphql/graphql-spec#418https://github.com/graphql/graphql-spec/pull/418
test in the reference GraphQL implementationhttps://github.com/graphql/graphql-js/blob/main/src/execution/__tests__/variables-test.ts#L994-L1008
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
October 5, 2021 14:04https://github.com/graphql-java/graphql-java/pull/2573#commits-pushed-4528bb2
Bugfix: don't fail document validation when nullable type is provided…https://github.com/graphql-java/graphql-java/pull/2573/commits/4528bb2925f2f3b8acda40d19610a2b085a6bbd7
4528bb2https://github.com/graphql-java/graphql-java/pull/2573/commits/4528bb2925f2f3b8acda40d19610a2b085a6bbd7
Fix failing tests.https://github.com/graphql-java/graphql-java/pull/2573/commits/e5d0db505fa2df078ff95af3a4a83304c53fa030
e5d0db5https://github.com/graphql-java/graphql-java/pull/2573/commits/e5d0db505fa2df078ff95af3a4a83304c53fa030
https://github.com/folone
folonehttps://github.com/folone
October 5, 2021 13:37https://github.com/graphql-java/graphql-java/pull/2573#event-5410856130
https://github.com/folone
folonehttps://github.com/folone
Oct 5, 2021https://github.com/graphql-java/graphql-java/pull/2573#event-5411094345
https://github.com/jbellenger
jbellengerhttps://github.com/jbellenger
Oct 5, 2021https://github.com/graphql-java/graphql-java/pull/2573#issuecomment-934522872
a test case in graphql-jshttps://github.com/graphql/graphql-js/blob/main/src/execution/__tests__/variables-test.ts#L994-L1008
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
https://github.com/folone
folonehttps://github.com/folone
Oct 6, 2021https://github.com/graphql-java/graphql-java/pull/2573#event-5420486951
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 9, 2021 https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-775537446
View reviewed changes https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030
src/main/java/graphql/validation/rules/VariableTypesMatchRule.javahttps://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030#diff-e3626ca5d1799f3b213fb8bf2e24db41acb47965bb57eeba256473d6a036a563
bbakermanhttps://github.com/bbakerman
Oct 9, 2021https://github.com/graphql-java/graphql-java/pull/2573#discussion_r725425151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@andimarekhttps://github.com/andimarek
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
andimarekhttps://github.com/andimarek
Dec 20, 2021https://github.com/graphql-java/graphql-java/pull/2573#discussion_r772066159
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
folonehttps://github.com/folone
Dec 22, 2021https://github.com/graphql-java/graphql-java/pull/2573#discussion_r773836543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@andimarekhttps://github.com/andimarek
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Oct 9, 2021 https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-775537523
View reviewed changes https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030
https://github.com/andimarek
andimarekhttps://github.com/andimarek
Dec 20, 2021 https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-835978900
View reviewed changes https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030
andimarekhttps://github.com/andimarek
https://github.com/graphql-java/graphql-java/pull/2573#pullrequestreview-835978900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
18.0https://github.com/graphql-java/graphql-java/milestone/34
Dec 27, 2021https://github.com/graphql-java/graphql-java/pull/2573#event-5816364409
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
309fb9ehttps://github.com/graphql-java/graphql-java/commit/309fb9e1747f05ce0f3c52c6aa92570a11144dab
Dec 27, 2021https://github.com/graphql-java/graphql-java/pull/2573#event-5816364525
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 3, 2023 https://github.com/graphql-java/graphql-java/pull/2573#ref-pullrequest-1832114356
Bug 3276 - default values not being used correctly during validation #3278 https://github.com/graphql-java/graphql-java/pull/3278
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2573
https://github.com/andimarek
andimarek https://github.com/andimarek
https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030
https://github.com/bbakerman
bbakerman https://github.com/bbakerman
https://github.com/graphql-java/graphql-java/pull/2573/files/e5d0db505fa2df078ff95af3a4a83304c53fa030
18.0 https://github.com/graphql-java/graphql-java/milestone/34
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2573
https://github.com/folone
https://github.com/jbellenger
https://github.com/bbakerman
https://github.com/andimarek
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.