René's URL Explorer Experiment


Title: Experimental: use Normalized fields instead of lazy collect field by andimarek · Pull Request #2358 · graphql-java/graphql-java · GitHub

Open Graph Title: Experimental: use Normalized fields instead of lazy collect field by andimarek · Pull Request #2358 · graphql-java/graphql-java

X Title: Experimental: use Normalized fields instead of lazy collect field by andimarek · Pull Request #2358 · graphql-java/graphql-java

Description: This change leverages the normalized query structure to collect the merged subfields instead of calling collectFields on demand. This aims to improve the performance for especially large and deep queries with a lot of overlapping fields: the theory is that a one time build Normalized query is faster than the lazy/on demand collectFields code. If this really improves the performance needs to be verified. This potentially also enables caching of a normalized query which means the merging of overlapping fields could be cached. One aspect to consider is that a NQ is currently not independent of the variables: it needs all variables present to be build.

Open Graph Description: This change leverages the normalized query structure to collect the merged subfields instead of calling collectFields on demand. This aims to improve the performance for especially large and deep q...

X Description: This change leverages the normalized query structure to collect the merged subfields instead of calling collectFields on demand. This aims to improve the performance for especially large and deep q...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/2358

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cb73c4e8-5ef4-44a1-e6b4-8e86416c10d1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA18A:317608:2ADD0D9:36446AA:6B01A5A3
html-safe-noncedf0c15003a1864ef1e38ff7d02b5af5e215f8caea2bac9102ab572d86eeed21b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMThBOjMxNzYwODoyQUREMEQ5OjM2NDQ2QUE6NkIwMUE1QTMiLCJ2aXNpdG9yX2lkIjoiNjc0NDE1OTY2Mzc2MTIzNzQxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac752339a244d41fc0c4ff5911354313ad24e2c3ebf1ebe343f7a8dfd5d29d3ba6
hovercard-subject-tagpull_request:650734707
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/2358/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altThis change leverages the normalized query structure to collect the merged subfields instead of calling collectFields on demand. This aims to improve the performance for especially large and deep q...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/2358/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2358%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F2358%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/2358/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/2358/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/2358/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
nf-based-executionhttps://github.com/graphql-java/graphql-java/tree/nf-based-execution
Conversation 13 https://github.com/graphql-java/graphql-java/pull/2358
Commits 2 https://github.com/graphql-java/graphql-java/pull/2358/commits
Checks 0 https://github.com/graphql-java/graphql-java/pull/2358/checks
Files changed https://github.com/graphql-java/graphql-java/pull/2358/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2358/files
Experimental: use Normalized fields instead of lazy collect field https://github.com/graphql-java/graphql-java/pull/2358/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/2358/files
1872182 leverage NF to collection fields andimarek May 23, 2021 https://github.com/graphql-java/graphql-java/pull/2358/commits/18721823b4ec1557add87d3963e612fa6fb9e058
264fec3 skip one test andimarek May 23, 2021 https://github.com/graphql-java/graphql-java/pull/2358/commits/264fec34a3999a23b356d6d3298fa56074921102
Clear filters https://github.com/graphql-java/graphql-java/pull/2358/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2358/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2358/files
ExecutionStrategy.java https://github.com/graphql-java/graphql-java/pull/2358/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
ExecutionStrategyTest.groovy https://github.com/graphql-java/graphql-java/pull/2358/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
src/main/java/graphql/execution/ExecutionStrategy.javahttps://github.com/graphql-java/graphql-java/pull/2358/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
View file https://github.com/graphql-java/graphql-java/blob/264fec34a3999a23b356d6d3298fa56074921102/src/main/java/graphql/execution/ExecutionStrategy.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/2358/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
bbakermanhttps://github.com/bbakerman
Jun 15, 2021https://github.com/graphql-java/graphql-java/pull/2358/files#r651442725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/2358/files
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
src/test/groovy/graphql/execution/ExecutionStrategyTest.groovyhttps://github.com/graphql-java/graphql-java/pull/2358/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
View file https://github.com/graphql-java/graphql-java/blob/264fec34a3999a23b356d6d3298fa56074921102/src/test/groovy/graphql/execution/ExecutionStrategyTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/2358/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
https://github.com/graphql-java/graphql-java/pull/2358/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.