René's URL Explorer Experiment


Title: `LightDataFetcher` implementation not getting executed as intended · Issue #3650 · graphql-java/graphql-java · GitHub

Open Graph Title: `LightDataFetcher` implementation not getting executed as intended · Issue #3650 · graphql-java/graphql-java

X Title: `LightDataFetcher` implementation not getting executed as intended · Issue #3650 · graphql-java/graphql-java

Description: Describe the bug This condition in ExecutionStrategy:invokeDataFetcher(): if (dataFetcher instanceof LightDataFetcher) { is evaluating to False even if the dataFetcher is actually created by implementing LightDataFetcher interface. I hav...

Open Graph Description: Describe the bug This condition in ExecutionStrategy:invokeDataFetcher(): if (dataFetcher instanceof LightDataFetcher) { is evaluating to False even if the dataFetcher is actually created by implem...

X Description: Describe the bug This condition in ExecutionStrategy:invokeDataFetcher(): if (dataFetcher instanceof LightDataFetcher) { is evaluating to False even if the dataFetcher is actually created by implem...

Opengraph URL: https://github.com/graphql-java/graphql-java/issues/3650

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`LightDataFetcher` implementation not getting executed as intended","articleBody":"**Describe the bug**\r\nThis condition in [`ExecutionStrategy:invokeDataFetcher()`](https://github.com/graphql-java/graphql-java/blob/99ec59623c87f62fc24ac780b6fc47fad39017e9/src/main/java/graphql/execution/ExecutionStrategy.java#L530): \r\n```java\r\nif (dataFetcher instanceof LightDataFetcher) {\r\n```\r\n is evaluating to `False` even if the `dataFetcher` is actually created by implementing `LightDataFetcher` interface.\r\n\r\nI have tried to debug why it is so, and I found this object being passed as datafetcher to the `invokeDataFetcher` function which is being evaluated as not a `LightDataFetcher`:\r\n![image](https://github.com/graphql-java/graphql-java/assets/78898665/5c947d7d-3b2e-4e57-8ccd-3313044bec9b)\r\n\r\n**Context**\r\nI am creating a `LightOperationExecutor` as a lightweight alternative to `OperationExecutor` in [GraphQL-SPQR](https://github.com/leangen/graphql-spqr/) by implementing `LightDataFetcher`. Open PR [#502](https://github.com/leangen/graphql-spqr/pull/502)\r\n\r\n**To Reproduce**\r\nTo reproduce, checkout commit [05642488bc](https://github.com/leangen/graphql-spqr/pull/502/commits/05642488bc8809073dfba239b5189106998f5473) and run `test` in Maven. You should see the tests `SchemaTest.testSchema` and `RelayTest.testRelayMutations` produce errors. \r\n\r\nNote that even though the commit uses GraphQL-Java `21.3`, this is also reproducible on `22.1` (latest), however in this situation we have this datafetcher object, \r\n\u003cimg width=\"623\" alt=\"image\" src=\"https://github.com/graphql-java/graphql-java/assets/78898665/ad0a8e04-49a3-4c93-bba9-6725c4a4ec19\">\r\n\r\n","author":{"url":"https://github.com/shalearkane","@type":"Person","name":"shalearkane"},"datePublished":"2024-06-28T09:34:51Z","url":"https://github.com/graphql-java/graphql-java/issues/3650"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:160a52b9-691b-3da1-fa3e-46e4609026c9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA9C4:34CAB:200D929:28EB596:6B017652
html-safe-nonce455a17bbf19b2fcb78ede12d14d390df16045fa8fb7d919f00acf953e6708f88
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUM0OjM0Q0FCOjIwMEQ5Mjk6MjhFQjU5Njo2QjAxNzY1MiIsInZpc2l0b3JfaWQiOiI1ODc4MDYwMjExMjM0NzY0MzcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfb37640200dedd181e1715b8fbea774988636877de0b352739d7c15f28d80b49
hovercard-subject-tagissue:2380009458
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-java/graphql-java/3650/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e4666adb581530f520ea7e1910d2b7c947a911a2cf685e180f62e9fab4df80b4/graphql-java/graphql-java/issues/3650
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e4666adb581530f520ea7e1910d2b7c947a911a2cf685e180f62e9fab4df80b4/graphql-java/graphql-java/issues/3650
og:image:altDescribe the bug This condition in ExecutionStrategy:invokeDataFetcher(): if (dataFetcher instanceof LightDataFetcher) { is evaluating to False even if the dataFetcher is actually created by implem...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshalearkane
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/issues/3650#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fissues%2F3650
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fissues%2F3650
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/issues/3650
Reloadhttps://github.com/graphql-java/graphql-java/issues/3650
Reloadhttps://github.com/graphql-java/graphql-java/issues/3650
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
https://github.com/graphql-java/graphql-java
New issuehttps://github.com/login?return_to=https://github.com/graphql-java/graphql-java/issues/3650
New issuehttps://github.com/login?return_to=https://github.com/graphql-java/graphql-java/issues/3650
LightDataFetcher implementation not getting executed as intendedhttps://github.com/graphql-java/graphql-java/issues/3650#top
keep-openTells Stale Bot to keep PRs and issues openhttps://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3A%22keep-open%22
https://github.com/shalearkane
shalearkanehttps://github.com/shalearkane
on Jun 28, 2024https://github.com/graphql-java/graphql-java/issues/3650#issue-2380009458
ExecutionStrategy:invokeDataFetcher()https://github.com/graphql-java/graphql-java/blob/99ec59623c87f62fc24ac780b6fc47fad39017e9/src/main/java/graphql/execution/ExecutionStrategy.java#L530
https://private-user-images.githubusercontent.com/78898665/344109486-5c947d7d-3b2e-4e57-8ccd-3313044bec9b.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyNTgyMzksIm5iZiI6MTc5NTI1NzkzOSwicGF0aCI6Ii83ODg5ODY2NS8zNDQxMDk0ODYtNWM5NDdkN2QtM2IyZS00ZTU3LThjY2QtMzMxMzA0NGJlYzliLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIxVDEwNDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFkNzY3NjNkY2EzZWJmYWEzMjNmNWRiZGUyZTU0NjQ1MDZiOWIyOGVkMmU4NmE4YWQwYmQzMzUwZDAxMDkzZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.sJPZKsCs2WrEIYT7XgDvlMcvBw7DTKOSB_Lb70VqY9g
GraphQL-SPQRhttps://github.com/leangen/graphql-spqr/
#502https://github.com/leangen/graphql-spqr/pull/502
05642488bchttps://github.com/leangen/graphql-spqr/pull/502/commits/05642488bc8809073dfba239b5189106998f5473
https://private-user-images.githubusercontent.com/78898665/344124633-ad0a8e04-49a3-4c93-bba9-6725c4a4ec19.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUyNTgyMzksIm5iZiI6MTc5NTI1NzkzOSwicGF0aCI6Ii83ODg5ODY2NS8zNDQxMjQ2MzMtYWQwYThlMDQtNDlhMy00YzkzLWJiYTktNjcyNWM0YTRlYzE5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIxVDEwNDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdiM2Q4OTYxZmFjOTFjYmU3MmMyMjI3YWQ3Yjg1ZWViMTc3M2Q1YjkwYzc5NTE3ZWJjZjZjNDQxNDcwMWM4OGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.3-PTpaM8gDMYwckq9CiM2Y9LepbXTP8fg8m-p_fZ2u4
https://github.com/shalearkane
shalearkanehttps://github.com/shalearkane
on Jun 28, 2024https://github.com/graphql-java/graphql-java/issues/3650#issuecomment-2196569308
dondonzhttps://github.com/dondonz
keep-openTells Stale Bot to keep PRs and issues openhttps://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3A%22keep-open%22
on Jul 16, 2024https://github.com/graphql-java/graphql-java/issues/3650#event-13527905498
Sign up for freehttps://github.com/signup?return_to=https://github.com/graphql-java/graphql-java/issues/3650
Sign in to commenthttps://github.com/login?return_to=https://github.com/graphql-java/graphql-java/issues/3650
keep-openTells Stale Bot to keep PRs and issues openhttps://github.com/graphql-java/graphql-java/issues?q=state%3Aopen%20label%3A%22keep-open%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.