René's URL Explorer Experiment


Title: SchemaDiff reports incorrect breakage count · Issue #2877 · graphql-java/graphql-java · GitHub

Open Graph Title: SchemaDiff reports incorrect breakage count · Issue #2877 · graphql-java/graphql-java

X Title: SchemaDiff reports incorrect breakage count · Issue #2877 · graphql-java/graphql-java

Description: Describe the bug The SchemaDiff$CountingReporter reports a different breakingCount compared to the CapturingReporter.getBreakageCount(). I'm fairly certain its breakingCount field should be initialised with 0: https://github.com/graphql-...

Open Graph Description: Describe the bug The SchemaDiff$CountingReporter reports a different breakingCount compared to the CapturingReporter.getBreakageCount(). I'm fairly certain its breakingCount field should be initial...

X Description: Describe the bug The SchemaDiff$CountingReporter reports a different breakingCount compared to the CapturingReporter.getBreakageCount(). I'm fairly certain its breakingCount field should be ini...

Opengraph URL: https://github.com/graphql-java/graphql-java/issues/2877

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SchemaDiff reports incorrect breakage count","articleBody":"**Describe the bug**\r\nThe `SchemaDiff$CountingReporter` reports a different `breakingCount` compared to the `CapturingReporter.getBreakageCount()`.\r\nI'm fairly certain its `breakingCount` field should be initialised with 0: https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/diff/SchemaDiff.java#L73\r\n\r\n**To Reproduce**\r\nGiven the following code:\r\n```java\r\nvar capturingReporter = new CapturingReporter();\r\nvar schemaDiff = new SchemaDiff();\r\nvar schema = \u003csome GraphQLSchema\u003e;\r\n\r\nint breakingCount = schemaDiff.diffSchema(DiffSet.diffSet(schema, schema), capturingReporter);\r\n\r\nSystem.out.println(breakingCount + \" != \" + capturingReporter.getBreakageCount());\r\n```\r\nthis will print `1 != 0`\r\n\r\nThis also means that if you use the return value of the `schemaDiff` method to assert no breaking changes with `breakingCount == 0`, this will always fail.","author":{"url":"https://github.com/NielsDoucet","@type":"Person","name":"NielsDoucet"},"datePublished":"2022-07-01T11:57:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/2877/graphql-java/issues/2877"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:558f384b-8606-1282-4fb0-47a1bd5cbe4c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA1D4:DC15B:2EB9AC:408854:6A602898
html-safe-noncef356fe2536345d896001c3cb1c8ad0d4ce3808eb4a07bb19dde14a1f636dc7f9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUQ0OkRDMTVCOjJFQjlBQzo0MDg4NTQ6NkE2MDI4OTgiLCJ2aXNpdG9yX2lkIjoiMjEyNTUzODY1OTI5Njk3NDMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac633c428eb2f3d7036837c6edf25f632b3e1f6b6c0c2219784ded0a542ee508ce
hovercard-subject-tagissue:1291313006
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-java/graphql-java/2877/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bbe66af735bc8ccbe05f907eb73ac38e04fda8c388fcc91938709fb0e3455802/graphql-java/graphql-java/issues/2877
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bbe66af735bc8ccbe05f907eb73ac38e04fda8c388fcc91938709fb0e3455802/graphql-java/graphql-java/issues/2877
og:image:altDescribe the bug The SchemaDiff$CountingReporter reports a different breakingCount compared to the CapturingReporter.getBreakageCount(). I'm fairly certain its breakingCount field should be initial...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNielsDoucet
hostnamegithub.com
expected-hostnamegithub.com
None60da8c2a42fa2bbf5f7567474990ec467836a84444262a58e200fa91b7f3d2d0
turbo-cache-controlno-preview
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9824515e740d83d5eb82168a089b806ab0fe04a1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/issues/2877#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fissues%2F2877
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fissues%2F2877
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/issues/2877
Reloadhttps://github.com/graphql-java/graphql-java/issues/2877
Reloadhttps://github.com/graphql-java/graphql-java/issues/2877
Please reload this pagehttps://github.com/graphql-java/graphql-java/issues/2877
graphql-java https://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Fork 1.1k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Star 6.2k https://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java
Code https://github.com/graphql-java/graphql-java
Issues 26 https://github.com/graphql-java/graphql-java/issues
Pull requests 11 https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality 0 https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
Code https://github.com/graphql-java/graphql-java
Issues https://github.com/graphql-java/graphql-java/issues
Pull requests https://github.com/graphql-java/graphql-java/pulls
Discussions https://github.com/graphql-java/graphql-java/discussions
Actions https://github.com/graphql-java/graphql-java/actions
Projects https://github.com/graphql-java/graphql-java/projects
Wiki https://github.com/graphql-java/graphql-java/wiki
Security and quality https://github.com/graphql-java/graphql-java/security
Insights https://github.com/graphql-java/graphql-java/pulse
SchemaDiff reports incorrect breakage counthttps://github.com/graphql-java/graphql-java/issues/2877#top
20.0https://github.com/graphql-java/graphql-java/milestone/44
https://github.com/NielsDoucet
NielsDoucethttps://github.com/NielsDoucet
on Jul 1, 2022https://github.com/graphql-java/graphql-java/issues/2877#issue-1291313006
https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/diff/SchemaDiff.java#L73https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/schema/diff/SchemaDiff.java#L73
20.0https://github.com/graphql-java/graphql-java/milestone/44
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.