René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"regression in GraphQLScalarType Coercing parseValue in 18.1","articleBody":"**Describe the bug**\r\n\r\nI just hit a bug in production when deploying an upgrade from 18.0 to 18.1 that I think relates to some of the work in resolving https://github.com/graphql-java/graphql-java/issues/2811\r\n\r\nI noticed the following in my production logs \r\n\r\n```\r\n...\r\nCaused by: graphql.schema.CoercingParseValueException: Variable 'memberDues' has an invalid value: Failed to parse input value 2022-05-16T19:52:37Z as ZonedDateTime\r\n...\r\n\r\nCaused by: java.lang.IllegalArgumentException: Unexpected input type: class java.time.ZonedDateTimeat com.meetup.graphql.wiring.CustomScalars.parseDateTimeValue(CustomScalars.java:38)at com.meetup.graphql.wiring.CustomScalars$1.parseValue(CustomScalars.java:71)at com.meetup.graphql.wiring.CustomScalars$1.parseValue(CustomScalars.java:63)at graphql.execution.ValuesResolver.externalValueToInternalValueForScalar(ValuesResolver.java:578)at graphql.execution.ValuesResolver.externalValueToInternalValue(ValuesResolver.java:510)at graphql.execution.ValuesResolver.externalValueToInternalValue(ValuesResolver.java:498)at graphql.execution.ValuesResolver.externalValueToInternalValueForObject(ValuesResolver.java:565)at graphql.execution.ValuesResolver.externalValueToInternalValue(ValuesResolver.java:517)at graphql.execution.ValuesResolver.externalValueToInternalValueForObject(ValuesResolver.java:565)at graphql.execution.ValuesResolver.externalValueToInternalValue(ValuesResolver.java:517)at graphql.execution.ValuesResolver.externalValueToInternalValue(ValuesResolver.java:498)at graphql.execution.ValuesResolver.externalValueToInternalValueForVariables(ValuesResolver.java:410)\r\n```\r\n\r\nnote that the string `2022-05-16T19:52:37Z` is actually parsable as ZonedDateTime however I believe the issue is previously `parseValue` was receiving either a String or a StringValue and after this upgrade it started receiving the value that I was attempting to coerce it into, in this case a ZonedDateTime\r\n\r\nis this new expected behavior or was this previous expected behavior that was underspecified until now?\r\n\r\nHere's an abbreviated version of a custom scaler for parsing out ZonedDateTime values which is roughly based on the [docs](https://www.graphql-java.com/documentation/scalars/#example-implementation)\r\n\r\n```java\r\n  static ZonedDateTime parseDateTimeValue(Object input) {\r\n    try {\r\n      if (input instanceof StringValue) {\r\n        return ZonedDateTime.parse(((StringValue) input).getValue());\r\n      } else if (input instanceof String) {\r\n        return ZonedDateTime.parse((String) input);\r\n      } else throw new IllegalArgumentException(\"Unexpected input type: \" + input.getClass()); \u003c-- change in behavior causes this line to get evaluated\r\n    } catch (Exception e) {\r\n      throw new CoercingParseValueException(\r\n          \"Failed to parse input value \" + input + \" as ZonedDateTime\", e);\r\n    }\r\n  }\r\n  \r\npublic static final GraphQLScalarType DateTime =\r\n      GraphQLScalarType.newScalar()\r\n          .name(\"DateTime\")\r\n          .description(\"A custom scalar that handles timestamps\")\r\n          .coercing(\r\n              new Coercing\u003cZonedDateTime, String\u003e() {\r\n                @Override\r\n                public String serialize(Object dataFetcherResult) {\r\n                  return // doesnt matter\r\n                }\r\n\r\n                @Override\r\n                public ZonedDateTime parseValue(Object input) {\r\n                  return parseDateTimeValue(input);\r\n                }\r\n\r\n                @Override\r\n                public ZonedDateTime parseLiteral(Object input) {\r\n                  return // doesnt matter\r\n                }\r\n              })\r\n          .build();\r\n```\r\n\r\n**To Reproduce**\r\nPlease provide a code example or even better a test to reproduce the bug.\r\n\r\nsee above\r\n","author":{"url":"https://github.com/softprops","@type":"Person","name":"softprops"},"datePublished":"2022-05-16T20:35:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/2819/graphql-java/issues/2819"}