René's URL Explorer Experiment


Title: Apollo Persisted Query Support & the Apollo reference implementation · Issue #2395 · graphql-java/graphql-java · GitHub

Open Graph Title: Apollo Persisted Query Support & the Apollo reference implementation · Issue #2395 · graphql-java/graphql-java

X Title: Apollo Persisted Query Support & the Apollo reference implementation · Issue #2395 · graphql-java/graphql-java

Description: There's an issue at over at the DGS framework: Netflix/dgs-framework#50 for adding support for the PreparsedDocumentProvider. I'd like to take this a bit further and add a module for supporting Apollo Persisted Queries with spring observ...

Open Graph Description: There's an issue at over at the DGS framework: Netflix/dgs-framework#50 for adding support for the PreparsedDocumentProvider. I'd like to take this a bit further and add a module for supporting Apo...

X Description: There's an issue at over at the DGS framework: Netflix/dgs-framework#50 for adding support for the PreparsedDocumentProvider. I'd like to take this a bit further and add a module for suppor...

Opengraph URL: https://github.com/graphql-java/graphql-java/issues/2395

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Apollo Persisted Query Support & the Apollo reference implementation ","articleBody":"There's an issue at over at the DGS framework: https://github.com/Netflix/dgs-framework/issues/50 for adding support for the `PreparsedDocumentProvider`. I'd like to take this a bit further and add a module for supporting Apollo Persisted Queries with spring observability in the DGS framework.\r\n\r\nI found a few notable details while experimenting with this in the DGS framework and thought I should raise them here.\r\n\r\n#### Apollo Persisted Query support should validate the query hash\r\nThe Apollo implementation(and the in-house implementation at NYT) check that the incoming query hash matches the SHA-256 checksum of the query. Ofc this only happens for query register operations, i.e. when both a hash and query are present.\r\n```json\r\n       {\r\n        \"query\": \"{__typename}\",\r\n        \"extensions\":{\r\n         \"persistedQuery\":{\r\n          \"version\":1,\r\n          \"sha256Hash\":\"fcf31818e50ac3e818ca4bdbc433d6ab73176f0b9d5f9d5ad17e200cdab6fba4\"\r\n        }\r\n      }\r\n    }\r\n```\r\nIf the computed checksum and provided SHA don't match, an error should be thrown indicating so. [ApolloPersistedQuerySupport](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/execution/preparsed/persisted/ApolloPersistedQuerySupport.java) does not do this.\r\n\r\nPerhaps this should be a config option to avoid a breaking change? Or also to allow people to choose if they want this.\r\nHere's an example from my experiments last week.\r\n```json\r\n{\r\n  \"errors\": [\r\n    {\r\n      \"message\": \"provided SHA does not match query\",\r\n      \"locations\": [],\r\n      \"extensions\": {\r\n        \"classification\": \"BAD_REQUEST\"\r\n      }\r\n    }\r\n  ]\r\n}\r\n```\r\n#### Nice to have: Throw Persisted Query not supported error\r\nIf a client passes APQ to a GraphQL that does not support it, it'd be nice to be able to configure the GraphQL service to throw an error, e.g. [requestPipeline.ts#L164](https://github.com/apollographql/apollo-server/blob/0aa0e4b20ef97576ce92733698a7842b61d8280e/packages/apollo-server-core/src/requestPipeline.ts#L164).\r\nI'm not sure where I'd put this.\r\n\r\n#### InMemoryPersistedQueryCache that registers incoming queries (less important so likely will drop)\r\nThe example [InMemoryPersistedQueryCache.java](https://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/execution/preparsed/persisted/InMemoryPersistedQueryCache.java#L16) doesn't have a way to push queries into the cache from the request. Would we be open to modify or add a new base impl that does register queries when both a query and hash are present?\r\n\r\nThat's all. I would really appreciate some feedback, yays or nays. Thank You, have a great day!","author":{"url":"https://github.com/jregistr","@type":"Person","name":"jregistr"},"datePublished":"2021-06-22T17:59:22Z","url":"https://github.com/graphql-java/graphql-java/issues/2395"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:96bc5c75-a521-d046-15fd-3e2212127cc5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC3E2:134693:2D807:3C09E:6B017C5A
html-safe-nonce63c601e34cc87d10cbd7782404174ea1b0cc74da58afcc54386cd95e05527184
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0UyOjEzNDY5MzoyRDgwNzozQzA5RTo2QjAxN0M1QSIsInZpc2l0b3JfaWQiOiI5MjIxMTI1MTQ3OTgzOTY5MzcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3ccd1eeb24ad532bf578b589c7fa6a81bcc6249c50242f834c46cd4de94681f6
hovercard-subject-tagissue:927497121
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-java/graphql-java/2395/issue_layout
twitter:imagehttps://opengraph.githubassets.com/894e8abd1f6b8db4bf3d0be38f39ce0749411db1178b0e5041d384e4aa7da8ae/graphql-java/graphql-java/issues/2395
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/894e8abd1f6b8db4bf3d0be38f39ce0749411db1178b0e5041d384e4aa7da8ae/graphql-java/graphql-java/issues/2395
og:image:altThere's an issue at over at the DGS framework: Netflix/dgs-framework#50 for adding support for the PreparsedDocumentProvider. I'd like to take this a bit further and add a module for supporting Apo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejregistr
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/issues/2395#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fissues%2F2395
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fissues%2F2395
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/issues/2395
Reloadhttps://github.com/graphql-java/graphql-java/issues/2395
Reloadhttps://github.com/graphql-java/graphql-java/issues/2395
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
https://github.com/graphql-java/graphql-java
New issuehttps://github.com/login?return_to=https://github.com/graphql-java/graphql-java/issues/2395
New issuehttps://github.com/login?return_to=https://github.com/graphql-java/graphql-java/issues/2395
Apollo Persisted Query Support & the Apollo reference implementation https://github.com/graphql-java/graphql-java/issues/2395#top
17.0https://github.com/graphql-java/graphql-java/milestone/31
https://github.com/jregistr
jregistrhttps://github.com/jregistr
on Jun 22, 2021https://github.com/graphql-java/graphql-java/issues/2395#issue-927497121
Netflix/dgs-framework#50https://github.com/Netflix/dgs-framework/issues/50
ApolloPersistedQuerySupporthttps://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/execution/preparsed/persisted/ApolloPersistedQuerySupport.java
requestPipeline.ts#L164https://github.com/apollographql/apollo-server/blob/0aa0e4b20ef97576ce92733698a7842b61d8280e/packages/apollo-server-core/src/requestPipeline.ts#L164
InMemoryPersistedQueryCache.javahttps://github.com/graphql-java/graphql-java/blob/master/src/main/java/graphql/execution/preparsed/persisted/InMemoryPersistedQueryCache.java#L16
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
on Jun 24, 2021https://github.com/graphql-java/graphql-java/issues/2395#issuecomment-867498061
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
on Jun 24, 2021https://github.com/graphql-java/graphql-java/issues/2395#issuecomment-867511605
https://github.com/jregistr
jregistrhttps://github.com/jregistr
on Jun 28, 2021https://github.com/graphql-java/graphql-java/issues/2395#issuecomment-869931481
async-graphqlhttps://github.com/async-graphql/async-graphql/blob/master/src/extensions/apollo_persisted_queries.rs
bbakermanhttps://github.com/bbakerman
17.0https://github.com/graphql-java/graphql-java/milestone/31
on Jul 6, 2021https://github.com/graphql-java/graphql-java/issues/2395#event-4982691133
bbakermanhttps://github.com/bbakerman
completedhttps://github.com/graphql-java/graphql-java/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 6, 2021https://github.com/graphql-java/graphql-java/issues/2395#event-4982691398
Sign up for freehttps://github.com/signup?return_to=https://github.com/graphql-java/graphql-java/issues/2395
Sign in to commenthttps://github.com/login?return_to=https://github.com/graphql-java/graphql-java/issues/2395
17.0https://github.com/graphql-java/graphql-java/milestone/31
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.