René's URL Explorer Experiment


Title: fix: revise and rename is_etag_in_json(data) by cojenco · Pull Request #483 · googleapis/python-storage · GitHub

Open Graph Title: fix: revise and rename is_etag_in_json(data) by cojenco · Pull Request #483 · googleapis/python-storage

X Title: fix: revise and rename is_etag_in_json(data) by cojenco · Pull Request #483 · googleapis/python-storage

Description: This library has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-storage - fix: revise and rename is_etag_in_json(data) by cojenco · Pull Request #483 · googleapis/python-storage

Open Graph Description: This PR revises and renames retry.is_etag_in_json(data) to ensure that eTags are correctly captured and validated from the request body. Rename conditional retry predicate retry.is_etag_in_json(da...

X Description: This PR revises and renames retry.is_etag_in_json(data) to ensure that eTags are correctly captured and validated from the request body. Rename conditional retry predicate retry.is_etag_in_json(da...

Opengraph URL: https://github.com/googleapis/python-storage/pull/483

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8f3272e0-fb55-6109-e844-d41766eeb6fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA12:90996:37D0845:5017492:6A4FD943
html-safe-noncec985d6115a40cf016a3f7a01cb9d13bd6cc967c4823f46cb57d0572a285babd8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTEyOjkwOTk2OjM3RDA4NDU6NTAxNzQ5Mjo2QTRGRDk0MyIsInZpc2l0b3JfaWQiOiI2ODY2OTM4OTUzMjQyNDk5Mzk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5aa8eec025b075ebe0741ad0a8a7bf8d2f113c028edcb5cd957ae06e7717dbdd
hovercard-subject-tagpull_request:679327337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-storage/483/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d901964b6ba35bb09b05417c4c3354e02486278a90739545717c98cdeee5e018/googleapis/python-storage/pull/483
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d901964b6ba35bb09b05417c4c3354e02486278a90739545717c98cdeee5e018/googleapis/python-storage/pull/483
og:image:altThis PR revises and renames retry.is_etag_in_json(data) to ensure that eTags are correctly captured and validated from the request body. Rename conditional retry predicate retry.is_etag_in_json(da...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecojenco
hostnamegithub.com
expected-hostnamegithub.com
None19b98c3d9767bb8a56238a89ff8401d1cbdf3bc5c353799aacf49fe6c76b4b7c
turbo-cache-controlno-cache
go-importgithub.com/googleapis/python-storage git https://github.com/googleapis/python-storage.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992639
octolytics-dimension-repository_nwogoogleapis/python-storage
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992639
octolytics-dimension-repository_network_root_nwogoogleapis/python-storage
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release142593e66413bbae27fd485859993597d5a3b104
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-storage/pull/483#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-storage%2Fpull%2F483
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-storage%2Fpull%2F483
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-storage
Reloadhttps://github.com/googleapis/python-storage/pull/483
Reloadhttps://github.com/googleapis/python-storage/pull/483
Reloadhttps://github.com/googleapis/python-storage/pull/483
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
googleapis https://github.com/googleapis
python-storagehttps://github.com/googleapis/python-storage
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-storage
Fork 172 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-storage
Star 502 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-storage
Code https://github.com/googleapis/python-storage
Issues 0 https://github.com/googleapis/python-storage/issues
Pull requests 0 https://github.com/googleapis/python-storage/pulls
Actions https://github.com/googleapis/python-storage/actions
Projects https://github.com/googleapis/python-storage/projects
Security and quality 0 https://github.com/googleapis/python-storage/security
Insights https://github.com/googleapis/python-storage/pulse
Code https://github.com/googleapis/python-storage
Issues https://github.com/googleapis/python-storage/issues
Pull requests https://github.com/googleapis/python-storage/pulls
Actions https://github.com/googleapis/python-storage/actions
Projects https://github.com/googleapis/python-storage/projects
Security and quality https://github.com/googleapis/python-storage/security
Insights https://github.com/googleapis/python-storage/pulse
cojencohttps://github.com/cojenco
masterhttps://github.com/googleapis/python-storage/tree/master
etag_in_jsonhttps://github.com/googleapis/python-storage/tree/etag_in_json
Conversationhttps://github.com/googleapis/python-storage/pull/483
Commits10 (10)https://github.com/googleapis/python-storage/pull/483/commits
Checkshttps://github.com/googleapis/python-storage/pull/483/checks
Files changedhttps://github.com/googleapis/python-storage/pull/483/files
fix: revise and rename is_etag_in_json(data)https://github.com/googleapis/python-storage/pull/483#top
cojencohttps://github.com/cojenco
masterhttps://github.com/googleapis/python-storage/tree/master
etag_in_jsonhttps://github.com/googleapis/python-storage/tree/etag_in_json
https://github.com/cojenco
cojencohttps://github.com/cojenco
Jun 28, 2021https://github.com/googleapis/python-storage/pull/483#issue-931905417
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
#481https://github.com/googleapis/python-storage/issues/481
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
https://github.com/cojenco
fix: handle cases where data is a dict in is_etag_in_json(data)https://github.com/googleapis/python-storage/pull/483/commits/d78e84d519c4303d41fd6b4bc9529f06c831414c
d78e84dhttps://github.com/googleapis/python-storage/pull/483/commits/d78e84d519c4303d41fd6b4bc9529f06c831414c
https://github.com/cojenco
cojencohttps://github.com/cojenco
June 28, 2021 19:32https://github.com/googleapis/python-storage/pull/483#event-4949420223
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
api: storage https://github.com/googleapis/python-storage/issues?q=state%3Aopen%20label%3A%22api%3A%20storage%22
Jun 28, 2021https://github.com/googleapis/python-storage/pull/483#event-4949420668
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/googleapis/python-storage/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jun 28, 2021https://github.com/googleapis/python-storage/pull/483#event-4949420763
https://github.com/cojenco
Merge branch 'master' into etag_in_jsonhttps://github.com/googleapis/python-storage/pull/483/commits/c1d66974af01ffd2b7e98a68ab7e90105d8548c7
c1d6697https://github.com/googleapis/python-storage/pull/483/commits/c1d66974af01ffd2b7e98a68ab7e90105d8548c7
https://github.com/tritone
tritonehttps://github.com/tritone
Jun 29, 2021 https://github.com/googleapis/python-storage/pull/483#pullrequestreview-694550047
View reviewed changes https://github.com/googleapis/python-storage/pull/483/files/c1d66974af01ffd2b7e98a68ab7e90105d8548c7
google/cloud/storage/retry.pyhttps://github.com/googleapis/python-storage/pull/483/files/c1d66974af01ffd2b7e98a68ab7e90105d8548c7#diff-f9eb8511de988a891d15a7c55caacc4cee86d537bfe97f556198a9385e5e81a9
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
cojencohttps://github.com/cojenco
July 2, 2021 17:19https://github.com/googleapis/python-storage/pull/483#commits-pushed-3a1186d
https://github.com/cojenco
Merge branch 'master' into etag_in_jsonhttps://github.com/googleapis/python-storage/pull/483/commits/3a1186dc62300cb94f62d8a51234f273ff2f400e
3a1186dhttps://github.com/googleapis/python-storage/pull/483/commits/3a1186dc62300cb94f62d8a51234f273ff2f400e
https://github.com/cojenco
address comments and accept proposed changeshttps://github.com/googleapis/python-storage/pull/483/commits/73a9802948693a935704c0c08bae11faffed0810
73a9802https://github.com/googleapis/python-storage/pull/483/commits/73a9802948693a935704c0c08bae11faffed0810
https://github.com/cojenco
Merge branch 'master' into etag_in_jsonhttps://github.com/googleapis/python-storage/pull/483/commits/1e59dbe3196e674fab7b2251a062e9d8f61d25e6
1e59dbehttps://github.com/googleapis/python-storage/pull/483/commits/1e59dbe3196e674fab7b2251a062e9d8f61d25e6
https://github.com/cojenco
revise is_etag_in_json to check dict datahttps://github.com/googleapis/python-storage/pull/483/commits/6e665ef4cb7a82aa6011913335634eac8288d448
6e665efhttps://github.com/googleapis/python-storage/pull/483/commits/6e665ef4cb7a82aa6011913335634eac8288d448
https://github.com/cojenco
cojencohttps://github.com/cojenco
tseaverhttps://github.com/tseaver
July 9, 2021 16:54https://github.com/googleapis/python-storage/pull/483#event-5001375234
https://github.com/cojenco
Merge branch 'master' into etag_in_jsonhttps://github.com/googleapis/python-storage/pull/483/commits/7f35d1af67615281e58f0a2f258d81f641d29611
7f35d1ahttps://github.com/googleapis/python-storage/pull/483/commits/7f35d1af67615281e58f0a2f258d81f641d29611
https://github.com/tritone
tritonehttps://github.com/tritone
Jul 9, 2021 https://github.com/googleapis/python-storage/pull/483#pullrequestreview-703284808
View reviewed changes https://github.com/googleapis/python-storage/pull/483/files/7f35d1af67615281e58f0a2f258d81f641d29611
tritonehttps://github.com/tritone
https://github.com/googleapis/python-storage/pull/483#pullrequestreview-703284808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
google/cloud/storage/retry.pyhttps://github.com/googleapis/python-storage/pull/483/files/7f35d1af67615281e58f0a2f258d81f641d29611#diff-f9eb8511de988a891d15a7c55caacc4cee86d537bfe97f556198a9385e5e81a9
tritonehttps://github.com/tritone
Jul 9, 2021https://github.com/googleapis/python-storage/pull/483#discussion_r667126477
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
tseaverhttps://github.com/tseaver
Jul 9, 2021https://github.com/googleapis/python-storage/pull/483#discussion_r667141569
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
cojencohttps://github.com/cojenco
Jul 9, 2021https://github.com/googleapis/python-storage/pull/483#discussion_r667157334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
tseaverhttps://github.com/tseaver
Jul 9, 2021https://github.com/googleapis/python-storage/pull/483#discussion_r667178401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
https://github.com/cojenco
revise docstring wordinghttps://github.com/googleapis/python-storage/pull/483/commits/da23d1325ba272f3dee4b18d714c07f635e5caf0
da23d13https://github.com/googleapis/python-storage/pull/483/commits/da23d1325ba272f3dee4b18d714c07f635e5caf0
https://github.com/tseaver
tseaverhttps://github.com/tseaver
Jul 9, 2021 https://github.com/googleapis/python-storage/pull/483#pullrequestreview-703303266
View reviewed changes https://github.com/googleapis/python-storage/pull/483/files/da23d1325ba272f3dee4b18d714c07f635e5caf0
google/cloud/storage/retry.pyhttps://github.com/googleapis/python-storage/pull/483/files/7f35d1af67615281e58f0a2f258d81f641d29611..da23d1325ba272f3dee4b18d714c07f635e5caf0#diff-f9eb8511de988a891d15a7c55caacc4cee86d537bfe97f556198a9385e5e81a9
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
https://github.com/cojenco
revise docstringshttps://github.com/googleapis/python-storage/pull/483/commits/ba3c16abd5a91e2d42d3e53b198ef03c547f6e46
ba3c16ahttps://github.com/googleapis/python-storage/pull/483/commits/ba3c16abd5a91e2d42d3e53b198ef03c547f6e46
https://github.com/tritone
tritonehttps://github.com/tritone
Jul 9, 2021 https://github.com/googleapis/python-storage/pull/483#pullrequestreview-703363889
View reviewed changes https://github.com/googleapis/python-storage/pull/483/files/ba3c16abd5a91e2d42d3e53b198ef03c547f6e46
https://github.com/cojenco
rename conditional predicate to is_etag_in_datahttps://github.com/googleapis/python-storage/pull/483/commits/af0abb3df3c9ae0d879e25188caa810ff8590187
af0abb3https://github.com/googleapis/python-storage/pull/483/commits/af0abb3df3c9ae0d879e25188caa810ff8590187
https://github.com/cojenco
cojencohttps://github.com/cojenco
Jul 9, 2021https://github.com/googleapis/python-storage/pull/483#event-5002436699
https://github.com/cojenco
cojencohttps://github.com/cojenco
0a52546https://github.com/googleapis/python-storage/commit/0a5254647bf1155874fe48f3891bcc34a76b0b81
Jul 9, 2021https://github.com/googleapis/python-storage/pull/483#event-5002439600
https://github.com/cojenco
cojencohttps://github.com/cojenco
July 9, 2021 22:21https://github.com/googleapis/python-storage/pull/483#event-5002439633
cojencohttps://github.com/cojenco
Oct 13, 2021 https://github.com/googleapis/python-storage/pull/483#ref-commit-42487ba
https://github.com/cojenco
fix: revise and rename is_etag_in_json(data) (https://github.com/cojenco/python-storage/commit/42487ba596716a2893d4e5a4ae6b3cfbd4e7dbd7
googleapis#483https://github.com/googleapis/python-storage/pull/483
)https://github.com/cojenco/python-storage/commit/42487ba596716a2893d4e5a4ae6b3cfbd4e7dbd7
42487bahttps://github.com/cojenco/python-storage/commit/42487ba596716a2893d4e5a4ae6b3cfbd4e7dbd7
cojencohttps://github.com/cojenco
Oct 13, 2021 https://github.com/googleapis/python-storage/pull/483#ref-commit-4e3021f
https://github.com/cojenco
fix: revise and rename is_etag_in_json(data) (https://github.com/cojenco/python-storage/commit/4e3021f48863f21243a108aa2d2017b58a563f3b
googleapis#483https://github.com/googleapis/python-storage/pull/483
)https://github.com/cojenco/python-storage/commit/4e3021f48863f21243a108aa2d2017b58a563f3b
4e3021fhttps://github.com/cojenco/python-storage/commit/4e3021f48863f21243a108aa2d2017b58a563f3b
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Jan 12, 2022 https://github.com/googleapis/python-storage/pull/483#ref-pullrequest-1100663527
chore(main): release 3.0.0 #688 https://github.com/googleapis/python-storage/pull/688
https://github.com/andtrott
andtrotthttps://github.com/andtrott
Nov 27, 2024 https://github.com/googleapis/python-storage/pull/483#ref-issue-2700253529
Storage list_blobs iterator doesn't return prefixes #1388 https://github.com/googleapis/python-storage/issues/1388
https://github.co/hiddenchars
https://github.com/googleapis/python-storage/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-storage%2Fpull%2F483
https://github.com/tseaver
tseaver https://github.com/tseaver
https://github.com/googleapis/python-storage/pull/483/files/ba3c16abd5a91e2d42d3e53b198ef03c547f6e46
https://github.com/tritone
tritone https://github.com/tritone
https://github.com/googleapis/python-storage/pull/483/files/ba3c16abd5a91e2d42d3e53b198ef03c547f6e46
api: storage https://github.com/googleapis/python-storage/issues?q=state%3Aopen%20label%3A%22api%3A%20storage%22
cla: yes https://github.com/googleapis/python-storage/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Handle data dict type in retry.is_etag_in_json(data) https://github.com/googleapis/python-storage/issues/481
Please reload this pagehttps://github.com/googleapis/python-storage/pull/483
https://github.com/cojenco
https://github.com/tseaver
https://github.com/tritone
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.