René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Storage: mtime of downloaded file is incorrect by UTC offset","articleBody":"Google Cloud Storage v1.25.0\r\nPython 3.7.3\r\nOS: OSX \u0026 Win7\r\n\r\nIssue: If I upload a file to Google Cloud Storage and then immediately download it, the mtime is incorrect - for me, I'm in EST, so I'm 5 hours behind UTC.  That's the exact timedelta that occurs between the file's original mtime and the recorded mtime after the file is downloaded.\r\n\r\nHere's an example screenshot:\r\n![Screen Shot 2020-01-27 at 9 35 52 PM](https://user-images.githubusercontent.com/26491362/73231091-5a360b80-414d-11ea-9001-695bc0757061.png)\r\nThe original file mtime in Google Cloud Storage is 1/23/20 9:04 PM (which is correct from the file I uploaded), but when I download the file, the mtime becomes 1/24/20 2:04 AM, which is 5 hours ahead of what is supposed to be (the UTC offset from my timezone).\r\n\r\nThe issue is here in `blob.download_to_filename`:\r\n```\r\nupdated = self.updated\r\nif updated is not None:\r\n            mtime = time.mktime(updated.timetuple())\r\n            os.utime(file_obj.name, (mtime, mtime))\r\n```\r\nIn my example, `updated` is the timezone-aware datetime corresponding to `2020-01-24 02:04:11.184000+00:00` (it has `tzinfo==UTC`).  The `updated.timetuple()` is\r\n```\r\ntime.struct_time(tm_year=2020, tm_mon=1, tm_mday=24, tm_hour=2, tm_min=4, tm_sec=9, tm_wday=4, tm_yday=24, tm_isdst=0)\r\n```\r\n\r\nThe problem, I believe, is that the timetuple doesn't know this is a UTC date, nor did it convert to my timezone.  The docs of `mktime` note, \"Its argument is the struct_time or full 9-tuple (since the dst flag is needed; use -1 as the dst flag if it is unknown) which expresses the time in local time, not UTC.\"  Perhaps, we should do this instead:\r\n```\r\nif updated is not None:\r\n   mtime = updated.timestamp() # For Python3, not sure of the Python2 version\r\n   os.utime(file_obj.name, (mtime, mtime))\r\n```\r\n\r\nThe `timestamp()` function accounts for the timezone information in the datetime object.\r\nI've just been doing this manually in my code after downloading a file because my application is sensitive to mtimes, and it seems to fix the issue.","author":{"url":"https://github.com/mcsimps2","@type":"Person","name":"mcsimps2"},"datePublished":"2020-01-28T02:54:43.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/4/python-storage/issues/4"}