René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"DatabaseAdmin: on Duplicate name in Schema, gRPC FailedPrecondition status code is not handled and sent back as None","articleBody":"If I have a table that already exists and try to create the same table, this package errors but its error code is None yet its message is `Duplicate name in schema: `.\r\n\r\n### Reproduction\r\n```python\r\nfrom google.cloud import spanner_v1 as spanner\r\n\r\ndef main():\r\n    db = spanner.Client().instance('django-tests').database('db1')\r\n    lro = db.update_ddl(['CREATE TABLE foo (id INT64) PRIMARY KEY(id)'])\r\n\r\n    try:\r\n        result = lro.result()\r\n    except Exception as e:\r\n        print('\\033[31mCode: %s gRPC_StatusCode: %s Message: %s\\033[00m' % \r\n                (e.code, e.grpc_status_code, e.message))\r\n        raise e\r\n    else:\r\n        print(result)\r\n\r\nif __name__ == '__main__':\r\n    main()\r\n```\r\nwhich unfortunately prints out\r\n```shell\r\nCode: None gRPC_StatusCode: None Message: Duplicate name in schema: foo.\r\nTraceback (most recent call last):\r\n  File \"duplicate_table_v1.py\", line 18, in \u003cmodule\u003e\r\n    main()\r\n  File \"duplicate_table_v1.py\", line 12, in main\r\n    raise e\r\n  File \"duplicate_table_v1.py\", line 8, in main\r\n    result = lro.result()\r\n  File \"/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/google/api_core/future/polling.py\", line 127, in result\r\n    raise self._exception\r\ngoogle.api_core.exceptions.GoogleAPICallError: None Duplicate name in schema: foo.\r\n```\r\n\r\nThis bug presents an inconsistency in the error handling because we get an error with a `None` status code and `None` gRPC status code, yet it has a message.\r\n\r\n### Comparison with Go\r\nI can confirm that Cloud Spanner actually sends back the status code because the Go result actually has the status code, with this reproduction and by investigation the responses sent by the Spanner server\r\n```go\r\npackage main\r\n\r\nimport (\r\n\t\"context\"\r\n\r\n\tdbadmin \"cloud.google.com/go/spanner/admin/database/apiv1\"\r\n\tdbspb \"google.golang.org/genproto/googleapis/spanner/admin/database/v1\"\r\n)\r\n\r\nfunc main() {\r\n\tctx := context.Background()\r\n\tadminClient, err := dbadmin.NewDatabaseAdminClient(ctx)\r\n\tif err != nil {\r\n\t\tpanic(err)\r\n\t}\r\n\tddlReq := \u0026dbspb.UpdateDatabaseDdlRequest{\r\n\t\tDatabase: \"projects/orijtech-161805/instances/django-tests/databases/db1\",\r\n\t\tStatements: []string{\r\n\t\t\t\"CREATE TABLE foo (id INT64) PRIMARY KEY(id)\",\r\n\t\t},\r\n\t}\r\n\tlro, err := adminClient.UpdateDatabaseDdl(ctx, ddlReq)\r\n\tif err != nil {\r\n\t\tpanic(err)\r\n\t}\r\n\tif err := lro.Wait(ctx); err != nil {\r\n\t\tpanic(err)\r\n\t}\r\n}\r\n```\r\nand prints out\r\n```shell\r\nSleeping for 947.779411ms\r\npanic: rpc error: code = FailedPrecondition desc = Duplicate name in schema: foo.\r\n\r\ngoroutine 1 [running]:\r\nmain.main()\r\n\t/Users/emmanuelodeke/Desktop/spanner-orm-trials/duplicate_table.go:27 +0x1db\r\nexit status 2\r\n```\r\n\r\n### Postulation\r\nI think that the result of waiting on the long running operation isn't being properly used to retrieve the status code.\r\n\r\n/cc @larkee @skuruppu, and for an FYI @bvandiver @timgraham","author":{"url":"https://github.com/odeke-em","@type":"Person","name":"odeke-em"},"datePublished":"2020-03-16T02:38:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/38/python-spanner/issues/38"}