René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Deflake OpenTelemetry assertion in system tests","articleBody":"The OpenTelemetry assertions in the system tests fail if the transaction is aborted and retried. This is extremely brittle so the assertions need to be updated to account for retrying aborted transactions.\r\n\r\nExample of test failure:\r\n```\r\n________ TestSessionAPI.test_transaction_read_and_insert_then_rollback _________\r\n\r\nself = \u003ctests.system.test_system.TestSessionAPI testMethod=test_transaction_read_and_insert_then_rollback\u003e\r\n\r\n    @RetryErrors(exception=exceptions.ServerError)\r\n    @RetryErrors(exception=exceptions.Aborted)\r\n    def test_transaction_read_and_insert_then_rollback(self):\r\n        retry = RetryInstanceState(_has_all_ddl)\r\n        retry(self._db.reload)()\r\n\r\n        session = self._db.session()\r\n        session.create()\r\n        self.to_delete.append(session)\r\n\r\n        with self._db.batch() as batch:\r\n            batch.delete(self.TABLE, self.ALL)\r\n\r\n        transaction = session.transaction()\r\n        transaction.begin()\r\n\r\n        rows = list(transaction.read(self.TABLE, self.COLUMNS, self.ALL))\r\n        self.assertEqual(rows, [])\r\n\r\n        transaction.insert(self.TABLE, self.COLUMNS, self.ROW_DATA)\r\n\r\n        # Inserted rows can't be read until after commit.\r\n        rows = list(transaction.read(self.TABLE, self.COLUMNS, self.ALL))\r\n        self.assertEqual(rows, [])\r\n        transaction.rollback()\r\n\r\n        rows = list(session.read(self.TABLE, self.COLUMNS, self.ALL))\r\n        self.assertEqual(rows, [])\r\n\r\n        if HAS_OPENTELEMETRY_INSTALLED:\r\n            span_list = self.memory_exporter.get_finished_spans()\r\n\u003e           self.assertEqual(len(span_list), 8)\r\nE           AssertionError: 14 != 8\r\n\r\ntests/system/test_system.py:1026: AssertionError\r\n----------------------------- Captured stdout call -----------------------------\r\n409 Transaction was aborted., Trying again in 1 seconds...\r\n------------------------------ Captured log call -------------------------------\r\nWARNING  opentelemetry.trace:__init__.py:468 Overriding current TracerProvider\r\nWARNING  opentelemetry.trace:__init__.py:468 Overriding current TracerProvider\r\n```","author":{"url":"https://github.com/larkee","@type":"Person","name":"larkee"},"datePublished":"2020-11-11T01:37:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/165/python-spanner/issues/165"}