René's URL Explorer Experiment


Title: fix: ACK deadline set for received messages can be too low by plamut · Pull Request #416 · googleapis/python-pubsub · GitHub

Open Graph Title: fix: ACK deadline set for received messages can be too low by plamut · Pull Request #416 · googleapis/python-pubsub

X Title: fix: ACK deadline set for received messages can be too low by plamut · Pull Request #416 · googleapis/python-pubsub

Description: This library has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-pubsub - fix: ACK deadline set for received messages can be too low by plamut · Pull Request #416 · googleapis/python-pubsub

Open Graph Description: Fixes #413. This PR makes sure that the ACK deadline set for the received messages is always consistent with what the leaser uses internally when extending the ACK deadlines for the leased messages...

X Description: Fixes #413. This PR makes sure that the ACK deadline set for the received messages is always consistent with what the leaser uses internally when extending the ACK deadlines for the leased messages...

Opengraph URL: https://github.com/googleapis/python-pubsub/pull/416

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e830549a-c976-7cc3-3e92-717de81d270a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8396:1F55B6:92DCB5:D7F4AF:6A4E1B96
html-safe-nonceb91b6ab40f10ef3fc295e640471afca3b7d190dd5304acb63368533b244ddec6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mzk2OjFGNTVCNjo5MkRDQjU6RDdGNEFGOjZBNEUxQjk2IiwidmlzaXRvcl9pZCI6IjY3Mzg2MTAwMzM0MjcwOTQ0MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac627c016e4f10ee3aa7daaec019e3258a5e2afd0c2092d836a85ec211074c5951
hovercard-subject-tagpull_request:649848520
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-pubsub/416/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/32db51c836e4a94cb456cc26af32dbca83d8fcbae3319d8559342a930d0bd925/googleapis/python-pubsub/pull/416
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/32db51c836e4a94cb456cc26af32dbca83d8fcbae3319d8559342a930d0bd925/googleapis/python-pubsub/pull/416
og:image:altFixes #413. This PR makes sure that the ACK deadline set for the received messages is always consistent with what the leaser uses internally when extending the ACK deadlines for the leased messages...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameplamut
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/googleapis/python-pubsub git https://github.com/googleapis/python-pubsub.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992581
octolytics-dimension-repository_nwogoogleapis/python-pubsub
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992581
octolytics-dimension-repository_network_root_nwogoogleapis/python-pubsub
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5fe497b4815fcce3df76c0e246faa739a82c3124
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-pubsub/pull/416#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fpull%2F416
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fpull%2F416
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-pubsub
Reloadhttps://github.com/googleapis/python-pubsub/pull/416
Reloadhttps://github.com/googleapis/python-pubsub/pull/416
Reloadhttps://github.com/googleapis/python-pubsub/pull/416
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
googleapis https://github.com/googleapis
python-pubsubhttps://github.com/googleapis/python-pubsub
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Fork 214 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Star 430 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Code https://github.com/googleapis/python-pubsub
Issues 0 https://github.com/googleapis/python-pubsub/issues
Pull requests 0 https://github.com/googleapis/python-pubsub/pulls
Actions https://github.com/googleapis/python-pubsub/actions
Projects https://github.com/googleapis/python-pubsub/projects
Security and quality 0 https://github.com/googleapis/python-pubsub/security
Insights https://github.com/googleapis/python-pubsub/pulse
Code https://github.com/googleapis/python-pubsub
Issues https://github.com/googleapis/python-pubsub/issues
Pull requests https://github.com/googleapis/python-pubsub/pulls
Actions https://github.com/googleapis/python-pubsub/actions
Projects https://github.com/googleapis/python-pubsub/projects
Security and quality https://github.com/googleapis/python-pubsub/security
Insights https://github.com/googleapis/python-pubsub/pulse
gcf-merge-on-green[bot]https://github.com/gcf-merge-on-green[bot]
googleapis:masterhttps://github.com/googleapis/python-pubsub/tree/master
plamut:iss-413https://github.com/plamut/python-pubsub/tree/iss-413
Conversationhttps://github.com/googleapis/python-pubsub/pull/416
Commits6 (6)https://github.com/googleapis/python-pubsub/pull/416/commits
Checkshttps://github.com/googleapis/python-pubsub/pull/416/checks
Files changedhttps://github.com/googleapis/python-pubsub/pull/416/files
fix: ACK deadline set for received messages can be too low https://github.com/googleapis/python-pubsub/pull/416#top
gcf-merge-on-green[bot]https://github.com/gcf-merge-on-green[bot]
googleapis:masterhttps://github.com/googleapis/python-pubsub/tree/master
plamut:iss-413https://github.com/plamut/python-pubsub/tree/iss-413
https://github.com/plamut
plamuthttps://github.com/plamut
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#issue-897908195
#413https://github.com/googleapis/python-pubsub/issues/413
commenthttps://github.com/googleapis/python-pubsub/issues/413#issuecomment-844995852
bug/issuehttps://github.com/googleapis/python-pubsub/issues/new/choose
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
https://github.com/plamut
fix: use the same initial ACK deadline as leaserhttps://github.com/googleapis/python-pubsub/pull/416/commits/223a986d9394302af12e5eb1940625a6a12bb456
223a986https://github.com/googleapis/python-pubsub/pull/416/commits/223a986d9394302af12e5eb1940625a6a12bb456
https://github.com/plamut
plamuthttps://github.com/plamut
May 21, 2021 10:22https://github.com/googleapis/python-pubsub/pull/416#event-4778489986
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
api: pubsub https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4778490162
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4778490239
https://github.com/plamut
Make max_duration_per_lease_extension high enoughhttps://github.com/googleapis/python-pubsub/pull/416/commits/dc2b2337e6e44073bdfe42d6d679da75290dc88e
dc2b233https://github.com/googleapis/python-pubsub/pull/416/commits/dc2b2337e6e44073bdfe42d6d679da75290dc88e
https://github.com/plamut
plamuthttps://github.com/plamut
force-pushedhttps://github.com/googleapis/python-pubsub/compare/5407e011a65e0d8bd5e26b7fbe85c7a08f0dc857..82e116641242ba2924c8c05ff9eb4a91a0516745
5407e01https://github.com/googleapis/python-pubsub/commit/5407e011a65e0d8bd5e26b7fbe85c7a08f0dc857
82e1166https://github.com/googleapis/python-pubsub/commit/82e116641242ba2924c8c05ff9eb4a91a0516745
Compare https://github.com/googleapis/python-pubsub/compare/5407e011a65e0d8bd5e26b7fbe85c7a08f0dc857..82e116641242ba2924c8c05ff9eb4a91a0516745
May 21, 2021 11:08https://github.com/googleapis/python-pubsub/pull/416#event-4778681579
https://github.com/plamut
Bump histogram test coverage to 100%https://github.com/googleapis/python-pubsub/pull/416/commits/aed7784f444400200e1f86c578e01bb76c55bf0c
aed7784https://github.com/googleapis/python-pubsub/pull/416/commits/aed7784f444400200e1f86c578e01bb76c55bf0c
https://github.com/plamut
plamuthttps://github.com/plamut
force-pushedhttps://github.com/googleapis/python-pubsub/compare/82e116641242ba2924c8c05ff9eb4a91a0516745..aed7784f444400200e1f86c578e01bb76c55bf0c
82e1166https://github.com/googleapis/python-pubsub/commit/82e116641242ba2924c8c05ff9eb4a91a0516745
aed7784https://github.com/googleapis/python-pubsub/commit/aed7784f444400200e1f86c578e01bb76c55bf0c
Compare https://github.com/googleapis/python-pubsub/compare/82e116641242ba2924c8c05ff9eb4a91a0516745..aed7784f444400200e1f86c578e01bb76c55bf0c
May 21, 2021 11:25https://github.com/googleapis/python-pubsub/pull/416#event-4778747539
https://github.com/plamut
plamuthttps://github.com/plamut
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#issuecomment-845890305
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
https://github.com/plamut
plamuthttps://github.com/plamut
do not merge https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4778805151
https://github.com/plamut
Only update ACK deadline through leaserhttps://github.com/googleapis/python-pubsub/pull/416/commits/ee29da44f565b1df53e4bbdff67a69671df891a2
ee29da4https://github.com/googleapis/python-pubsub/pull/416/commits/ee29da44f565b1df53e4bbdff67a69671df891a2
https://github.com/plamut
plamuthttps://github.com/plamut
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#issuecomment-846086204
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
https://github.com/plamut
plamuthttps://github.com/plamut
do not merge https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4780299952
https://github.com/plamut
plamuthttps://github.com/plamut
pradnhttps://github.com/pradn
May 21, 2021 16:30https://github.com/googleapis/python-pubsub/pull/416#event-4780301913
https://github.com/plamut
plamuthttps://github.com/plamut
kokoro:force-run https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4780393952
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 21, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4780406214
https://github.com/plamut
plamuthttps://github.com/plamut
kokoro:force-run https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 22, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4782326630
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
May 22, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4782326935
https://github.com/jimfulton
jimfultonhttps://github.com/jimfulton
May 25, 2021 https://github.com/googleapis/python-pubsub/pull/416#pullrequestreview-666888347
View reviewed changes https://github.com/googleapis/python-pubsub/pull/416/files/ee29da44f565b1df53e4bbdff67a69671df891a2
google/cloud/pubsub_v1/subscriber/_protocol/histogram.pyhttps://github.com/googleapis/python-pubsub/pull/416/files/ee29da44f565b1df53e4bbdff67a69671df891a2#diff-da97f13cc0da53eb245c25a3f1c0c4339e747263bc9623e6c40d10258420f46e
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
google/cloud/pubsub_v1/subscriber/_protocol/leaser.pyhttps://github.com/googleapis/python-pubsub/pull/416/files/ee29da44f565b1df53e4bbdff67a69671df891a2#diff-2d50f27237399e42528009fdabbcdcc220db9b7f40b78d55888b57740ffee357
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
https://github.com/plamut
Be more explicit about the default Histogram.minhttps://github.com/googleapis/python-pubsub/pull/416/commits/64e4d7a12273eec4dd05f3f5ef4f51a270166b8a
64e4d7ahttps://github.com/googleapis/python-pubsub/pull/416/commits/64e4d7a12273eec4dd05f3f5ef4f51a270166b8a
https://github.com/jimfulton
jimfultonhttps://github.com/jimfulton
May 26, 2021 https://github.com/googleapis/python-pubsub/pull/416#pullrequestreview-669064851
View reviewed changes https://github.com/googleapis/python-pubsub/pull/416/files/64e4d7a12273eec4dd05f3f5ef4f51a270166b8a
https://github.com/plamut
Avoid hardcoded values in Histogram docstringhttps://github.com/googleapis/python-pubsub/pull/416/commits/d772cab394c66d269fd9759e2590852282cc3472
d772cabhttps://github.com/googleapis/python-pubsub/pull/416/commits/d772cab394c66d269fd9759e2590852282cc3472
https://github.com/plamut
plamuthttps://github.com/plamut
automerge https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3Aautomerge
May 26, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4799707659
https://github.com/apps/gcf-merge-on-green
gcf-merge-on-greenhttps://github.com/apps/gcf-merge-on-green
e907f6ehttps://github.com/googleapis/python-pubsub/commit/e907f6e05f59f64a3b08df3304e92ec960997be6
May 26, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4799797075
https://github.com/apps/gcf-merge-on-green
gcf-merge-on-greenhttps://github.com/apps/gcf-merge-on-green
automerge https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3Aautomerge
May 26, 2021https://github.com/googleapis/python-pubsub/pull/416#event-4799797269
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Aug 11, 2022 https://github.com/googleapis/python-pubsub/pull/416#ref-pullrequest-1336168184
chore(main): release 2.13.6 #761 https://github.com/googleapis/python-pubsub/pull/761
https://github.co/hiddenchars
https://github.com/googleapis/python-pubsub/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fpull%2F416
https://github.com/pradn
pradn https://github.com/pradn
https://github.com/jimfulton
jimfulton https://github.com/jimfulton
https://github.com/googleapis/python-pubsub/pull/416/files/64e4d7a12273eec4dd05f3f5ef4f51a270166b8a
api: pubsub https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
cla: yes https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
The initial ACK deadline set for the messages received could be too low https://github.com/googleapis/python-pubsub/issues/413
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/416
https://github.com/plamut
https://github.com/jimfulton
https://github.com/yoshi-kokoro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.