René's URL Explorer Experiment


Title: feat: make publish futures compatible with `concurrent.futures.as_completed()` by plamut · Pull Request #374 · googleapis/python-pubsub · GitHub

Open Graph Title: feat: make publish futures compatible with `concurrent.futures.as_completed()` by plamut · Pull Request #374 · googleapis/python-pubsub

X Title: feat: make publish futures compatible with `concurrent.futures.as_completed()` by plamut · Pull Request #374 · googleapis/python-pubsub

Description: This library has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-pubsub - feat: make publish futures compatible with `concurrent.futures.as_completed()` by plamut · Pull Request #374 · googleapis/python-pubsub

Open Graph Description: Closes #368. After studying the as_completed() code from the standard library, it actually seemed easier to modify our futures implementation, as opposed to writing our own as_completed() logic, wh...

X Description: Closes #368. After studying the as_completed() code from the standard library, it actually seemed easier to modify our futures implementation, as opposed to writing our own as_completed() logic, wh...

Opengraph URL: https://github.com/googleapis/python-pubsub/pull/374

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3f374685-8b2e-018c-2735-75c5620b5b62
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id907A:153FD3:27283F5:355766B:6A53ABD7
html-safe-nonce2f68a76738b43289227b9d63a95090b623756720e5ab58104202393ab1322c63
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDdBOjE1M0ZEMzoyNzI4M0Y1OjM1NTc2NkI6NkE1M0FCRDciLCJ2aXNpdG9yX2lkIjoiNTQ2NjE5MDU5MDA0Njg3NDU4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1bcc184c85f3cae201fc2dace04d51a2e17f30a95bbdf37fb2070aae3f952511
hovercard-subject-tagpull_request:614466090
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-pubsub/374/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7a59d10fc05ff74c6c708eb9711e7e810d1c177d620cc974566b95b4fc004ce/googleapis/python-pubsub/pull/374
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7a59d10fc05ff74c6c708eb9711e7e810d1c177d620cc974566b95b4fc004ce/googleapis/python-pubsub/pull/374
og:image:altCloses #368. After studying the as_completed() code from the standard library, it actually seemed easier to modify our futures implementation, as opposed to writing our own as_completed() logic, wh...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameplamut
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/googleapis/python-pubsub git https://github.com/googleapis/python-pubsub.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992581
octolytics-dimension-repository_nwogoogleapis/python-pubsub
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992581
octolytics-dimension-repository_network_root_nwogoogleapis/python-pubsub
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-pubsub/pull/374#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fpull%2F374
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fpull%2F374
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-pubsub
Reloadhttps://github.com/googleapis/python-pubsub/pull/374
Reloadhttps://github.com/googleapis/python-pubsub/pull/374
Reloadhttps://github.com/googleapis/python-pubsub/pull/374
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
googleapis https://github.com/googleapis
python-pubsubhttps://github.com/googleapis/python-pubsub
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Fork 214 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Star 430 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Code https://github.com/googleapis/python-pubsub
Issues 0 https://github.com/googleapis/python-pubsub/issues
Pull requests 0 https://github.com/googleapis/python-pubsub/pulls
Actions https://github.com/googleapis/python-pubsub/actions
Projects https://github.com/googleapis/python-pubsub/projects
Security and quality 0 https://github.com/googleapis/python-pubsub/security
Insights https://github.com/googleapis/python-pubsub/pulse
Code https://github.com/googleapis/python-pubsub
Issues https://github.com/googleapis/python-pubsub/issues
Pull requests https://github.com/googleapis/python-pubsub/pulls
Actions https://github.com/googleapis/python-pubsub/actions
Projects https://github.com/googleapis/python-pubsub/projects
Security and quality https://github.com/googleapis/python-pubsub/security
Insights https://github.com/googleapis/python-pubsub/pulse
plamuthttps://github.com/plamut
googleapis:masterhttps://github.com/googleapis/python-pubsub/tree/master
plamut:iss-368https://github.com/plamut/python-pubsub/tree/iss-368
Conversationhttps://github.com/googleapis/python-pubsub/pull/374
Commits3 (3)https://github.com/googleapis/python-pubsub/pull/374/commits
Checkshttps://github.com/googleapis/python-pubsub/pull/374/checks
Files changedhttps://github.com/googleapis/python-pubsub/pull/374/files
feat: make publish futures compatible with concurrent.futures.as_completed()https://github.com/googleapis/python-pubsub/pull/374#top
plamuthttps://github.com/plamut
googleapis:masterhttps://github.com/googleapis/python-pubsub/tree/master
plamut:iss-368https://github.com/plamut/python-pubsub/tree/iss-368
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 13, 2021https://github.com/googleapis/python-pubsub/pull/374#issue-856969475
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
#368https://github.com/googleapis/python-pubsub/issues/368
as_completed()https://github.com/python/cpython/blob/15ad30d88fead718b7eeff8c54454b82753d520e/Lib/concurrent/futures/_base.py#L201-L261
blamehttps://github.com/python/cpython/blame/57873af35aad98c6428b1718aaee4b16a82ea3f5/Lib/concurrent/futures/_base.py
bug/issuehttps://github.com/googleapis/python-pubsub/issues/new/choose
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
api: pubsub https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
Apr 13, 2021https://github.com/googleapis/python-pubsub/pull/374#event-4588114565
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
cla: yes https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 13, 2021https://github.com/googleapis/python-pubsub/pull/374#event-4588116057
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 13, 2021 https://github.com/googleapis/python-pubsub/pull/374#pullrequestreview-634600000
View reviewed changes https://github.com/googleapis/python-pubsub/pull/374/files
google/cloud/pubsub_v1/futures.pyhttps://github.com/googleapis/python-pubsub/pull/374/files#diff-556b13f04b45eb74797570df3d51333f537bcee097bab1a7dd8172551a2af303
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
plamuthttps://github.com/plamut
pradnhttps://github.com/pradn
April 13, 2021 17:51https://github.com/googleapis/python-pubsub/pull/374#event-4589494967
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 13, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-818931676
@pradnhttps://github.com/pradn
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/pradn
pradnhttps://github.com/pradn
Apr 13, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-818972150
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
plamuthttps://github.com/plamut
April 14, 2021 12:14https://github.com/googleapis/python-pubsub/pull/374#commits-pushed-a3d4e5e
https://github.com/plamut
feat: make futures compatible with as_completed()https://github.com/googleapis/python-pubsub/pull/374/commits/a3d4e5e7b15d3ac6673fb42873d47ffba6b4774c
a3d4e5ehttps://github.com/googleapis/python-pubsub/pull/374/commits/a3d4e5e7b15d3ac6673fb42873d47ffba6b4774c
https://github.com/plamut
Remove duplicate code from publisher futurehttps://github.com/googleapis/python-pubsub/pull/374/commits/8d2be8a8377b7bff65fd441035084f35436e3d6b
8d2be8ahttps://github.com/googleapis/python-pubsub/pull/374/commits/8d2be8a8377b7bff65fd441035084f35436e3d6b
https://github.com/plamut
Add compatibility test with built-in as_completedhttps://github.com/googleapis/python-pubsub/pull/374/commits/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
1b6ac56https://github.com/googleapis/python-pubsub/pull/374/commits/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
https://github.com/plamut
plamuthttps://github.com/plamut
force-pushedhttps://github.com/googleapis/python-pubsub/compare/0705698eba51e1771d09643a9f6cef9d53bbbf4b..1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
0705698https://github.com/googleapis/python-pubsub/commit/0705698eba51e1771d09643a9f6cef9d53bbbf4b
1b6ac56https://github.com/googleapis/python-pubsub/commit/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
Compare https://github.com/googleapis/python-pubsub/compare/0705698eba51e1771d09643a9f6cef9d53bbbf4b..1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
April 14, 2021 10:15https://github.com/googleapis/python-pubsub/pull/374#event-4592735966
https://github.com/plamut
plamuthttps://github.com/plamut
April 14, 2021 10:16https://github.com/googleapis/python-pubsub/pull/374#event-4592739978
https://github.com/plamut
plamuthttps://github.com/plamut
April 14, 2021 10:16https://github.com/googleapis/python-pubsub/pull/374#event-4592739996
https://github.com/pradn
pradnhttps://github.com/pradn
Apr 21, 2021 https://github.com/googleapis/python-pubsub/pull/374#pullrequestreview-641617125
View reviewed changes https://github.com/googleapis/python-pubsub/pull/374/files/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
google/cloud/pubsub_v1/futures.pyhttps://github.com/googleapis/python-pubsub/pull/374/files/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b#diff-556b13f04b45eb74797570df3d51333f537bcee097bab1a7dd8172551a2af303
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/pradn
pradnhttps://github.com/pradn
Apr 21, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-824418383
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 22, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-824897555
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/pradn
pradnhttps://github.com/pradn
Apr 22, 2021 https://github.com/googleapis/python-pubsub/pull/374#pullrequestreview-642292795
View reviewed changes https://github.com/googleapis/python-pubsub/pull/374/files/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
https://github.com/pradn
pradnhttps://github.com/pradn
Apr 22, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-824904925
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 22, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-824911030
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
@jimfultonhttps://github.com/jimfulton
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
plamuthttps://github.com/plamut
pradnhttps://github.com/pradn
stale reviewhttps://github.com/googleapis/python-pubsub/pull/374#pullrequestreview-642292795
April 22, 2021 17:55https://github.com/googleapis/python-pubsub/pull/374#event-4632520915
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 22, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-825066605
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
@dpcollins-googlehttps://github.com/dpcollins-google
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
plamuthttps://github.com/plamut
do not merge https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
Apr 22, 2021https://github.com/googleapis/python-pubsub/pull/374#event-4632562280
https://github.com/plamut
plamuthttps://github.com/plamut
Apr 26, 2021 https://github.com/googleapis/python-pubsub/pull/374#ref-pullrequest-867750885
feat: make publish futures compatible with concurrent.futures.as_completed() #397 https://github.com/googleapis/python-pubsub/pull/397
https://github.com/plamut
plamuthttps://github.com/plamut
May 15, 2021https://github.com/googleapis/python-pubsub/pull/374#issuecomment-841666347
#397https://github.com/googleapis/python-pubsub/pull/397
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
plamuthttps://github.com/plamut
May 15, 2021https://github.com/googleapis/python-pubsub/pull/374#event-4750023284
https://github.co/hiddenchars
https://github.com/googleapis/python-pubsub/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fpull%2F374
https://github.com/pradn
pradn https://github.com/pradn
https://github.com/googleapis/python-pubsub/pull/374/files/1b6ac567c10c6e412f6d23fab1ba3225ed64d87b
api: pubsub https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
cla: yes https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
do not merge https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
Make publish futures compatible with concurrent.futures.as_completed() https://github.com/googleapis/python-pubsub/issues/368
Please reload this pagehttps://github.com/googleapis/python-pubsub/pull/374
https://github.com/plamut
https://github.com/pradn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.