René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"tests.system: test_subscriber_not_leaking_open_sockets[grpc-grpc-rest] failed","articleBody":"This test failed!\n\nTo configure my behavior, see [the Flaky Bot documentation](https://github.com/googleapis/repo-automation-bots/tree/main/packages/flakybot).\n\nIf I'm commenting on this issue too often, add the `flakybot: quiet` label and\nI will stop commenting.\n\n---\n\ncommit: 5a47963d5e58b7133c6286a17589d1c32fcbfc24\nbuildURL: [Build Status](https://source.cloud.google.com/results/invocations/254cc789-de9d-42ff-b481-adf9f5a1113e), [Sponge](http://sponge2/254cc789-de9d-42ff-b481-adf9f5a1113e)\nstatus: failed\n\u003cdetails\u003e\u003csummary\u003eTest output\u003c/summary\u003e\u003cbr\u003e\u003cpre\u003epublisher = \u003cgoogle.cloud.pubsub_v1.PublisherClient object at 0x7fb8601c0250\u003e\ntopic_path_base = 'projects/precise-truck-742/topics/t-1692375611236'\nsubscription_path_base = 'projects/precise-truck-742/subscriptions/s-1692375611238'\ncleanup = [(\u003cbound method SubscriberClient.delete_subscription of \u003cgoogle.cloud.pubsub_v1.SubscriberClient object at 0x7fb8622de...ject at 0x7fb8601c0250\u003e\u003e, (), {'topic': 'projects/precise-truck-742/topics/t-1692375611236-not-leaking-open-sockets'})]\ntransport = 'rest'\n\n    @pytest.mark.parametrize(\"transport\", [\"grpc\", \"rest\"])\n    def test_subscriber_not_leaking_open_sockets(\n        publisher, topic_path_base, subscription_path_base, cleanup, transport\n    ):\n        # Make sure the topic and the supscription get deleted.\n        # NOTE: Since subscriber client will be closed in the test, we should not\n        # use the shared `subscriber` fixture, but instead construct a new client\n        # in this test.\n        # Also, since the client will get closed, we need another subscriber client\n        # to clean up the subscription. We also need to make sure that auxiliary\n        # subscriber releases the sockets, too.\n        custom_str = \"-not-leaking-open-sockets\"\n        subscription_path = subscription_path_base + custom_str\n        topic_path = topic_path_base + custom_str\n        subscriber = pubsub_v1.SubscriberClient(transport=\"grpc\")\n        subscriber_2 = pubsub_v1.SubscriberClient(transport=\"grpc\")\n    \n        cleanup.append(\n            (subscriber_2.delete_subscription, (), {\"subscription\": subscription_path})\n        )\n        cleanup.append((subscriber_2.close, (), {}))\n        cleanup.append((publisher.delete_topic, (), {\"topic\": topic_path}))\n    \n        # Create topic before starting to track connection count (any sockets opened\n        # by the publisher client are not counted by this test).\n        publisher.create_topic(name=topic_path)\n    \n        current_process = psutil.Process()\n        conn_count_start = len(current_process.connections())\n    \n        # Publish a few messages, then synchronously pull them and check that\n        # no sockets are leaked.\n        with subscriber:\n            subscriber.create_subscription(name=subscription_path, topic=topic_path)\n    \n            # Publish a few messages, wait for the publish to succeed.\n            publish_futures = [\n                publisher.publish(topic_path, \"message {}\".format(i).encode())\n                for i in range(1, 4)\n            ]\n            for future in publish_futures:\n                future.result()\n    \n            # Synchronously pull messages.\n            response = subscriber.pull(subscription=subscription_path, max_messages=3)\n            assert len(response.received_messages) == 3\n    \n        conn_count_end = len(current_process.connections())\n    \n        # To avoid flakiness, use \u003c= in the assertion, since on rare occasions additional\n        # sockets are closed, causing the == assertion to fail.\n        # https://github.com/googleapis/python-pubsub/issues/483#issuecomment-910122086\n\u003e       assert conn_count_end \u003c= conn_count_start\nE       assert 2 \u003c= 1\n\ntests/system.py:495: AssertionError\u003c/pre\u003e\u003c/details\u003e","author":{"url":"https://github.com/flaky-bot[bot]","@type":"Person","name":"flaky-bot[bot]"},"datePublished":"2023-08-18T16:35:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/981/python-pubsub/issues/981"}