Title: The initial ACK deadline set for the messages received could be too low · Issue #413 · googleapis/python-pubsub · GitHub
Open Graph Title: The initial ACK deadline set for the messages received could be too low · Issue #413 · googleapis/python-pubsub
X Title: The initial ACK deadline set for the messages received could be too low · Issue #413 · googleapis/python-pubsub
Description: Is there a reason that https://github.com/googleapis/python-pubsub/blob/master/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py#L493 calls self.ack_histogram.percentile(99) directly rather than using https://github.c...
Open Graph Description: Is there a reason that https://github.com/googleapis/python-pubsub/blob/master/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py#L493 calls self.ack_histogram.percentile(99) dir...
X Description: Is there a reason that https://github.com/googleapis/python-pubsub/blob/master/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py#L493 calls self.ack_histogram.percentile(99) dir...
Opengraph URL: https://github.com/googleapis/python-pubsub/issues/413
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"The initial ACK deadline set for the messages received could be too low","articleBody":"Is there a reason that https://github.com/googleapis/python-pubsub/blob/master/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py#L493 calls `self.ack_histogram.percentile(99)` directly rather than using https://github.com/googleapis/python-pubsub/blob/master/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py#L225 which is what the Leaser thread uses for how long it sleeps between updates?\r\n\r\nI think this is causing a bug where the the average message time decrease and so the 99th percentile decreases quicker than the \"sticky\" `ack_deadline` method. The initial ack_deadline is then shorter than the time between Leaser refreshes and the messages expire before the lease is renewed. ","author":{"url":"https://github.com/davidbraden","@type":"Person","name":"davidbraden"},"datePublished":"2021-05-17T10:52:19.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/413/python-pubsub/issues/413"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:55433982-9885-4dd7-ca52-9f3e8c5477d4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8470:7AC27:136CA7D:1AE82BF:6A4DE87E |
| html-safe-nonce | db65a2558501f670a3278a9d4fba8d04305e6c526152e30dd362684b25ff9c22 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDcwOjdBQzI3OjEzNkNBN0Q6MUFFODJCRjo2QTRERTg3RSIsInZpc2l0b3JfaWQiOiI1MDUzMTIyMTg3NjYzMTA4MjIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f94e4212b9ba4c88cd1e040fe944d03d115faccb156e7570f3ea883fc12bfebb |
| hovercard-subject-tag | issue:893205100 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-pubsub/413/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1e35c2036c9f95327191418bee471ee5882a121600a4476ef68dbe82ecb9d410/googleapis/python-pubsub/issues/413 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1e35c2036c9f95327191418bee471ee5882a121600a4476ef68dbe82ecb9d410/googleapis/python-pubsub/issues/413 |
| og:image:alt | Is there a reason that https://github.com/googleapis/python-pubsub/blob/master/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py#L493 calls self.ack_histogram.percentile(99) dir... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | davidbraden |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/python-pubsub git https://github.com/googleapis/python-pubsub.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992581 |
| octolytics-dimension-repository_nwo | googleapis/python-pubsub |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992581 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-pubsub |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width