René's URL Explorer Experiment


Title: unused message arg in Batch.will_accept() · Issue #105 · googleapis/python-pubsub · GitHub

Open Graph Title: unused message arg in Batch.will_accept() · Issue #105 · googleapis/python-pubsub

X Title: unused message arg in Batch.will_accept() · Issue #105 · googleapis/python-pubsub

Description: Looks like message arg is never used by will_accept() method: python-pubsub/google/cloud/pubsub_v1/publisher/_batch/base.py Lines 112 to 136 in cf9e87c def will_accept(self, message): """Return True if the batch is able to accept the mes...

Open Graph Description: Looks like message arg is never used by will_accept() method: python-pubsub/google/cloud/pubsub_v1/publisher/_batch/base.py Lines 112 to 136 in cf9e87c def will_accept(self, message): """Return Tru...

X Description: Looks like message arg is never used by will_accept() method: python-pubsub/google/cloud/pubsub_v1/publisher/_batch/base.py Lines 112 to 136 in cf9e87c def will_accept(self, message): ""&...

Opengraph URL: https://github.com/googleapis/python-pubsub/issues/105

X: @github

direct link

Domain: github.com

Hey, it has json ld scripts: 
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"unused message arg in Batch.will_accept()","articleBody":"Looks like `message` arg is never used by `will_accept()` method:\r\nhttps://github.com/googleapis/python-pubsub/blob/cf9e87c80c0771f3fa6ef784a8d76cb760ad37ef/google/cloud/pubsub_v1/publisher/_batch/base.py#L112-L136\r\n\r\nMost likely it should be deleted to avoid any confusion, but I suppose it should be done with deprecation. `Batch()` is not something pretending to be manually used by users, but who knows.\r\n\r\n@pradn, please, comment","author":{"url":"https://github.com/IlyaFaer","@type":"Person","name":"IlyaFaer"},"datePublished":"2020-05-27T09:32:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/105/python-pubsub/issues/105"}
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5079fb45-ecaa-bd71-dff0-891d540dce2f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCAFA:34AAF2:12FD7BC:19FD7D0:6A4D7242
html-safe-noncecb2762e4f3b2433dff01c4b4940f0f852e6126c14158fcc064ec097258fa8f3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUZBOjM0QUFGMjoxMkZEN0JDOjE5RkQ3RDA6NkE0RDcyNDIiLCJ2aXNpdG9yX2lkIjoiMTA3OTU1MDc4NTEwMjQ0NDE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3a29eaf72869046aa6be4faf0b2a465dc9c5f9bc5f0d1c09ec4410bbda8b00c0
hovercard-subject-tagissue:625536072
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-pubsub/105/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f59d48a309076437b0e1629f3af28c0c1e78346cf6c55824bc93ad16ce4b7a23/googleapis/python-pubsub/issues/105
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f59d48a309076437b0e1629f3af28c0c1e78346cf6c55824bc93ad16ce4b7a23/googleapis/python-pubsub/issues/105
og:image:altLooks like message arg is never used by will_accept() method: python-pubsub/google/cloud/pubsub_v1/publisher/_batch/base.py Lines 112 to 136 in cf9e87c def will_accept(self, message): """Return Tru...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameIlyaFaer
hostnamegithub.com
expected-hostnamegithub.com
Nonec78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e
turbo-cache-controlno-preview
go-importgithub.com/googleapis/python-pubsub git https://github.com/googleapis/python-pubsub.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992581
octolytics-dimension-repository_nwogoogleapis/python-pubsub
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992581
octolytics-dimension-repository_network_root_nwogoogleapis/python-pubsub
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release399fff412f48461d435721c009efc17ea44be72f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-pubsub/issues/105#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fissues%2F105
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-pubsub%2Fissues%2F105
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fpython-pubsub
Reloadhttps://github.com/googleapis/python-pubsub/issues/105
Reloadhttps://github.com/googleapis/python-pubsub/issues/105
Reloadhttps://github.com/googleapis/python-pubsub/issues/105
Please reload this pagehttps://github.com/googleapis/python-pubsub/issues/105
googleapis https://github.com/googleapis
python-pubsubhttps://github.com/googleapis/python-pubsub
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Fork 214 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Star 430 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-pubsub
Code https://github.com/googleapis/python-pubsub
Issues 0 https://github.com/googleapis/python-pubsub/issues
Pull requests 0 https://github.com/googleapis/python-pubsub/pulls
Actions https://github.com/googleapis/python-pubsub/actions
Projects https://github.com/googleapis/python-pubsub/projects
Security and quality 0 https://github.com/googleapis/python-pubsub/security
Insights https://github.com/googleapis/python-pubsub/pulse
Code https://github.com/googleapis/python-pubsub
Issues https://github.com/googleapis/python-pubsub/issues
Pull requests https://github.com/googleapis/python-pubsub/pulls
Actions https://github.com/googleapis/python-pubsub/actions
Projects https://github.com/googleapis/python-pubsub/projects
Security and quality https://github.com/googleapis/python-pubsub/security
Insights https://github.com/googleapis/python-pubsub/pulse
#108https://github.com/googleapis/python-pubsub/pull/108
unused message arg in Batch.will_accept()https://github.com/googleapis/python-pubsub/issues/105#top
#108https://github.com/googleapis/python-pubsub/pull/108
https://github.com/IlyaFaer
api: pubsubIssues related to the googleapis/python-pubsub API.https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
type: cleanupAn internal cleanup or hygiene concern.https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22type%3A%20cleanup%22
https://github.com/IlyaFaer
IlyaFaerhttps://github.com/IlyaFaer
on May 27, 2020https://github.com/googleapis/python-pubsub/issues/105#issue-625536072
python-pubsub/google/cloud/pubsub_v1/publisher/_batch/base.pyhttps://github.com/googleapis/python-pubsub/blob/cf9e87c80c0771f3fa6ef784a8d76cb760ad37ef/google/cloud/pubsub_v1/publisher/_batch/base.py#L112-L136
cf9e87chttps://github.com/googleapis/python-pubsub/commit/cf9e87c80c0771f3fa6ef784a8d76cb760ad37ef
@pradnhttps://github.com/pradn
IlyaFaerhttps://github.com/IlyaFaer
api: pubsubIssues related to the googleapis/python-pubsub API.https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22api%3A%20pubsub%22
type: cleanupAn internal cleanup or hygiene concern.https://github.com/googleapis/python-pubsub/issues?q=state%3Aopen%20label%3A%22type%3A%20cleanup%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.