René's URL Explorer Experiment


Title: fix: make atexit registration conditional on background transport by otorreno · Pull Request #978 · googleapis/python-logging · GitHub

Open Graph Title: fix: make atexit registration conditional on background transport by otorreno · Pull Request #978 · googleapis/python-logging

X Title: fix: make atexit registration conditional on background transport by otorreno · Pull Request #978 · googleapis/python-logging

Description: The background transport fails on Python 3.12 when working with gRPC in case there are messages in the queue when the Python interpreter exits. Making the registration of the atexit callback conditional so that users can circumvent this error by explicitly stopping the logging when their application terminates. We can consider making the default value depend on the Python version at runtime, but it was decided to not change the default behaviour, regardless of the Python version. Fixes googleapis/google-cloud-python#15408 and #855 (if users would setup the logging disabling the atexit hook).

Open Graph Description: The background transport fails on Python 3.12 when working with gRPC in case there are messages in the queue when the Python interpreter exits. Making the registration of the atexit callback condit...

X Description: The background transport fails on Python 3.12 when working with gRPC in case there are messages in the queue when the Python interpreter exits. Making the registration of the atexit callback condit...

Opengraph URL: https://github.com/googleapis/python-logging/pull/978

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ab25fcb0-d99d-aeec-9846-39fadf00c020
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC404:24E3F0:25A4CD:3267AD:6A4D33E8
html-safe-nonce12cbfca309037b3cf34412cd6a951102f17de601b538709e14efa801d413d504
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDA0OjI0RTNGMDoyNUE0Q0Q6MzI2N0FEOjZBNEQzM0U4IiwidmlzaXRvcl9pZCI6Ijg3MDM2MTQ1NTY5NzMxMTg0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac811348cafa31b3159836dd7d77beb5d049f2cf812b542aa6248e5d5b9fe8bc65
hovercard-subject-tagpull_request:2378365839
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/googleapis/python-logging/pull/978/files
twitter:imagehttps://avatars.githubusercontent.com/u/1468827?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1468827?s=400&v=4
og:image:altThe background transport fails on Python 3.12 when working with gRPC in case there are messages in the queue when the Python interpreter exits. Making the registration of the atexit callback condit...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/googleapis/python-logging git https://github.com/googleapis/python-logging.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992562
octolytics-dimension-repository_nwogoogleapis/python-logging
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992562
octolytics-dimension-repository_network_root_nwogoogleapis/python-logging
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-logging/pull/978/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fpull%2F978%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fpull%2F978%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=googleapis%2Fpython-logging
Reloadhttps://github.com/googleapis/python-logging/pull/978/files
Reloadhttps://github.com/googleapis/python-logging/pull/978/files
Reloadhttps://github.com/googleapis/python-logging/pull/978/files
Please reload this pagehttps://github.com/googleapis/python-logging/pull/978/files
googleapis https://github.com/googleapis
python-logginghttps://github.com/googleapis/python-logging
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging
Fork 59 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging
Star 142 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging
Code https://github.com/googleapis/python-logging
Issues 0 https://github.com/googleapis/python-logging/issues
Pull requests 0 https://github.com/googleapis/python-logging/pulls
Actions https://github.com/googleapis/python-logging/actions
Projects https://github.com/googleapis/python-logging/projects
Security and quality 0 https://github.com/googleapis/python-logging/security
Insights https://github.com/googleapis/python-logging/pulse
Code https://github.com/googleapis/python-logging
Issues https://github.com/googleapis/python-logging/issues
Pull requests https://github.com/googleapis/python-logging/pulls
Actions https://github.com/googleapis/python-logging/actions
Projects https://github.com/googleapis/python-logging/projects
Security and quality https://github.com/googleapis/python-logging/security
Insights https://github.com/googleapis/python-logging/pulse
otorrenohttps://github.com/otorreno
googleapis:mainhttps://github.com/googleapis/python-logging/tree/main
otorreno:fix/atexit_conditionalhttps://github.com/otorreno/python-logging/tree/fix/atexit_conditional
Conversation 2 https://github.com/googleapis/python-logging/pull/978
Commits 1 https://github.com/googleapis/python-logging/pull/978/commits
Checks 0 https://github.com/googleapis/python-logging/pull/978/checks
Files changed https://github.com/googleapis/python-logging/pull/978/files
Please reload this pagehttps://github.com/googleapis/python-logging/pull/978/files
fix: make atexit registration conditional on background transport https://github.com/googleapis/python-logging/pull/978/files#top
Show all changes 1 commit https://github.com/googleapis/python-logging/pull/978/files
0ff4b65 fix: make atexit registration conditional on background transport otorreno Mar 7, 2025 https://github.com/googleapis/python-logging/pull/978/commits/0ff4b65abd6275651c4d31ff6662735a5b1c457b
Clear filters https://github.com/googleapis/python-logging/pull/978/files
Please reload this pagehttps://github.com/googleapis/python-logging/pull/978/files
Please reload this pagehttps://github.com/googleapis/python-logging/pull/978/files
handlers.py https://github.com/googleapis/python-logging/pull/978/files#diff-b4cc697f3b7b81a94e0a2fa98c5aae133bed9b8e7f32bc0ec54291a8f26816cc
background_thread.py https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
test_background_thread.py https://github.com/googleapis/python-logging/pull/978/files#diff-6f0f0bcebfa7fe6f3ea805387f1da2c90499603912f35b4b0e6bf192414f21ac
google/cloud/logging_v2/handlers/handlers.pyhttps://github.com/googleapis/python-logging/pull/978/files#diff-b4cc697f3b7b81a94e0a2fa98c5aae133bed9b8e7f32bc0ec54291a8f26816cc
View file https://github.com/otorreno/python-logging/blob/0ff4b65abd6275651c4d31ff6662735a5b1c457b/google/cloud/logging_v2/handlers/handlers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-logging/pull/978/{{ revealButtonHref }}
https://github.com/googleapis/python-logging/pull/978/files#diff-b4cc697f3b7b81a94e0a2fa98c5aae133bed9b8e7f32bc0ec54291a8f26816cc
https://github.com/googleapis/python-logging/pull/978/files#diff-b4cc697f3b7b81a94e0a2fa98c5aae133bed9b8e7f32bc0ec54291a8f26816cc
google/cloud/logging_v2/handlers/transports/background_thread.pyhttps://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
View file https://github.com/otorreno/python-logging/blob/0ff4b65abd6275651c4d31ff6662735a5b1c457b/google/cloud/logging_v2/handlers/transports/background_thread.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-logging/pull/978/{{ revealButtonHref }}
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
https://github.com/googleapis/python-logging/pull/978/files#diff-db3edb2ff8b12f988059cb305379c86203136e9b37d13d832f67c1fe5bda998c
tests/unit/handlers/transports/test_background_thread.pyhttps://github.com/googleapis/python-logging/pull/978/files#diff-6f0f0bcebfa7fe6f3ea805387f1da2c90499603912f35b4b0e6bf192414f21ac
View file https://github.com/otorreno/python-logging/blob/0ff4b65abd6275651c4d31ff6662735a5b1c457b/tests/unit/handlers/transports/test_background_thread.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-logging/pull/978/{{ revealButtonHref }}
https://github.com/googleapis/python-logging/pull/978/files#diff-6f0f0bcebfa7fe6f3ea805387f1da2c90499603912f35b4b0e6bf192414f21ac
https://github.com/googleapis/python-logging/pull/978/files#diff-6f0f0bcebfa7fe6f3ea805387f1da2c90499603912f35b4b0e6bf192414f21ac
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.