| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:13ffa410-504d-6a91-dbbb-5f58b5d46304 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA5E:291A44:3DAA4B:53BF32:6A5145C3 |
| html-safe-nonce | 6333a0cd7a5245eada4e73e99cf83fec650c215a756397dc54128e0c81b7d11e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTVFOjI5MUE0NDozREFBNEI6NTNCRjMyOjZBNTE0NUMzIiwidmlzaXRvcl9pZCI6IjM2NjAwODkyODIyNDMxNTEyOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2fbef052d6d1f6af87c616e808c210c421b71eae91c248a7f6662bc20ce633e1 |
| hovercard-subject-tag | pull_request:1097994353 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-logging/654/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cbf4abe54bfcf8ccf86ad531db1a574715607ac24475852820b2d2b712292dec/googleapis/python-logging/pull/654 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cbf4abe54bfcf8ccf86ad531db1a574715607ac24475852820b2d2b712292dec/googleapis/python-logging/pull/654 |
| og:image:alt | Fixes #652
Based on this original PR, with some unit tests added (thanks @mat105!) |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | daniel-sanche |
| hostname | github.com |
| expected-hostname | github.com |
| None | e840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/python-logging git https://github.com/googleapis/python-logging.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992562 |
| octolytics-dimension-repository_nwo | googleapis/python-logging |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992562 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-logging |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b78565f6aa43cc5323c9935ec11b22cca7bb0a62 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/python-logging/issues/654#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fpull%2F654 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fpull%2F654 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-logging |
| Reload | https://github.com/googleapis/python-logging/issues/654 |
| Reload | https://github.com/googleapis/python-logging/issues/654 |
| Reload | https://github.com/googleapis/python-logging/issues/654 |
| Please reload this page | https://github.com/googleapis/python-logging/issues/654 |
|
googleapis
| https://github.com/googleapis |
| python-logging | https://github.com/googleapis/python-logging |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging |
|
Fork
59
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging |
|
Star
142
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging |
|
Code
| https://github.com/googleapis/python-logging |
|
Issues
0
| https://github.com/googleapis/python-logging/issues |
|
Pull requests
0
| https://github.com/googleapis/python-logging/pulls |
|
Actions
| https://github.com/googleapis/python-logging/actions |
|
Projects
| https://github.com/googleapis/python-logging/projects |
|
Security and quality
0
| https://github.com/googleapis/python-logging/security |
|
Insights
| https://github.com/googleapis/python-logging/pulse |
|
Code
| https://github.com/googleapis/python-logging |
|
Issues
| https://github.com/googleapis/python-logging/issues |
|
Pull requests
| https://github.com/googleapis/python-logging/pulls |
|
Actions
| https://github.com/googleapis/python-logging/actions |
|
Projects
| https://github.com/googleapis/python-logging/projects |
|
Security and quality
| https://github.com/googleapis/python-logging/security |
|
Insights
| https://github.com/googleapis/python-logging/pulse |
| daniel-sanche | https://github.com/daniel-sanche |
| main | https://github.com/googleapis/python-logging/tree/main |
| fix_json_fields_sideeffects | https://github.com/googleapis/python-logging/tree/fix_json_fields_sideeffects |
| Conversation | https://github.com/googleapis/python-logging/pull/654 |
| Commits4 (4) | https://github.com/googleapis/python-logging/pull/654/commits |
| Checks | https://github.com/googleapis/python-logging/pull/654/checks |
| Files changed | https://github.com/googleapis/python-logging/pull/654/files |
| fix: json fields dictionary has modification side effect | https://github.com/googleapis/python-logging/issues/654#top |
| daniel-sanche | https://github.com/daniel-sanche |
| main | https://github.com/googleapis/python-logging/tree/main |
| fix_json_fields_sideeffects | https://github.com/googleapis/python-logging/tree/fix_json_fields_sideeffects |
|
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| Oct 24, 2022 | https://github.com/googleapis/python-logging/issues/654#issue-1421417870 |
| #652 | https://github.com/googleapis/python-logging/issues/652 |
| original PR | https://github.com/googleapis/python-logging/pull/653 |
| @mat105 | https://github.com/mat105 |
| Please reload this page | https://github.com/googleapis/python-logging/issues/654 |
| daniel-sanche | https://github.com/daniel-sanche |
| October 24, 2022 13:35 | https://github.com/googleapis/python-logging/issues/654#commits-pushed-25eb3a7 |
|
| https://github.com/daniel-sanche |
| work on a copy of json_fields | https://github.com/googleapis/python-logging/pull/654/commits/25eb3a7e045921bdcaede05d6b184552b40670e2 |
| 25eb3a7 | https://github.com/googleapis/python-logging/pull/654/commits/25eb3a7e045921bdcaede05d6b184552b40670e2 |
|
| https://github.com/daniel-sanche |
| added tests | https://github.com/googleapis/python-logging/pull/654/commits/8dd7a80b49cf347e03cf3f31e26dd8bbca397f79 |
| 8dd7a80 | https://github.com/googleapis/python-logging/pull/654/commits/8dd7a80b49cf347e03cf3f31e26dd8bbca397f79 |
|
| https://github.com/daniel-sanche |
| fixed lint | https://github.com/googleapis/python-logging/pull/654/commits/c48961cb2b925d2503b64c97b82f1f2a161460d4 |
| c48961c | https://github.com/googleapis/python-logging/pull/654/commits/c48961cb2b925d2503b64c97b82f1f2a161460d4 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| October 24, 2022 20:40 | https://github.com/googleapis/python-logging/issues/654#event-7657497389 |
| https://github.com/apps/product-auto-label |
| product-auto-label | https://github.com/apps/product-auto-label |
|
size: s
| https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22 |
| Oct 24, 2022 | https://github.com/googleapis/python-logging/issues/654#event-7657497927 |
| https://github.com/apps/blunderbuss-gcf |
| blunderbuss-gcf | https://github.com/apps/blunderbuss-gcf |
| losalex | https://github.com/losalex |
| Oct 24, 2022 | https://github.com/googleapis/python-logging/issues/654#event-7657498015 |
| https://github.com/apps/product-auto-label |
| product-auto-label | https://github.com/apps/product-auto-label |
|
api: logging
| https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22 |
| Oct 24, 2022 | https://github.com/googleapis/python-logging/issues/654#event-7657498308 |
| https://github.com/losalex |
| losalex | https://github.com/losalex |
|
Oct 24, 2022
| https://github.com/googleapis/python-logging/issues/654#pullrequestreview-1153946374 |
|
View reviewed changes
| https://github.com/googleapis/python-logging/pull/654/files/c48961cb2b925d2503b64c97b82f1f2a161460d4 |
| google/cloud/logging_v2/handlers/handlers.py | https://github.com/googleapis/python-logging/pull/654/files/c48961cb2b925d2503b64c97b82f1f2a161460d4#diff-b4cc697f3b7b81a94e0a2fa98c5aae133bed9b8e7f32bc0ec54291a8f26816cc |
| Please reload this page | https://github.com/googleapis/python-logging/issues/654 |
|
| https://github.com/daniel-sanche |
| Merge branch 'main' into fix_json_fields_sideeffects | https://github.com/googleapis/python-logging/pull/654/commits/789e362c07a4d5e5e5ca6770aa362a516bf6ba3a |
| 789e362 | https://github.com/googleapis/python-logging/pull/654/commits/789e362c07a4d5e5e5ca6770aa362a516bf6ba3a |
| https://github.com/losalex |
| losalex | https://github.com/losalex |
|
Oct 25, 2022
| https://github.com/googleapis/python-logging/issues/654#pullrequestreview-1153979693 |
|
View reviewed changes
| https://github.com/googleapis/python-logging/pull/654/files/789e362c07a4d5e5e5ca6770aa362a516bf6ba3a |
| losalex | https://github.com/losalex |
| https://github.com/googleapis/python-logging/issues/654#pullrequestreview-1153979693 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-logging/issues/654 |
| https://github.com/losalex |
| losalex | https://github.com/losalex |
| Oct 25, 2022 | https://github.com/googleapis/python-logging/issues/654#event-7659320513 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| a62a0d6 | https://github.com/googleapis/python-logging/commit/a62a0d66cb8c07e617636e5ed54961f5e28164ae |
| Oct 25, 2022 | https://github.com/googleapis/python-logging/pull/654#event-7665144745 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| October 25, 2022 16:13 | https://github.com/googleapis/python-logging/issues/654#event-7665144922 |
| https://github.com/apps/release-please |
| release-please | https://github.com/apps/release-please |
|
Oct 25, 2022
| https://github.com/googleapis/python-logging/issues/654#ref-pullrequest-1400350762 |
|
chore(main): release 3.3.0
#645
| https://github.com/googleapis/python-logging/pull/645 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/python-logging/issues/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fpull%2F654 |
|
| https://github.com/losalex |
|
losalex
| https://github.com/losalex |
|
| https://github.com/googleapis/python-logging/pull/654/files/789e362c07a4d5e5e5ca6770aa362a516bf6ba3a |
|
| https://github.com/losalex |
|
losalex
| https://github.com/losalex |
|
api: logging
| https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22 |
|
size: s
| https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22 |
|
Generate a copy of json_fields before adding message
| https://github.com/googleapis/python-logging/issues/652 |
| Please reload this page | https://github.com/googleapis/python-logging/issues/654 |
|
| https://github.com/daniel-sanche |
|
| https://github.com/losalex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |