René's URL Explorer Experiment


Title: structured logging fails to create valid json in some cases · Issue #331 · googleapis/python-logging · GitHub

Open Graph Title: structured logging fails to create valid json in some cases · Issue #331 · googleapis/python-logging

X Title: structured logging fails to create valid json in some cases · Issue #331 · googleapis/python-logging

Description: I think I found a bug in v3.0.0 branch, causing invalid json being generated, thus having no jsonPayload in GCP Logging and instead receiving a textMessage. Environment details code deployed on GCP Cloud Run using library version from v3...

Open Graph Description: I think I found a bug in v3.0.0 branch, causing invalid json being generated, thus having no jsonPayload in GCP Logging and instead receiving a textMessage. Environment details code deployed on GCP...

X Description: I think I found a bug in v3.0.0 branch, causing invalid json being generated, thus having no jsonPayload in GCP Logging and instead receiving a textMessage. Environment details code deployed on GCP...

Opengraph URL: https://github.com/googleapis/python-logging/issues/331

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"structured logging fails to create valid json in some cases","articleBody":"I think I found a bug in v3.0.0 branch, causing invalid json being generated, thus having no jsonPayload in GCP Logging and instead receiving a textMessage.\r\n\r\n#### Environment details\r\n\r\n  - code deployed on GCP Cloud Run\r\n  - using library version from v3.0.0 branch\r\n \r\n#### Steps to reproduce\r\n\r\n1. use structured logging according to examples\r\n2. log any dict with double ending braces ( '{ \"x\": { \"y\" : \"z\" }}')\r\n3. see https://github.com/googleapis/python-logging/blob/3d03805ff9ab7cdf16c41f67a7453b2d8f5c70ce/google/cloud/logging_v2/handlers/structured_log.py#L69 using lstrip and rstrip, causing removal of both braces at the end\r\n4. receive textMessage instead of jsonPayload in GCP Logging, as invalid json was produced.\r\n\r\n#### Possible fix\r\n\r\nI am not a python programmer, so you might find better solutions, however, this is what worked for me:\r\n```\r\nif isinstance(record.msg, collections.abc.Mapping):\r\n    encoded_msg = json.dumps(record.msg, ensure_ascii=False)\r\n    payload_clean = encoded_msg.lstrip().rstrip() // remove whitespace\r\n    # strip out open and close parentheses\r\n    if payload_clean.startswith(\"{\"):\r\n        payload_clean = payload_clean[1:] // strip leftmost character\r\n    if payload_clean.endswith(\"}\"):\r\n        payload_clean = payload_clean[:-1] // strip rightmost character\r\n    payload = payload_clean + \",\"\r\n```\r\n\r\nThanks a lot for bringing structured (json) logging into the lib!","author":{"url":"https://github.com/EricLacherSolera","@type":"Person","name":"EricLacherSolera"},"datePublished":"2021-06-21T11:03:16.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/331/python-logging/issues/331"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bc4e5fa3-ec67-3620-f6fd-7426390e66fb
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB804:34DA5A:3DB5548:578EF30:6A4FB10D
html-safe-nonce0b58ae6cf33624cd59b17f5ba06369c4b651e8c1014b474f5b19743c9178e285
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODA0OjM0REE1QTozREI1NTQ4OjU3OEVGMzA6NkE0RkIxMEQiLCJ2aXNpdG9yX2lkIjoiNjIxNzA1NzkxNjg1NzMzMTk4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac60eaaed9359d0175ef743e1636368725ffd82ae95be4d2f42c0dd7e9aabc3771
hovercard-subject-tagissue:926097751
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-logging/331/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7228721f3e18f88f1e649b52a52e657debdf9b378736d02ae89f264f0255c926/googleapis/python-logging/issues/331
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7228721f3e18f88f1e649b52a52e657debdf9b378736d02ae89f264f0255c926/googleapis/python-logging/issues/331
og:image:altI think I found a bug in v3.0.0 branch, causing invalid json being generated, thus having no jsonPayload in GCP Logging and instead receiving a textMessage. Environment details code deployed on GCP...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameEricLacherSolera
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
go-importgithub.com/googleapis/python-logging git https://github.com/googleapis/python-logging.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992562
octolytics-dimension-repository_nwogoogleapis/python-logging
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992562
octolytics-dimension-repository_network_root_nwogoogleapis/python-logging
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-logging/issues/331#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fissues%2F331
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-logging%2Fissues%2F331
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fpython-logging
Reloadhttps://github.com/googleapis/python-logging/issues/331
Reloadhttps://github.com/googleapis/python-logging/issues/331
Reloadhttps://github.com/googleapis/python-logging/issues/331
Please reload this pagehttps://github.com/googleapis/python-logging/issues/331
googleapis https://github.com/googleapis
python-logginghttps://github.com/googleapis/python-logging
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging
Fork 59 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging
Star 142 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-logging
Code https://github.com/googleapis/python-logging
Issues 0 https://github.com/googleapis/python-logging/issues
Pull requests 0 https://github.com/googleapis/python-logging/pulls
Actions https://github.com/googleapis/python-logging/actions
Projects https://github.com/googleapis/python-logging/projects
Security and quality 0 https://github.com/googleapis/python-logging/security
Insights https://github.com/googleapis/python-logging/pulse
Code https://github.com/googleapis/python-logging
Issues https://github.com/googleapis/python-logging/issues
Pull requests https://github.com/googleapis/python-logging/pulls
Actions https://github.com/googleapis/python-logging/actions
Projects https://github.com/googleapis/python-logging/projects
Security and quality https://github.com/googleapis/python-logging/security
Insights https://github.com/googleapis/python-logging/pulse
#339https://github.com/googleapis/python-logging/pull/339
structured logging fails to create valid json in some caseshttps://github.com/googleapis/python-logging/issues/331#top
#339https://github.com/googleapis/python-logging/pull/339
https://github.com/daniel-sanche
api: loggingIssues related to the googleapis/python-logging API.https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
priority: p2Moderately-important priority. Fix may not be included in next release.https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
v3.0.0 Breakinghttps://github.com/googleapis/python-logging/milestone/1
https://github.com/EricLacherSolera
EricLacherSolerahttps://github.com/EricLacherSolera
on Jun 21, 2021https://github.com/googleapis/python-logging/issues/331#issue-926097751
python-logging/google/cloud/logging_v2/handlers/structured_log.pyhttps://github.com/googleapis/python-logging/blob/3d03805ff9ab7cdf16c41f67a7453b2d8f5c70ce/google/cloud/logging_v2/handlers/structured_log.py#L69
3d03805https://github.com/googleapis/python-logging/commit/3d03805ff9ab7cdf16c41f67a7453b2d8f5c70ce
daniel-sanchehttps://github.com/daniel-sanche
api: loggingIssues related to the googleapis/python-logging API.https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22api%3A%20logging%22
priority: p2Moderately-important priority. Fix may not be included in next release.https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.https://github.com/googleapis/python-logging/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%22
v3.0.0 Breakinghttps://github.com/googleapis/python-logging/milestone/1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.