René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Logging: don't import grpc if grpc disabled","articleBody":"I noticed the Stackdriver module supports usage with grpc installed, which is great. However it currently still tries to import _gapic even if grpc usage is explicitly disabled via env var. This causes some additional latency for cli \u0026 serverless usage.\r\n\r\n```\r\n$ cat x.py\r\nimport time\r\nimport sys\r\n\r\n\r\ndef main():\r\n    mcount = len(sys.modules)\r\n    t = time.time()\r\n    from google.cloud.logging import Client\r\n    print(\"modules:%d %0.2f sec\" % (\r\n        len(sys.modules) - mcount, time.time() - t))\r\n\r\n\r\nif __name__ == '__main__':\r\n    main()\r\n```\r\n\r\nso this tries two tests, one with the default google.cloud.logging.client imports, and one where the try/except around the _gapic imports is replaced with the except clause ie modification of these lines\r\nhttps://github.com/googleapis/google-cloud-python/blob/master/logging/google/cloud/logging/client.py#L21\r\n\r\n## default import \r\n```\r\n(custodian) bash-3.2$ python x.py \r\nmodules:576 0.51 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:576 0.50 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:576 0.44 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:576 0.47 sec\r\n```\r\n\r\n## Disable import of _gapi in\r\n\r\n```\r\n(custodian) bash-3.2$ python x.py \r\nmodules:510 0.38 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:510 0.37 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:510 0.37 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:510 0.38 sec\r\n(custodian) bash-3.2$ python x.py \r\nmodules:510 0.37 sec\r\n```\r\n\r\nso baseline improvement for cli / serverless execution of ~100ms. for serverless environments this effect is more pronounced I've noticed.\r\n\r\nIdeally the DISABLE_GRPC environment could be checked before attempting to import the _gapic modules.","author":{"url":"https://github.com/kapilt","@type":"Person","name":"kapilt"},"datePublished":"2018-12-24T17:51:04.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/12/python-logging/issues/12"}