| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:03006d78-5bc7-f575-60b3-544ce883520d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5A6:74B62:8D44F1:C0CE78:6A4DD94E |
| html-safe-nonce | da4fd9d4c134bab3b53a2d2d17bfd491e1dedaa7c7f14c8cf0e0e8bae49d8690 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUE2Ojc0QjYyOjhENDRGMTpDMENFNzg6NkE0REQ5NEUiLCJ2aXNpdG9yX2lkIjoiMTk5OTMwODg3MTUwNDM1MzYxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ab5dbbe8fe321af906cf051efb8c089c6c1b5454cdb09f61086d2a46b06c36c9 |
| hovercard-subject-tag | pull_request:2510983404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-firestore/1045/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5430d2b91d209ce5682fc1e7086cfe6c8aeb2c49677498261abe48454797e746/googleapis/python-firestore/pull/1045 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5430d2b91d209ce5682fc1e7086cfe6c8aeb2c49677498261abe48454797e746/googleapis/python-firestore/pull/1045 |
| og:image:alt | I updated the types of a few things in async_transactional to ensure that when a function wrapped with @async_transactional is called:
the return type of the inner function is correctly detected ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jekozyra |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/python-firestore git https://github.com/googleapis/python-firestore.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992533 |
| octolytics-dimension-repository_nwo | googleapis/python-firestore |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992533 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-firestore |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/python-firestore/pull/1045#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-firestore%2Fpull%2F1045 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-firestore%2Fpull%2F1045 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-firestore |
| Reload | https://github.com/googleapis/python-firestore/pull/1045 |
| Reload | https://github.com/googleapis/python-firestore/pull/1045 |
| Reload | https://github.com/googleapis/python-firestore/pull/1045 |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
|
googleapis
| https://github.com/googleapis |
| python-firestore | https://github.com/googleapis/python-firestore |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-firestore |
|
Fork
85
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-firestore |
|
Star
244
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-firestore |
|
Code
| https://github.com/googleapis/python-firestore |
|
Issues
0
| https://github.com/googleapis/python-firestore/issues |
|
Pull requests
0
| https://github.com/googleapis/python-firestore/pulls |
|
Actions
| https://github.com/googleapis/python-firestore/actions |
|
Projects
| https://github.com/googleapis/python-firestore/projects |
|
Security and quality
0
| https://github.com/googleapis/python-firestore/security |
|
Insights
| https://github.com/googleapis/python-firestore/pulse |
|
Code
| https://github.com/googleapis/python-firestore |
|
Issues
| https://github.com/googleapis/python-firestore/issues |
|
Pull requests
| https://github.com/googleapis/python-firestore/pulls |
|
Actions
| https://github.com/googleapis/python-firestore/actions |
|
Projects
| https://github.com/googleapis/python-firestore/projects |
|
Security and quality
| https://github.com/googleapis/python-firestore/security |
|
Insights
| https://github.com/googleapis/python-firestore/pulse |
| jekozyra | https://github.com/jekozyra |
| googleapis:main | https://github.com/googleapis/python-firestore/tree/main |
| poggiolabs:jillian/update-types-for-async-transactions | https://github.com/poggiolabs/python-firestore/tree/jillian/update-types-for-async-transactions |
| Conversation | https://github.com/googleapis/python-firestore/pull/1045 |
| Commits5 (5) | https://github.com/googleapis/python-firestore/pull/1045/commits |
| Checks | https://github.com/googleapis/python-firestore/pull/1045/checks |
| Files changed | https://github.com/googleapis/python-firestore/pull/1045/files |
| fix: update the async transactional types to not require extra awaits | https://github.com/googleapis/python-firestore/pull/1045#top |
| jekozyra | https://github.com/jekozyra |
| googleapis:main | https://github.com/googleapis/python-firestore/tree/main |
| poggiolabs:jillian/update-types-for-async-transactions | https://github.com/poggiolabs/python-firestore/tree/jillian/update-types-for-async-transactions |
|
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| May 10, 2025 | https://github.com/googleapis/python-firestore/pull/1045#issue-3053663643 |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| bug/issue | https://github.com/googleapis/python-firestore/issues/new/choose |
| #1044 | https://github.com/googleapis/python-firestore/issues/1044 |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| https://github.com/apps/product-auto-label |
| product-auto-label | https://github.com/apps/product-auto-label |
|
size: s
| https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22 |
|
api: firestore
| https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22 |
| May 10, 2025 | https://github.com/googleapis/python-firestore/pull/1045#event-17599948211 |
|
| https://github.com/jekozyra |
| fix: update the async transactional types to not require extra awaits | https://github.com/googleapis/python-firestore/pull/1045/commits/ca2340513a5ef1cd82d7af0bd8f066f16367887c |
| ca23405 | https://github.com/googleapis/python-firestore/pull/1045/commits/ca2340513a5ef1cd82d7af0bd8f066f16367887c |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| force-pushed | https://github.com/googleapis/python-firestore/compare/b216867ed152317d24f24a25395f8bb3b8abb101..ca2340513a5ef1cd82d7af0bd8f066f16367887c |
| b216867 | https://github.com/googleapis/python-firestore/commit/b216867ed152317d24f24a25395f8bb3b8abb101 |
| ca23405 | https://github.com/googleapis/python-firestore/commit/ca2340513a5ef1cd82d7af0bd8f066f16367887c |
|
Compare
| https://github.com/googleapis/python-firestore/compare/b216867ed152317d24f24a25395f8bb3b8abb101..ca2340513a5ef1cd82d7af0bd8f066f16367887c |
| May 10, 2025 04:59 | https://github.com/googleapis/python-firestore/pull/1045#event-17600056085 |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| May 10, 2025 04:59 | https://github.com/googleapis/python-firestore/pull/1045#event-17600059099 |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| May 10, 2025 04:59 | https://github.com/googleapis/python-firestore/pull/1045#event-17600059115 |
| https://github.com/apps/blunderbuss-gcf |
| blunderbuss-gcf | https://github.com/apps/blunderbuss-gcf |
| wu-hui | https://github.com/wu-hui |
| May 10, 2025 | https://github.com/googleapis/python-firestore/pull/1045#event-17600059223 |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| May 15, 2025 | https://github.com/googleapis/python-firestore/pull/1045#issuecomment-2884931821 |
| @wu-hui | https://github.com/wu-hui |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| https://github.com/parthea |
| parthea | https://github.com/parthea |
| gkevinzheng | https://github.com/gkevinzheng |
| May 16, 2025 | https://github.com/googleapis/python-firestore/pull/1045#event-17691448538 |
| https://github.com/parthea |
| parthea | https://github.com/parthea |
| gkevinzheng | https://github.com/gkevinzheng |
| May 16, 2025 16:12 | https://github.com/googleapis/python-firestore/pull/1045#event-17691449318 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
|
May 21, 2025
| https://github.com/googleapis/python-firestore/pull/1045#pullrequestreview-2859262872 |
|
View reviewed changes
| https://github.com/googleapis/python-firestore/pull/1045/files/ca2340513a5ef1cd82d7af0bd8f066f16367887c |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
|
May 21, 2025
| https://github.com/googleapis/python-firestore/pull/1045#pullrequestreview-2859267757 |
|
View reviewed changes
| https://github.com/googleapis/python-firestore/pull/1045/files/ca2340513a5ef1cd82d7af0bd8f066f16367887c |
| google/cloud/firestore_v1/async_transaction.py | https://github.com/googleapis/python-firestore/pull/1045/files/ca2340513a5ef1cd82d7af0bd8f066f16367887c#diff-258dcc662ba73d94265ca2af87f53e8813b0341b58cccf1a3dc44e35e357c1f1 |
| daniel-sanche | https://github.com/daniel-sanche |
| May 21, 2025 | https://github.com/googleapis/python-firestore/pull/1045#discussion_r2101270828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| jekozyra | https://github.com/jekozyra |
| May 22, 2025 | https://github.com/googleapis/python-firestore/pull/1045#discussion_r2101616524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| daniel-sanche | https://github.com/daniel-sanche |
| May 22, 2025 | https://github.com/googleapis/python-firestore/pull/1045#discussion_r2103563010 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| jekozyra | https://github.com/jekozyra |
| May 29, 2025 | https://github.com/googleapis/python-firestore/pull/1045#discussion_r2113181016 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| daniel-sanche | https://github.com/daniel-sanche |
| Jun 5, 2025 | https://github.com/googleapis/python-firestore/pull/1045#discussion_r2130383441 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| short section in the CONTRIBUTING file | https://github.com/googleapis/python-firestore/pull/1045 |
| pyenv | https://github.com/pyenv/pyenv |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| jekozyra | https://github.com/jekozyra |
| Jun 6, 2025 | https://github.com/googleapis/python-firestore/pull/1045#discussion_r2133076855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| wu-hui | https://github.com/wu-hui |
| gkevinzheng | https://github.com/gkevinzheng |
| May 21, 2025 | https://github.com/googleapis/python-firestore/pull/1045#event-17761789516 |
| jekozyra | https://github.com/jekozyra |
| May 21, 2025 20:51 | https://github.com/googleapis/python-firestore/pull/1045#commits-pushed-c0e1446 |
|
| https://github.com/jekozyra |
| add typing extensions | https://github.com/googleapis/python-firestore/pull/1045/commits/c0e1446d57e51924fe28b5f93647dc869404f1c2 |
| c0e1446 | https://github.com/googleapis/python-firestore/pull/1045/commits/c0e1446d57e51924fe28b5f93647dc869404f1c2 |
|
| https://github.com/jekozyra |
| python <3.10 compat | https://github.com/googleapis/python-firestore/pull/1045/commits/a630701e28c84d58d558881f393d148274a574a6 |
| a630701 | https://github.com/googleapis/python-firestore/pull/1045/commits/a630701e28c84d58d558881f393d148274a574a6 |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| daniel-sanche | https://github.com/daniel-sanche |
| stale review | https://github.com/googleapis/python-firestore/pull/1045#pullrequestreview-2859262872 |
| 69ff68b | https://github.com/googleapis/python-firestore/commit/69ff68be006e32340ff064c2a8cd7e00d51c2b33 |
| May 28, 2025 15:55 | https://github.com/googleapis/python-firestore/pull/1045#event-17853890823 |
|
| https://github.com/jekozyra |
| use a protocol | https://github.com/googleapis/python-firestore/pull/1045/commits/576a8a8e85d68eac15fb94402422912b4be6ede9 |
| 576a8a8 | https://github.com/googleapis/python-firestore/pull/1045/commits/576a8a8e85d68eac15fb94402422912b4be6ede9 |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| force-pushed | https://github.com/googleapis/python-firestore/compare/69ff68be006e32340ff064c2a8cd7e00d51c2b33..576a8a8e85d68eac15fb94402422912b4be6ede9 |
| 69ff68b | https://github.com/googleapis/python-firestore/commit/69ff68be006e32340ff064c2a8cd7e00d51c2b33 |
| 576a8a8 | https://github.com/googleapis/python-firestore/commit/576a8a8e85d68eac15fb94402422912b4be6ede9 |
|
Compare
| https://github.com/googleapis/python-firestore/compare/69ff68be006e32340ff064c2a8cd7e00d51c2b33..576a8a8e85d68eac15fb94402422912b4be6ede9 |
| May 29, 2025 05:06 | https://github.com/googleapis/python-firestore/pull/1045#event-17861806826 |
|
| https://github.com/jekozyra |
| Merge branch 'main' into jillian/update-types-for-async-transactions | https://github.com/googleapis/python-firestore/pull/1045/commits/68118b70bc7ee8c6827df657b91d80f770ae7567 |
| 68118b7 | https://github.com/googleapis/python-firestore/pull/1045/commits/68118b70bc7ee8c6827df657b91d80f770ae7567 |
| https://github.com/jekozyra |
| jekozyra | https://github.com/jekozyra |
| daniel-sanche | https://github.com/daniel-sanche |
| May 29, 2025 18:59 | https://github.com/googleapis/python-firestore/pull/1045#event-17873697736 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
|
Jun 11, 2025
| https://github.com/googleapis/python-firestore/pull/1045#ref-pullrequest-3135093190 |
|
fix: update the async transactional types
#1066
| https://github.com/googleapis/python-firestore/pull/1066 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| Jun 17, 2025 | https://github.com/googleapis/python-firestore/pull/1045#issuecomment-2981981475 |
| #1066 | https://github.com/googleapis/python-firestore/pull/1066 |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
| https://github.com/daniel-sanche |
| daniel-sanche | https://github.com/daniel-sanche |
| Jun 17, 2025 | https://github.com/googleapis/python-firestore/pull/1045#event-18199139026 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/python-firestore/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-firestore%2Fpull%2F1045 |
|
| https://github.com/gkevinzheng |
|
gkevinzheng
| https://github.com/gkevinzheng |
|
| https://github.com/daniel-sanche |
|
daniel-sanche
| https://github.com/daniel-sanche |
|
| https://github.com/daniel-sanche |
|
daniel-sanche
| https://github.com/daniel-sanche |
|
api: firestore
| https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22 |
|
size: s
| https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22size%3A%20s%22 |
|
The type of async_transactional is incorrect
| https://github.com/googleapis/python-firestore/issues/1044 |
| Please reload this page | https://github.com/googleapis/python-firestore/pull/1045 |
|
| https://github.com/jekozyra |
|
| https://github.com/daniel-sanche |
|
| https://github.com/wu-hui |
|
| https://github.com/gkevinzheng |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |