Title: `google.cloud.firestore` lacks packaged typing · Issue #447 · googleapis/python-firestore · GitHub
Open Graph Title: `google.cloud.firestore` lacks packaged typing · Issue #447 · googleapis/python-firestore
X Title: `google.cloud.firestore` lacks packaged typing · Issue #447 · googleapis/python-firestore
Description: Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only distributions. The code should be refactore...
Open Graph Description: Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only dis...
X Description: Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only dis...
Opengraph URL: https://github.com/googleapis/python-firestore/issues/447
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`google.cloud.firestore` lacks packaged typing","articleBody":"Hi.\r\n`google.cloud.firestore` does not have types via [PEP561](https://www.python.org/dev/peps/pep-0561/)\r\n`google.cloud.firestore_v1` and friends do.\r\n\r\nPer the PEP:\r\n```\r\nThis PEP does not support distributing typing information as part of module-only distributions. The code should be refactored into a package-based distribution and indicate that the package supports typing as described above.\r\n```\r\n\r\nYou'll have to refactor `firestore.py` into a directory structure\r\n```\r\ngoogle/\r\n cloud/\r\n firestore/\r\n __init__.py\r\n py.typed \r\n```\r\n\r\nRepro steps:\r\n\r\n```python\r\n# ~/test/test.py\r\n# firestore doesn't have py.typed yet - only firestore_v1 has\r\nfrom google.cloud.firestore import AsyncClient\r\nfrom google.cloud.firestore_v1 import AsyncClient\r\n```\r\n\r\n```\r\npython3 -m venv venv\r\nsource venv/bin/activate\r\npip install google-cloud-firestore\r\n# or `pip install -e ~/src/python-firestore` for a local checkout\r\nmypy --python-executable=venv/bin/python test.py\r\n```","author":{"url":"https://github.com/nipunn1313","@type":"Person","name":"nipunn1313"},"datePublished":"2021-09-17T22:06:37Z","url":"https://github.com/googleapis/python-firestore/issues/447"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7df3cd87-bc32-4e55-7f79-cb345d2b23e0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9040:2B21DE:5A3BDA:7A4BDF:6B007445 |
| html-safe-nonce | 155cc1ec8e02f15f0562ba8ee2be3564742c8c8498549cd4d136fbe1adb63467 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQwOjJCMjFERTo1QTNCREE6N0E0QkRGOjZCMDA3NDQ1IiwidmlzaXRvcl9pZCI6IjMwNDM1MTA0Njg3OTk5MTkxNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2813ce96299647ee6b333861d0f46710638101e6a5db93ad32117a3d59b92d81 |
| hovercard-subject-tag | issue:999752833 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-firestore/447/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d08f1dceb346f42df4994c6b115a46d4e903445f5e9dcacf918a1871686eff98/googleapis/python-firestore/issues/447 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d08f1dceb346f42df4994c6b115a46d4e903445f5e9dcacf918a1871686eff98/googleapis/python-firestore/issues/447 |
| og:image:alt | Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only dis... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nipunn1313 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/python-firestore git https://github.com/googleapis/python-firestore.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992533 |
| octolytics-dimension-repository_nwo | googleapis/python-firestore |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992533 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-firestore |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84e563eb4b55f8fa102f325f117533cee9e3df4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width