René's URL Explorer Experiment


Title: `google.cloud.firestore` lacks packaged typing · Issue #447 · googleapis/python-firestore · GitHub

Open Graph Title: `google.cloud.firestore` lacks packaged typing · Issue #447 · googleapis/python-firestore

X Title: `google.cloud.firestore` lacks packaged typing · Issue #447 · googleapis/python-firestore

Description: Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only distributions. The code should be refactore...

Open Graph Description: Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only dis...

X Description: Hi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only dis...

Opengraph URL: https://github.com/googleapis/python-firestore/issues/447

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`google.cloud.firestore` lacks packaged typing","articleBody":"Hi.\r\n`google.cloud.firestore` does not have types via [PEP561](https://www.python.org/dev/peps/pep-0561/)\r\n`google.cloud.firestore_v1` and friends do.\r\n\r\nPer the PEP:\r\n```\r\nThis PEP does not support distributing typing information as part of module-only distributions. The code should be refactored into a package-based distribution and indicate that the package supports typing as described above.\r\n```\r\n\r\nYou'll have to refactor `firestore.py` into a directory structure\r\n```\r\ngoogle/\r\n  cloud/\r\n    firestore/\r\n      __init__.py\r\n      py.typed \r\n```\r\n\r\nRepro steps:\r\n\r\n```python\r\n# ~/test/test.py\r\n# firestore doesn't have py.typed yet - only firestore_v1 has\r\nfrom google.cloud.firestore import AsyncClient\r\nfrom google.cloud.firestore_v1 import AsyncClient\r\n```\r\n\r\n```\r\npython3 -m venv venv\r\nsource venv/bin/activate\r\npip install google-cloud-firestore\r\n# or `pip install -e ~/src/python-firestore` for a local checkout\r\nmypy --python-executable=venv/bin/python test.py\r\n```","author":{"url":"https://github.com/nipunn1313","@type":"Person","name":"nipunn1313"},"datePublished":"2021-09-17T22:06:37Z","url":"https://github.com/googleapis/python-firestore/issues/447"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7df3cd87-bc32-4e55-7f79-cb345d2b23e0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9040:2B21DE:5A3BDA:7A4BDF:6B007445
html-safe-nonce155cc1ec8e02f15f0562ba8ee2be3564742c8c8498549cd4d136fbe1adb63467
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDQwOjJCMjFERTo1QTNCREE6N0E0QkRGOjZCMDA3NDQ1IiwidmlzaXRvcl9pZCI6IjMwNDM1MTA0Njg3OTk5MTkxNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2813ce96299647ee6b333861d0f46710638101e6a5db93ad32117a3d59b92d81
hovercard-subject-tagissue:999752833
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-firestore/447/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d08f1dceb346f42df4994c6b115a46d4e903445f5e9dcacf918a1871686eff98/googleapis/python-firestore/issues/447
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d08f1dceb346f42df4994c6b115a46d4e903445f5e9dcacf918a1871686eff98/googleapis/python-firestore/issues/447
og:image:altHi. google.cloud.firestore does not have types via PEP561 google.cloud.firestore_v1 and friends do. Per the PEP: This PEP does not support distributing typing information as part of module-only dis...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenipunn1313
hostnamegithub.com
expected-hostnamegithub.com
None75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16
turbo-cache-controlno-preview
go-importgithub.com/googleapis/python-firestore git https://github.com/googleapis/python-firestore.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992533
octolytics-dimension-repository_nwogoogleapis/python-firestore
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992533
octolytics-dimension-repository_network_root_nwogoogleapis/python-firestore
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84e563eb4b55f8fa102f325f117533cee9e3df4a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/googleapis/python-firestore/issues/447#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-firestore%2Fissues%2F447
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-firestore%2Fissues%2F447
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fpython-firestore
Reloadhttps://github.com/googleapis/python-firestore/issues/447
Reloadhttps://github.com/googleapis/python-firestore/issues/447
Reloadhttps://github.com/googleapis/python-firestore/issues/447
googleapishttps://github.com/googleapis
python-firestorehttps://github.com/googleapis/python-firestore
Codehttps://github.com/googleapis/python-firestore
Issueshttps://github.com/googleapis/python-firestore/issues
Pull requestshttps://github.com/googleapis/python-firestore/pulls
Actionshttps://github.com/googleapis/python-firestore/actions
Projectshttps://github.com/googleapis/python-firestore/projects
Security and qualityhttps://github.com/googleapis/python-firestore/security
Insightshttps://github.com/googleapis/python-firestore/insights
https://github.com/googleapis/python-firestore
#448https://github.com/googleapis/python-firestore/pull/448
google.cloud.firestore lacks packaged typinghttps://github.com/googleapis/python-firestore/issues/447#top
#448https://github.com/googleapis/python-firestore/pull/448
api: firestoreIssues related to the googleapis/python-firestore API.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22
type: cleanupAn internal cleanup or hygiene concern.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22type%3A%20cleanup%22
Next Taskshttps://github.com/googleapis/python-firestore/milestone/3
https://github.com/nipunn1313
nipunn1313https://github.com/nipunn1313
on Sep 17, 2021https://github.com/googleapis/python-firestore/issues/447#issue-999752833
PEP561https://www.python.org/dev/peps/pep-0561/
product-auto-labelhttps://github.com/apps/product-auto-label
api: firestoreIssues related to the googleapis/python-firestore API.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22
on Sep 17, 2021https://github.com/googleapis/python-firestore/issues/447#event-5321774967
tseaverhttps://github.com/tseaver
type: cleanupAn internal cleanup or hygiene concern.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22type%3A%20cleanup%22
on Sep 20, 2021https://github.com/googleapis/python-firestore/issues/447#event-5330280406
https://github.com/tseaver
tseaverhttps://github.com/tseaver
on Sep 20, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-923190217
https://github.com/nipunn1313
nipunn1313https://github.com/nipunn1313
on Sep 20, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-923199046
#448https://github.com/googleapis/python-firestore/pull/448
https://github.com/tseaver
tseaverhttps://github.com/tseaver
on Sep 20, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-923206531
@nipunn1313https://github.com/nipunn1313
https://github.com/nipunn1313
nipunn1313https://github.com/nipunn1313
on Sep 20, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-923283609
python/peps#2083https://github.com/python/peps/pull/2083
microsoft/pyright#2113 (comment)https://github.com/microsoft/pyright/issues/2113#issuecomment-921304097
tseaverhttps://github.com/tseaver
do not mergeIndicates a pull request not ready for merge, due to either quality or timing.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
do not mergeIndicates a pull request not ready for merge, due to either quality or timing.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22
on Sep 21, 2021https://github.com/googleapis/python-firestore/issues/447#event-5338268153
https://github.com/nipunn1313
nipunn1313https://github.com/nipunn1313
on Oct 6, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-936700284
@tseaverhttps://github.com/tseaver
python/peps#2083https://github.com/python/peps/pull/2083
#448https://github.com/googleapis/python-firestore/pull/448
https://github.com/tseaver
tseaverhttps://github.com/tseaver
on Oct 7, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-937999098
https://github.com/nipunn1313
nipunn1313https://github.com/nipunn1313
on Oct 7, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-938215495
https://github.com/nipunn1313
nipunn1313https://github.com/nipunn1313
on Oct 7, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-938216468
crwilcoxhttps://github.com/crwilcox
completedhttps://github.com/googleapis/python-firestore/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#448https://github.com/googleapis/python-firestore/pull/448
on Oct 13, 2021https://github.com/googleapis/python-firestore/issues/447#event-5453658751
crwilcoxhttps://github.com/crwilcox
on Oct 14, 2021https://github.com/googleapis/python-firestore/issues/447#event-5466539254
https://github.com/crwilcox
crwilcoxhttps://github.com/crwilcox
on Oct 14, 2021https://github.com/googleapis/python-firestore/issues/447#issuecomment-943757971
#476https://github.com/googleapis/python-firestore/pull/476
https://www.github.com/googleapis/gapic-generator-python/issues/1026https://www.github.com/googleapis/gapic-generator-python/issues/1026
tseaverhttps://github.com/tseaver
on Nov 17, 2021https://github.com/googleapis/python-firestore/issues/447#event-5634052447
feat: declare typing for 'firestore_v1' and 'firestore_bundle'https://github.com/googleapis/python-firestore/commit/da65cc74fbe22489db9fb4a8f852180ac041b380
https://docs.github.com/articles/closing-issues-via-commit-messages
da65cc7https://github.com/googleapis/python-firestore/commit/da65cc74fbe22489db9fb4a8f852180ac041b380
daniel-sanchehttps://github.com/daniel-sanche
Q2https://github.com/googleapis/python-firestore/milestone/3
on Feb 23, 2024https://github.com/googleapis/python-firestore/issues/447#event-11908971567
daniel-sanchehttps://github.com/daniel-sanche
completedhttps://github.com/googleapis/python-firestore/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 26, 2024https://github.com/googleapis/python-firestore/issues/447#event-15443231613
Sign up for freehttps://github.com/signup?return_to=https://github.com/googleapis/python-firestore/issues/447
Sign in to commenthttps://github.com/login?return_to=https://github.com/googleapis/python-firestore/issues/447
api: firestoreIssues related to the googleapis/python-firestore API.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22api%3A%20firestore%22
type: cleanupAn internal cleanup or hygiene concern.https://github.com/googleapis/python-firestore/issues?q=state%3Aopen%20label%3A%22type%3A%20cleanup%22
Next TasksNo due datehttps://github.com/googleapis/python-firestore/milestone/3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.