René's URL Explorer Experiment


Title: fix: mutations batcher race condition by daniel-sanche · Pull Request #896 · googleapis/python-bigtable · GitHub

Open Graph Title: fix: mutations batcher race condition by daniel-sanche · Pull Request #896 · googleapis/python-bigtable

X Title: fix: mutations batcher race condition by daniel-sanche · Pull Request #896 · googleapis/python-bigtable

Description: This library has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-bigtable - fix: mutations batcher race condition by daniel-sanche · Pull Request #896 · googleapis/python-bigtable

Open Graph Description: There was a race condition found in the threaded mutations batcher. The batcher would check the state of the queue, and then read from the queue as separate steps, which left room for other threads...

X Description: There was a race condition found in the threaded mutations batcher. The batcher would check the state of the queue, and then read from the queue as separate steps, which left room for other threads...

Opengraph URL: https://github.com/googleapis/python-bigtable/pull/896

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:add33b9b-c7d3-9ff7-9625-ee97cf5d3e22
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA224:16BCD3:30145AF:424DC86:6A4F1B8F
html-safe-nonce1bc827a1ab3244341e4e681c5efa6d82e3a7ebe1677ceab84c6b97690943f74e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjI0OjE2QkNEMzozMDE0NUFGOjQyNERDODY6NkE0RjFCOEYiLCJ2aXNpdG9yX2lkIjoiODc0MTYyMjI2MDE3MzgzOTI0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccbe9eec58aba49168d4b3bc15218c5f2902ad2ea33767448ac6a9b8d5956b112
hovercard-subject-tagpull_request:1639487004
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-bigtable/896/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/19899bab8b85509472f87aae9ada302419d97b8b83e942de64223f43a1b42c24/googleapis/python-bigtable/pull/896
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19899bab8b85509472f87aae9ada302419d97b8b83e942de64223f43a1b42c24/googleapis/python-bigtable/pull/896
og:image:altThere was a race condition found in the threaded mutations batcher. The batcher would check the state of the queue, and then read from the queue as separate steps, which left room for other threads...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedaniel-sanche
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/googleapis/python-bigtable git https://github.com/googleapis/python-bigtable.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992487
octolytics-dimension-repository_nwogoogleapis/python-bigtable
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992487
octolytics-dimension-repository_network_root_nwogoogleapis/python-bigtable
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-bigtable/pull/896#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigtable%2Fpull%2F896
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigtable%2Fpull%2F896
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-bigtable
Reloadhttps://github.com/googleapis/python-bigtable/pull/896
Reloadhttps://github.com/googleapis/python-bigtable/pull/896
Reloadhttps://github.com/googleapis/python-bigtable/pull/896
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
googleapis https://github.com/googleapis
python-bigtablehttps://github.com/googleapis/python-bigtable
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-bigtable
Fork 65 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-bigtable
Star 75 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-bigtable
Code https://github.com/googleapis/python-bigtable
Issues 0 https://github.com/googleapis/python-bigtable/issues
Pull requests 0 https://github.com/googleapis/python-bigtable/pulls
Actions https://github.com/googleapis/python-bigtable/actions
Projects https://github.com/googleapis/python-bigtable/projects
Security and quality 0 https://github.com/googleapis/python-bigtable/security
Insights https://github.com/googleapis/python-bigtable/pulse
Code https://github.com/googleapis/python-bigtable
Issues https://github.com/googleapis/python-bigtable/issues
Pull requests https://github.com/googleapis/python-bigtable/pulls
Actions https://github.com/googleapis/python-bigtable/actions
Projects https://github.com/googleapis/python-bigtable/projects
Security and quality https://github.com/googleapis/python-bigtable/security
Insights https://github.com/googleapis/python-bigtable/pulse
daniel-sanchehttps://github.com/daniel-sanche
mainhttps://github.com/googleapis/python-bigtable/tree/main
fix_batcher_threadshttps://github.com/googleapis/python-bigtable/tree/fix_batcher_threads
Conversationhttps://github.com/googleapis/python-bigtable/pull/896
Commits15 (15)https://github.com/googleapis/python-bigtable/pull/896/commits
Checkshttps://github.com/googleapis/python-bigtable/pull/896/checks
Files changedhttps://github.com/googleapis/python-bigtable/pull/896/files
fix: mutations batcher race conditionhttps://github.com/googleapis/python-bigtable/pull/896#top
daniel-sanchehttps://github.com/daniel-sanche
mainhttps://github.com/googleapis/python-bigtable/tree/main
fix_batcher_threadshttps://github.com/googleapis/python-bigtable/tree/fix_batcher_threads
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
Dec 11, 2023https://github.com/googleapis/python-bigtable/pull/896#issue-2036397538
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
daniel-sanchehttps://github.com/daniel-sanche
December 8, 2023 15:58https://github.com/googleapis/python-bigtable/pull/896#commits-pushed-493029a
https://github.com/daniel-sanche
added lock to _MutatuionsBatchQueuehttps://github.com/googleapis/python-bigtable/pull/896/commits/493029a6f06a1b2de750b7be470297f0ccf003c4
493029ahttps://github.com/googleapis/python-bigtable/pull/896/commits/493029a6f06a1b2de750b7be470297f0ccf003c4
https://github.com/daniel-sanche
refactored _flush_asynchttps://github.com/googleapis/python-bigtable/pull/896/commits/2393b2ab91e3a8b69bdb8f469aee1770190db84c
2393b2ahttps://github.com/googleapis/python-bigtable/pull/896/commits/2393b2ab91e3a8b69bdb8f469aee1770190db84c
https://github.com/daniel-sanche
ran blackhttps://github.com/googleapis/python-bigtable/pull/896/commits/106d1a4d8367504baa21b874a96cd14376e6096f
106d1a4https://github.com/googleapis/python-bigtable/pull/896/commits/106d1a4d8367504baa21b874a96cd14376e6096f
https://github.com/daniel-sanche
made lock privatehttps://github.com/googleapis/python-bigtable/pull/896/commits/829eb045eac14cf2540b0d9b36e219ef2d972acf
829eb04https://github.com/googleapis/python-bigtable/pull/896/commits/829eb045eac14cf2540b0d9b36e219ef2d972acf
https://github.com/daniel-sanche
simplify flow control releasehttps://github.com/googleapis/python-bigtable/pull/896/commits/ee4e515c9070c5bf08a30ae8e36077d00a3ce9dc
ee4e515https://github.com/googleapis/python-bigtable/pull/896/commits/ee4e515c9070c5bf08a30ae8e36077d00a3ce9dc
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
December 11, 2023 19:38https://github.com/googleapis/python-bigtable/pull/896#event-11215043460
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
size: m https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3A%22size%3A%20m%22
api: bigtable https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3A%22api%3A%20bigtable%22
Dec 11, 2023https://github.com/googleapis/python-bigtable/pull/896#event-11215044349
daniel-sanchehttps://github.com/daniel-sanche
December 11, 2023 12:14https://github.com/googleapis/python-bigtable/pull/896#commits-pushed-5761191
https://github.com/daniel-sanche
added system test for mutations batcherhttps://github.com/googleapis/python-bigtable/pull/896/commits/5761191a30ddc656688b6b928fcc9b35256cce5c
5761191https://github.com/googleapis/python-bigtable/pull/896/commits/5761191a30ddc656688b6b928fcc9b35256cce5c
https://github.com/daniel-sanche
fix issue with flow_control deadlockhttps://github.com/googleapis/python-bigtable/pull/896/commits/4b451fd110aee1a3ccd9e04b4ef56d4ff46aef13
4b451fdhttps://github.com/googleapis/python-bigtable/pull/896/commits/4b451fd110aee1a3ccd9e04b4ef56d4ff46aef13
https://github.com/daniel-sanche
change number of test nodeshttps://github.com/googleapis/python-bigtable/pull/896/commits/6a52214f11504c6b3ff9830eebe5bf3f3def680b
6a52214https://github.com/googleapis/python-bigtable/pull/896/commits/6a52214f11504c6b3ff9830eebe5bf3f3def680b
https://github.com/daniel-sanche
ran blackenhttps://github.com/googleapis/python-bigtable/pull/896/commits/96222ba806fdf5fd414ede687c506fa158f6ab0a
96222bahttps://github.com/googleapis/python-bigtable/pull/896/commits/96222ba806fdf5fd414ede687c506fa158f6ab0a
https://github.com/apps/gcf-owl-bot
🦉 Updates from OwlBot post-processorhttps://github.com/googleapis/python-bigtable/pull/896/commits/a0b5975f3d7e58ee3cf526716e25b99caa3fdda3
a0b5975https://github.com/googleapis/python-bigtable/pull/896/commits/a0b5975f3d7e58ee3cf526716e25b99caa3fdda3
https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdhttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
https://github.com/apps/gcf-owl-bot
Merge branch 'fix_batcher_threads' ofhttps://github.com/googleapis/python-bigtable/pull/896/commits/c79c08a6c92efd1898cfa87fb001216a42fb39c4
https://github.com/googleapis/p…https://github.com/googleapis/python-bigtable
c79c08ahttps://github.com/googleapis/python-bigtable/pull/896/commits/c79c08a6c92efd1898cfa87fb001216a42fb39c4
…ython-bigtablehttps://github.com/googleapis/python-bigtable
https://github.com/mutianf
mutianfhttps://github.com/mutianf
Dec 11, 2023 https://github.com/googleapis/python-bigtable/pull/896#pullrequestreview-1776198899
View reviewed changes https://github.com/googleapis/python-bigtable/pull/896/files/c79c08a6c92efd1898cfa87fb001216a42fb39c4
google/cloud/bigtable/batcher.pyhttps://github.com/googleapis/python-bigtable/pull/896/files/c79c08a6c92efd1898cfa87fb001216a42fb39c4#diff-6e11756deb0cd3a0885af4598ec0dfd3356559367d0d08b1741ba15287d5397c
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
google/cloud/bigtable/batcher.pyhttps://github.com/googleapis/python-bigtable/pull/896/files/c79c08a6c92efd1898cfa87fb001216a42fb39c4#diff-6e11756deb0cd3a0885af4598ec0dfd3356559367d0d08b1741ba15287d5397c
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
google/cloud/bigtable/batcher.pyhttps://github.com/googleapis/python-bigtable/pull/896/files/c79c08a6c92efd1898cfa87fb001216a42fb39c4#diff-6e11756deb0cd3a0885af4598ec0dfd3356559367d0d08b1741ba15287d5397c
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
google/cloud/bigtable/batcher.pyhttps://github.com/googleapis/python-bigtable/pull/896/files/c79c08a6c92efd1898cfa87fb001216a42fb39c4#diff-6e11756deb0cd3a0885af4598ec0dfd3356559367d0d08b1741ba15287d5397c
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
daniel-sanchehttps://github.com/daniel-sanche
December 11, 2023 14:08https://github.com/googleapis/python-bigtable/pull/896#commits-pushed-31a14d3
https://github.com/daniel-sanche
removed lockhttps://github.com/googleapis/python-bigtable/pull/896/commits/31a14d33c427403c84ff8842e2a98782316f5db7
31a14d3https://github.com/googleapis/python-bigtable/pull/896/commits/31a14d33c427403c84ff8842e2a98782316f5db7
https://github.com/daniel-sanche
reverted flow control release patternhttps://github.com/googleapis/python-bigtable/pull/896/commits/68e6eb582c42b783da0b5c1d8d9e8fbb879766df
68e6eb5https://github.com/googleapis/python-bigtable/pull/896/commits/68e6eb582c42b783da0b5c1d8d9e8fbb879766df
https://github.com/daniel-sanche
fixed assertionhttps://github.com/googleapis/python-bigtable/pull/896/commits/9fac3a2a78000e576fe8830680aae9e10907cbdf
9fac3a2https://github.com/googleapis/python-bigtable/pull/896/commits/9fac3a2a78000e576fe8830680aae9e10907cbdf
https://github.com/daniel-sanche
loosened test requirementhttps://github.com/googleapis/python-bigtable/pull/896/commits/e265baadc69909a15083de2af098c8ac9cc2e59f
e265baahttps://github.com/googleapis/python-bigtable/pull/896/commits/e265baadc69909a15083de2af098c8ac9cc2e59f
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
kokoro:force-run https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Dec 12, 2023https://github.com/googleapis/python-bigtable/pull/896#event-11226851530
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Dec 12, 2023https://github.com/googleapis/python-bigtable/pull/896#event-11226857932
https://github.com/igorbernstein2
igorbernstein2https://github.com/igorbernstein2
Dec 12, 2023 https://github.com/googleapis/python-bigtable/pull/896#pullrequestreview-1778404451
View reviewed changes https://github.com/googleapis/python-bigtable/pull/896/files/e265baadc69909a15083de2af098c8ac9cc2e59f
igorbernstein2https://github.com/igorbernstein2
https://github.com/googleapis/python-bigtable/pull/896#pullrequestreview-1778404451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
kokoro:force-run https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Dec 12, 2023https://github.com/googleapis/python-bigtable/pull/896#event-11228825384
https://github.com/yoshi-kokoro
yoshi-kokorohttps://github.com/yoshi-kokoro
kokoro:force-run https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3Akokoro%3Aforce-run
Dec 12, 2023https://github.com/googleapis/python-bigtable/pull/896#event-11228924853
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
fe58f61https://github.com/googleapis/python-bigtable/commit/fe58f617c7364d7e99e2ec50abd5f080852bf033
Dec 12, 2023https://github.com/googleapis/python-bigtable/pull/896#event-11229037802
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
December 12, 2023 21:58https://github.com/googleapis/python-bigtable/pull/896#event-11229038150
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Dec 12, 2023 https://github.com/googleapis/python-bigtable/pull/896#ref-pullrequest-1864120726
chore(main): release 2.22.0 #861 https://github.com/googleapis/python-bigtable/pull/861
https://github.co/hiddenchars
https://github.com/googleapis/python-bigtable/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigtable%2Fpull%2F896
https://github.com/mutianf
mutianf https://github.com/mutianf
https://github.com/googleapis/python-bigtable/pull/896/files/c79c08a6c92efd1898cfa87fb001216a42fb39c4
https://github.com/igorbernstein2
igorbernstein2 https://github.com/igorbernstein2
https://github.com/googleapis/python-bigtable/pull/896/files/e265baadc69909a15083de2af098c8ac9cc2e59f
api: bigtable https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3A%22api%3A%20bigtable%22
size: m https://github.com/googleapis/python-bigtable/issues?q=state%3Aopen%20label%3A%22size%3A%20m%22
Please reload this pagehttps://github.com/googleapis/python-bigtable/pull/896
https://github.com/daniel-sanche
https://github.com/mutianf
https://github.com/igorbernstein2
https://github.com/yoshi-kokoro
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.