Title: Refactor: Remove duplicate _has_json_arrow_type from loader.py by shuoweil · Pull Request #2221 · googleapis/python-bigquery-dataframes · GitHub
Open Graph Title: Refactor: Remove duplicate _has_json_arrow_type from loader.py by shuoweil · Pull Request #2221 · googleapis/python-bigquery-dataframes
X Title: Refactor: Remove duplicate _has_json_arrow_type from loader.py by shuoweil · Pull Request #2221 · googleapis/python-bigquery-dataframes
Description: This PR eliminates a redundant function, _has_json_arrow_type, from bigframes/session/loader.py. The logic of this function is identical to bigframes.dtypes.contains_db_dtypes_json_arrow_type. The call to the removed function within _validate_dtype_can_load has been updated to utilize the existing bigframes.dtypes.contains_db_dtypes_json_arrow_type. This refactoring improves code maintainability and reduces duplication by centralizing the logic for checking JSON arrow types.
Open Graph Description: This PR eliminates a redundant function, _has_json_arrow_type, from bigframes/session/loader.py. The logic of this function is identical to bigframes.dtypes.contains_db_dtypes_json_arrow_type. The ...
X Description: This PR eliminates a redundant function, _has_json_arrow_type, from bigframes/session/loader.py. The logic of this function is identical to bigframes.dtypes.contains_db_dtypes_json_arrow_type. The ...
Opengraph URL: https://github.com/googleapis/python-bigquery-dataframes/pull/2221
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:15b76fab-6429-e66b-d134-81376121d44f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CAFE:1AC1D:13431BF:1A4B058:6A571C5F |
| html-safe-nonce | 3d40c325f300061e70d6ebf42d4fb96155b425948e75e4d44e8840f4c3cbefa8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUZFOjFBQzFEOjEzNDMxQkY6MUE0QjA1ODo2QTU3MUM1RiIsInZpc2l0b3JfaWQiOiIyODQwMTczNTg2MTU4MTMyMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | da465669e36377032b4e8c14a52cf0df8071dc3575281adfd57f821d06693f3c |
| hovercard-subject-tag | pull_request:2969728596 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/googleapis/python-bigquery-dataframes/pull/2221/files |
| twitter:image | https://avatars.githubusercontent.com/u/189301813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/189301813?s=400&v=4 |
| og:image:alt | This PR eliminates a redundant function, _has_json_arrow_type, from bigframes/session/loader.py. The logic of this function is identical to bigframes.dtypes.contains_db_dtypes_json_arrow_type. The ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/googleapis/python-bigquery-dataframes git https://github.com/googleapis/python-bigquery-dataframes.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 667598363 |
| octolytics-dimension-repository_nwo | googleapis/python-bigquery-dataframes |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 667598363 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-bigquery-dataframes |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2576d1f0198cf1588faf2edf27f1ed120903be10 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width