| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e09d7295-95bf-3396-d797-dda467c09092 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D314:244C0:1BEB39F:269FC51:6A4EC255 |
| html-safe-nonce | a7a92ddc561be7588927b6b558872849e70f9e982bc0dcf0372d0f0ccf2b7b48 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzE0OjI0NEMwOjFCRUIzOUY6MjY5RkM1MTo2QTRFQzI1NSIsInZpc2l0b3JfaWQiOiI1ODg2MTEwMjA0MDAxNDM2MjQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 22535324712ce8b8be182f027d900575b1a2b883e12e93f9ff9588433cbcf946 |
| hovercard-subject-tag | pull_request:511102547 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-bigquery/347/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1f979383da7277af056c30f33b3eb28cb64d9f54ad4d06149890a6403c4cf4ab/googleapis/python-bigquery/pull/347 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1f979383da7277af056c30f33b3eb28cb64d9f54ad4d06149890a6403c4cf4ab/googleapis/python-bigquery/pull/347 |
| og:image:alt | Since getQueryResults was already used to wait for the job to finish,
this avoids an additional call to tabledata.list. The first page of
results are cached in-memory.
Additional changes will come ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tswast |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/googleapis/python-bigquery git https://github.com/googleapis/python-bigquery.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992475 |
| octolytics-dimension-repository_nwo | googleapis/python-bigquery |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992475 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-bigquery |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/googleapis/python-bigquery/pull/347#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigquery%2Fpull%2F347 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigquery%2Fpull%2F347 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-bigquery |
| Reload | https://github.com/googleapis/python-bigquery/pull/347 |
| Reload | https://github.com/googleapis/python-bigquery/pull/347 |
| Reload | https://github.com/googleapis/python-bigquery/pull/347 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
|
googleapis
| https://github.com/googleapis |
| python-bigquery | https://github.com/googleapis/python-bigquery |
|
Notifications
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery |
|
Fork
324
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery |
|
Star
799
| https://github.com/login?return_to=%2Fgoogleapis%2Fpython-bigquery |
|
Code
| https://github.com/googleapis/python-bigquery |
|
Issues
0
| https://github.com/googleapis/python-bigquery/issues |
|
Pull requests
0
| https://github.com/googleapis/python-bigquery/pulls |
|
Actions
| https://github.com/googleapis/python-bigquery/actions |
|
Projects
| https://github.com/googleapis/python-bigquery/projects |
|
Security and quality
0
| https://github.com/googleapis/python-bigquery/security |
|
Insights
| https://github.com/googleapis/python-bigquery/pulse |
|
Code
| https://github.com/googleapis/python-bigquery |
|
Issues
| https://github.com/googleapis/python-bigquery/issues |
|
Pull requests
| https://github.com/googleapis/python-bigquery/pulls |
|
Actions
| https://github.com/googleapis/python-bigquery/actions |
|
Projects
| https://github.com/googleapis/python-bigquery/projects |
|
Security and quality
| https://github.com/googleapis/python-bigquery/security |
|
Insights
| https://github.com/googleapis/python-bigquery/pulse |
| tswast | https://github.com/tswast |
| googleapis:master | https://github.com/googleapis/python-bigquery/tree/master |
| tswast:optimized-query-getQueryResults | https://github.com/tswast/python-bigquery/tree/optimized-query-getQueryResults |
| Conversation | https://github.com/googleapis/python-bigquery/pull/347 |
| Commits8 (8) | https://github.com/googleapis/python-bigquery/pull/347/commits |
| Checks | https://github.com/googleapis/python-bigquery/pull/347/checks |
| Files changed | https://github.com/googleapis/python-bigquery/pull/347/files |
| perf: use jobs.getQueryResults to download result sets | https://github.com/googleapis/python-bigquery/pull/347#top |
| tswast | https://github.com/tswast |
| googleapis:master | https://github.com/googleapis/python-bigquery/tree/master |
| tswast:optimized-query-getQueryResults | https://github.com/tswast/python-bigquery/tree/optimized-query-getQueryResults |
|
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| Oct 27, 2020 | https://github.com/googleapis/python-bigquery/pull/347#issue-730863498 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| bug/issue | https://github.com/googleapis/python-bigquery/issues/new/choose |
| #362 | https://github.com/googleapis/python-bigquery/issues/362 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/googleapis/python-bigquery/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 27, 2020 | https://github.com/googleapis/python-bigquery/pull/347#event-3928357742 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| Oct 27, 2020 | https://github.com/googleapis/python-bigquery/pull/347#issuecomment-717559985 |
| #341 | https://github.com/googleapis/python-bigquery/pull/341 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Oct 28, 2020
| https://github.com/googleapis/python-bigquery/pull/347#pullrequestreview-518724352 |
|
View reviewed changes
| https://github.com/googleapis/python-bigquery/pull/347/files |
| google/cloud/bigquery/job.py | https://github.com/googleapis/python-bigquery/pull/347/files#diff-65193791eddf155c4f8fa506031ca7702f8bd10a6e2e11598bae7e781f878907 |
| tswast | https://github.com/tswast |
| Oct 28, 2020 | https://github.com/googleapis/python-bigquery/pull/347#discussion_r513489196 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| tswast | https://github.com/tswast |
| Oct 28, 2020 | https://github.com/googleapis/python-bigquery/pull/347#discussion_r513490674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| tswast | https://github.com/tswast |
| Oct 28, 2020 | https://github.com/googleapis/python-bigquery/pull/347#discussion_r513729783 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/googleapis/google-cloud-go/blob/925033712191bce44fa99eb117d6531106042272/bigquery/iterator.go#L314 | https://github.com/googleapis/google-cloud-go/blob/925033712191bce44fa99eb117d6531106042272/bigquery/iterator.go#L314 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| tswast | https://github.com/tswast |
| Oct 30, 2020 | https://github.com/googleapis/python-bigquery/pull/347#discussion_r515396013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
|
| https://github.com/tswast |
| perf: use jobs.getQueryResults to download result sets | https://github.com/googleapis/python-bigquery/pull/347/commits/983c8d2b5b19f7d782b6c77b2a41626170ebb02e |
| 983c8d2 | https://github.com/googleapis/python-bigquery/pull/347/commits/983c8d2b5b19f7d782b6c77b2a41626170ebb02e |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| force-pushed | https://github.com/googleapis/python-bigquery/compare/7364196a0719ab598290700e1190ded947f7be37..983c8d2b5b19f7d782b6c77b2a41626170ebb02e |
| 7364196 | https://github.com/googleapis/python-bigquery/commit/7364196a0719ab598290700e1190ded947f7be37 |
| 983c8d2 | https://github.com/googleapis/python-bigquery/commit/983c8d2b5b19f7d782b6c77b2a41626170ebb02e |
|
Compare
| https://github.com/googleapis/python-bigquery/compare/7364196a0719ab598290700e1190ded947f7be37..983c8d2b5b19f7d782b6c77b2a41626170ebb02e |
| October 29, 2020 19:15 | https://github.com/googleapis/python-bigquery/pull/347#event-3937983481 |
|
| https://github.com/tswast |
| fix: validate the query results cache before using | https://github.com/googleapis/python-bigquery/pull/347/commits/f52ed71cac0bec1f643d39be378399703b312a33 |
| f52ed71 | https://github.com/googleapis/python-bigquery/pull/347/commits/f52ed71cac0bec1f643d39be378399703b312a33 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| October 30, 2020 21:40 | https://github.com/googleapis/python-bigquery/pull/347#event-3943230884 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| shollyman | https://github.com/shollyman |
| October 30, 2020 21:40 | https://github.com/googleapis/python-bigquery/pull/347#event-3943230894 |
| tswast | https://github.com/tswast |
| November 2, 2020 09:44 | https://github.com/googleapis/python-bigquery/pull/347#commits-pushed-e149360 |
|
| https://github.com/tswast |
| Merge remote-tracking branch 'upstream/master' into optimized-query-g… | https://github.com/googleapis/python-bigquery/pull/347/commits/e1493601937f3969c875c2a11cd9dd19035eede8 |
| e149360 | https://github.com/googleapis/python-bigquery/pull/347/commits/e1493601937f3969c875c2a11cd9dd19035eede8 |
|
| https://github.com/tswast |
| blacken. update dbapi to use thread local var | https://github.com/googleapis/python-bigquery/pull/347/commits/9b5920fb007651400892b091dff634beda8b7055 |
| 9b5920f | https://github.com/googleapis/python-bigquery/pull/347/commits/9b5920fb007651400892b091dff634beda8b7055 |
|
| https://github.com/tswast |
| fix dbapi tests | https://github.com/googleapis/python-bigquery/pull/347/commits/07e604349649d5607d3cd8a3d250618317ad044b |
| 07e6043 | https://github.com/googleapis/python-bigquery/pull/347/commits/07e604349649d5607d3cd8a3d250618317ad044b |
|
| https://github.com/tswast |
| fix system test | https://github.com/googleapis/python-bigquery/pull/347/commits/af2e2ccccb5850e3d6ae591f3bb09e8d8da60956 |
| af2e2cc | https://github.com/googleapis/python-bigquery/pull/347/commits/af2e2ccccb5850e3d6ae591f3bb09e8d8da60956 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Nov 2, 2020
| https://github.com/googleapis/python-bigquery/pull/347#ref-issue-734657035 |
|
refactor: split job.py and test_job.py
#358
| https://github.com/googleapis/python-bigquery/issues/358 |
| tswast | https://github.com/tswast |
| November 2, 2020 10:50 | https://github.com/googleapis/python-bigquery/pull/347#commits-pushed-540d530 |
|
| https://github.com/tswast |
| add unit tests for missing coverage | https://github.com/googleapis/python-bigquery/pull/347/commits/540d53099562c272bd5552400a163c81845e8d3b |
| 540d530 | https://github.com/googleapis/python-bigquery/pull/347/commits/540d53099562c272bd5552400a163c81845e8d3b |
|
| https://github.com/tswast |
| blacken | https://github.com/googleapis/python-bigquery/pull/347/commits/6e83fbf52f808c31a1829edf78e4f7a01c29ca8f |
| 6e83fbf | https://github.com/googleapis/python-bigquery/pull/347/commits/6e83fbf52f808c31a1829edf78e4f7a01c29ca8f |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Nov 2, 2020
| https://github.com/googleapis/python-bigquery/pull/347#pullrequestreview-522081936 |
|
View reviewed changes
| https://github.com/googleapis/python-bigquery/pull/347/files/6e83fbf52f808c31a1829edf78e4f7a01c29ca8f |
| google/cloud/bigquery/client.py | https://github.com/googleapis/python-bigquery/pull/347/files/6e83fbf52f808c31a1829edf78e4f7a01c29ca8f#diff-fc3199dcfb64ea8758d31d37f30dc25c4885b1c21b03812fbc0f1914f48763f3 |
| tswast | https://github.com/tswast |
| Nov 2, 2020 | https://github.com/googleapis/python-bigquery/pull/347#discussion_r516298780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
do not merge
| https://github.com/googleapis/python-bigquery/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22 |
| Nov 2, 2020 | https://github.com/googleapis/python-bigquery/pull/347#event-3950402232 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| Nov 3, 2020 | https://github.com/googleapis/python-bigquery/pull/347#issuecomment-721352556 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| perf: use jobs.getQueryResults to download result sets #363 | https://github.com/googleapis/python-bigquery/pull/363 |
| #361 | https://github.com/googleapis/python-bigquery/pull/361 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
| Nov 4, 2020 | https://github.com/googleapis/python-bigquery/pull/347#event-3958757935 |
| https://github.com/tswast |
| tswast | https://github.com/tswast |
|
Nov 5, 2020
| https://github.com/googleapis/python-bigquery/pull/347#ref-pullrequest-737320833 |
|
perf: cache first page of jobs.getQueryResults rows
#374
| https://github.com/googleapis/python-bigquery/pull/374 |
| https://github.co/hiddenchars |
| https://github.com/googleapis/python-bigquery/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-bigquery%2Fpull%2F347 |
|
| https://github.com/shollyman |
|
shollyman
| https://github.com/shollyman |
|
cla: yes
| https://github.com/googleapis/python-bigquery/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
do not merge
| https://github.com/googleapis/python-bigquery/issues?q=state%3Aopen%20label%3A%22do%20not%20merge%22 |
| Please reload this page | https://github.com/googleapis/python-bigquery/pull/347 |
|
| https://github.com/tswast |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |