René's URL Explorer Experiment

Title: feat: Add support for creating exceptions from an asynchronous response by ohmayr · Pull Request #688 · googleapis/python-api-core · GitHub

Open Graph Title: feat: Add support for creating exceptions from an asynchronous response by ohmayr · Pull Request #688 · googleapis/python-api-core

X Title: feat: Add support for creating exceptions from an asynchronous response by ohmayr · Pull Request #688 · googleapis/python-api-core

Description: This PR implements a _RestCall class to map GoogleAPICallError to an asynchronous rest callable that raises google.auth.exceptions.TransportError.This wrapping is done via a helper method rest_helpers_async.wrap_errors. A new parameter kind is introduced in wrap_method which can be one of grpc_asyncio (Default Value) or rest_asyncio to distinguish between the type of callables so that we can apply the appropriate wrapping logic. The property kind is exposed at the transport level here and will be configured when wrapping methods during the transport initialization here. As a follow up, a similar logic must be implemented for synchronous rest callables to avoid gRPC specific stack trace within a rest call. RE: Updated Workflow: I've removed the proposed _RestCall class after determining that it is not needed to wrap a rest callable and just adds unnecessary logic. The new proposed workflow is as follows: This PR still introduces a new parameter kind in wrap_method to determine the type of a callable i.e. grpc_asyncio or rest_asyncio. If kind=="rest_asyncio", we skip the call to grpc_helpers_async.wrap_errors which is gRPC specific. Essentially, this does the trick if we follow a similar pattern for error handling to what we're doing in a sync rest call. We have been lazily creating and raising a GoogleAPICallError from a requests.Response within our GAPICs using the from_http_response method here. Therefore, we don't need to add the error handling logic to the callable beforehand (we're currently doing both the things for a sync rest call and should skip wrapping the callable beforehand there too). This PR only handles the error handling logic for an async REST call. It also introduces a new helper i.e. format_http_response_error to create and raise a GoogleAPICallError for a more generic response since the existing from_http_response is specific to handling a requests response. Alternate approach for the introduced helper: The proposed implementation of format_http_response_error takes in payload as an argument so that we don't need to await for it within the call and keep this function synchronous. Alternatively, we can have an async version of from_http_response that can be used to create GoogleAPICallError for async rest calls. Follow Up: As a follow up, we should skip wrapping sync rest callable with grpc_helpers.wrap_errors (similar to what we're doing here) to avoid the unnecessary gRPC specific logic within a rest call stracktrace.

Open Graph Description: This PR implements a _RestCall class to map GoogleAPICallError to an asynchronous rest callable that raises google.auth.exceptions.TransportError.This wrapping is done via a helper method rest_help...

X Description: This PR implements a _RestCall class to map GoogleAPICallError to an asynchronous rest callable that raises google.auth.exceptions.TransportError.This wrapping is done via a helper method rest_help...

Opengraph URL: https://github.com/googleapis/python-api-core/pull/688

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width