René's URL Explorer Experiment


Title: chore: fallback to unary_unary when wrapping async callables by daniel-sanche · Pull Request #653 · googleapis/python-api-core · GitHub

Open Graph Title: chore: fallback to unary_unary when wrapping async callables by daniel-sanche · Pull Request #653 · googleapis/python-api-core

X Title: chore: fallback to unary_unary when wrapping async callables by daniel-sanche · Pull Request #653 · googleapis/python-api-core

Description: We recently made a change to move some computation in the async rpc wrapper from call-time to wrap-time. This way, individual calls would execute faster, since they don't have to re-compute some data on each call A side-effect of this change is that now some type validation happens earlier. This caused some downstream tests to fail when a mock grpc channel is used. The wrapper doesn't know how to handle the mock.Mock type, and raises an exception while constructing the client object This PR fixes the issue by falling back to the unary wrapper when the callable type is unknown, rather than raising an exception. This is in-line with how the sync version handles it

Open Graph Description: We recently made a change to move some computation in the async rpc wrapper from call-time to wrap-time. This way, individual calls would execute faster, since they don't have to re-compute som...

X Description: We recently made a change to move some computation in the async rpc wrapper from call-time to wrap-time. This way, individual calls would execute faster, since they don't have to re-compute...

Opengraph URL: https://github.com/googleapis/python-api-core/pull/653

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f6eeebaf-0ac0-d131-6a5e-c69eda78108c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC21A:2C03D:2D7278B:3E76B87:6A4EF3EA
html-safe-nonce189e3f6c72e61bb0affbdae9425b26524b4fb6eeaa2501ae346d6d74ef0ff365
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjFBOjJDMDNEOjJENzI3OEI6M0U3NkI4Nzo2QTRFRjNFQSIsInZpc2l0b3JfaWQiOiI1NTM1ODQxMzE0NDc2NTg1OTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc056b7ea644be6cdbb87f0d47b6eee538e85c37a7379a0d93fd8792e3e15639b
hovercard-subject-tagpull_request:1862777426
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/googleapis/python-api-core/pull/653/files
twitter:imagehttps://avatars.githubusercontent.com/u/3914119?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3914119?s=400&v=4
og:image:altWe recently made a change to move some computation in the async rpc wrapper from call-time to wrap-time. This way, individual calls would execute faster, since they don't have to re-compute som...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992456
octolytics-dimension-repository_nwogoogleapis/python-api-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992456
octolytics-dimension-repository_network_root_nwogoogleapis/python-api-core
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-api-core/pull/653/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F653%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F653%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=googleapis%2Fpython-api-core
Reloadhttps://github.com/googleapis/python-api-core/pull/653/files
Reloadhttps://github.com/googleapis/python-api-core/pull/653/files
Reloadhttps://github.com/googleapis/python-api-core/pull/653/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/653/files
googleapis https://github.com/googleapis
python-api-corehttps://github.com/googleapis/python-api-core
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Fork 97 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Star 144 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Code https://github.com/googleapis/python-api-core
Issues 0 https://github.com/googleapis/python-api-core/issues
Pull requests 0 https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality 0 https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
Code https://github.com/googleapis/python-api-core
Issues https://github.com/googleapis/python-api-core/issues
Pull requests https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
partheahttps://github.com/parthea
mainhttps://github.com/googleapis/python-api-core/tree/main
fall-back-to-unaryhttps://github.com/googleapis/python-api-core/tree/fall-back-to-unary
Conversation 0 https://github.com/googleapis/python-api-core/pull/653
Commits 3 https://github.com/googleapis/python-api-core/pull/653/commits
Checks 0 https://github.com/googleapis/python-api-core/pull/653/checks
Files changed https://github.com/googleapis/python-api-core/pull/653/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/653/files
chore: fallback to unary_unary when wrapping async callables https://github.com/googleapis/python-api-core/pull/653/files#top
Show all changes 3 commits https://github.com/googleapis/python-api-core/pull/653/files
d522265 fix: fallback to unary_unary when wrapping async callables daniel-sanche May 9, 2024 https://github.com/googleapis/python-api-core/pull/653/commits/d522265b01c3248ab5b190d63232d0232a91e321
d089d0d fixed elif to if daniel-sanche May 9, 2024 https://github.com/googleapis/python-api-core/pull/653/commits/d089d0dfa00f8cbea68daaddc3322adfc31f0961
d59b015 removed outdated test daniel-sanche May 9, 2024 https://github.com/googleapis/python-api-core/pull/653/commits/d59b0158e38c0fad239b5625debc768eb0d6d469
Clear filters https://github.com/googleapis/python-api-core/pull/653/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/653/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/653/files
grpc_helpers_async.py https://github.com/googleapis/python-api-core/pull/653/files#diff-8d7fc40ae297f573cfea6aed00f8fe073f211a84ac0b9aa6961745030ee1d76b
test_grpc_helpers_async.py https://github.com/googleapis/python-api-core/pull/653/files#diff-674e40c61f15aa7ba281c08b5ae7d3231c02189806f9c3b53b3e9a656815d2c5
google/api_core/grpc_helpers_async.pyhttps://github.com/googleapis/python-api-core/pull/653/files#diff-8d7fc40ae297f573cfea6aed00f8fe073f211a84ac0b9aa6961745030ee1d76b
View file https://github.com/googleapis/python-api-core/blob/d59b0158e38c0fad239b5625debc768eb0d6d469/google/api_core/grpc_helpers_async.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-api-core/pull/653/{{ revealButtonHref }}
https://github.com/googleapis/python-api-core/pull/653/files#diff-8d7fc40ae297f573cfea6aed00f8fe073f211a84ac0b9aa6961745030ee1d76b
https://github.com/googleapis/python-api-core/pull/653/files#diff-8d7fc40ae297f573cfea6aed00f8fe073f211a84ac0b9aa6961745030ee1d76b
tests/asyncio/test_grpc_helpers_async.pyhttps://github.com/googleapis/python-api-core/pull/653/files#diff-674e40c61f15aa7ba281c08b5ae7d3231c02189806f9c3b53b3e9a656815d2c5
View file https://github.com/googleapis/python-api-core/blob/d59b0158e38c0fad239b5625debc768eb0d6d469/tests/asyncio/test_grpc_helpers_async.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-api-core/pull/653/{{ revealButtonHref }}
https://github.com/googleapis/python-api-core/pull/653/files#diff-674e40c61f15aa7ba281c08b5ae7d3231c02189806f9c3b53b3e9a656815d2c5
https://github.com/googleapis/python-api-core/pull/653/files#diff-674e40c61f15aa7ba281c08b5ae7d3231c02189806f9c3b53b3e9a656815d2c5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.