René's URL Explorer Experiment


Title: fix: Retry constructors methods support None by daniel-sanche · Pull Request #592 · googleapis/python-api-core · GitHub

Open Graph Title: fix: Retry constructors methods support None by daniel-sanche · Pull Request #592 · googleapis/python-api-core

X Title: fix: Retry constructors methods support None by daniel-sanche · Pull Request #592 · googleapis/python-api-core

Description: This library has moved to https://github.com/googleapis/google-cloud-python/tree/main/packages/google-api-core - fix: Retry constructors methods support None by daniel-sanche · Pull Request #592 · googleapis/python-api-core

Open Graph Description: Fixes #591 v2.16.0 did some refactoring of the Retry class, including adding a _replace helper method to simplify the constructors with_deadline, with_timeout, with_predicate, and with_delay. But i...

X Description: Fixes #591 v2.16.0 did some refactoring of the Retry class, including adding a _replace helper method to simplify the constructors with_deadline, with_timeout, with_predicate, and with_delay. But i...

Opengraph URL: https://github.com/googleapis/python-api-core/pull/592

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0a2b3dda-745a-9b52-19ee-a36d324396ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1E8:38C5E:CAAAC0:12499CB:6A4E4B36
html-safe-nonce0532432e6fafcc6bcf52b21d0083f58c67a46f2ef9d3d2afbdfbc133d243b65e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUU4OjM4QzVFOkNBQUFDMDoxMjQ5OUNCOjZBNEU0QjM2IiwidmlzaXRvcl9pZCI6IjczNTkxOTA5NzQ3MTc2NDM1NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb27bff31280cd5f357e418c0ee7433b78b8da3e073f9e1c410e5f575e1bdb89e
hovercard-subject-tagpull_request:1705057012
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/googleapis/python-api-core/592/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c7074a7ccda78db8dbc43a3dcf0aebd5d4fa288c158be69e163b28901db77ccd/googleapis/python-api-core/pull/592
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c7074a7ccda78db8dbc43a3dcf0aebd5d4fa288c158be69e163b28901db77ccd/googleapis/python-api-core/pull/592
og:image:altFixes #591 v2.16.0 did some refactoring of the Retry class, including adding a _replace helper method to simplify the constructors with_deadline, with_timeout, with_predicate, and with_delay. But i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedaniel-sanche
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992456
octolytics-dimension-repository_nwogoogleapis/python-api-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992456
octolytics-dimension-repository_network_root_nwogoogleapis/python-api-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8506f6d0538364886e3f0153c154c410965e70d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-api-core/pull/592#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F592
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F592
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=googleapis%2Fpython-api-core
Reloadhttps://github.com/googleapis/python-api-core/pull/592
Reloadhttps://github.com/googleapis/python-api-core/pull/592
Reloadhttps://github.com/googleapis/python-api-core/pull/592
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
googleapis https://github.com/googleapis
python-api-corehttps://github.com/googleapis/python-api-core
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Fork 97 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Star 144 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Code https://github.com/googleapis/python-api-core
Issues 0 https://github.com/googleapis/python-api-core/issues
Pull requests 0 https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality 0 https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
Code https://github.com/googleapis/python-api-core
Issues https://github.com/googleapis/python-api-core/issues
Pull requests https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
daniel-sanchehttps://github.com/daniel-sanche
mainhttps://github.com/googleapis/python-api-core/tree/main
fix_replacehttps://github.com/googleapis/python-api-core/tree/fix_replace
Conversationhttps://github.com/googleapis/python-api-core/pull/592
Commits8 (8)https://github.com/googleapis/python-api-core/pull/592/commits
Checkshttps://github.com/googleapis/python-api-core/pull/592/checks
Files changedhttps://github.com/googleapis/python-api-core/pull/592/files
fix: Retry constructors methods support Nonehttps://github.com/googleapis/python-api-core/pull/592#top
daniel-sanchehttps://github.com/daniel-sanche
mainhttps://github.com/googleapis/python-api-core/tree/main
fix_replacehttps://github.com/googleapis/python-api-core/tree/fix_replace
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
Jan 31, 2024https://github.com/googleapis/python-api-core/pull/592#issue-2111189172
#591https://github.com/googleapis/python-api-core/issues/591
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
daniel-sanchehttps://github.com/daniel-sanche
January 31, 2024 15:12https://github.com/googleapis/python-api-core/pull/592#commits-pushed-7984020
https://github.com/daniel-sanche
use sentinal value for _replacehttps://github.com/googleapis/python-api-core/pull/592/commits/79840206d712f6412e0b9614974312facbc1adb2
7984020https://github.com/googleapis/python-api-core/pull/592/commits/79840206d712f6412e0b9614974312facbc1adb2
https://github.com/daniel-sanche
accept None in timeouthttps://github.com/googleapis/python-api-core/pull/592/commits/d228d98cac4681bcd077d7d4db1b84ca1b1c4443
d228d98https://github.com/googleapis/python-api-core/pull/592/commits/d228d98cac4681bcd077d7d4db1b84ca1b1c4443
https://github.com/daniel-sanche
remove _replace functionhttps://github.com/googleapis/python-api-core/pull/592/commits/ed60cc100c380205a5c69ff878969b8634447945
ed60cc1https://github.com/googleapis/python-api-core/pull/592/commits/ed60cc100c380205a5c69ff878969b8634447945
https://github.com/daniel-sanche
added testhttps://github.com/googleapis/python-api-core/pull/592/commits/07ae10bcfdaa2d5cf133a45d07d9f9fa34acf119
07ae10bhttps://github.com/googleapis/python-api-core/pull/592/commits/07ae10bcfdaa2d5cf133a45d07d9f9fa34acf119
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
January 31, 2024 23:54https://github.com/googleapis/python-api-core/pull/592#event-11662656794
https://github.com/apps/product-auto-label
product-auto-labelhttps://github.com/apps/product-auto-label
size: m https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22size%3A%20m%22
Jan 31, 2024https://github.com/googleapis/python-api-core/pull/592#event-11662657372
https://github.com/apps/gcf-owl-bot
🦉 Updates from OwlBot post-processorhttps://github.com/googleapis/python-api-core/pull/592/commits/9d6fcefae2e69fc814e47eab8df623d555e20ce4
9d6fcefhttps://github.com/googleapis/python-api-core/pull/592/commits/9d6fcefae2e69fc814e47eab8df623d555e20ce4
https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdhttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
Feb 1, 2024 https://github.com/googleapis/python-api-core/pull/592#ref-issue-2110623500
API ignores user defined timeout and applies default timeout #591 https://github.com/googleapis/python-api-core/issues/591
https://github.com/yu-iskw
yu-iskwhttps://github.com/yu-iskw
Feb 1, 2024 https://github.com/googleapis/python-api-core/pull/592#ref-issue-2111136764
[Bug] jobs timing out early regardles of job_execution_timeout_seconds dbt-labs/dbt-bigquery#1081 https://github.com/dbt-labs/dbt-bigquery/issues/1081
https://github.com/daniel-sanche
use Optional for type annotationshttps://github.com/googleapis/python-api-core/pull/592/commits/fba807b61f83b33ac0f2861251e47afdd3b41c5b
fba807bhttps://github.com/googleapis/python-api-core/pull/592/commits/fba807b61f83b33ac0f2861251e47afdd3b41c5b
https://github.com/parthea
partheahttps://github.com/parthea
partheahttps://github.com/parthea
vchudnov-ghttps://github.com/vchudnov-g
Feb 1, 2024https://github.com/googleapis/python-api-core/pull/592#event-11674054029
https://github.com/vchudnov-g
vchudnov-ghttps://github.com/vchudnov-g
Feb 2, 2024 https://github.com/googleapis/python-api-core/pull/592#pullrequestreview-1860000396
View reviewed changes https://github.com/googleapis/python-api-core/pull/592/files/fba807b61f83b33ac0f2861251e47afdd3b41c5b
vchudnov-ghttps://github.com/vchudnov-g
https://github.com/googleapis/python-api-core/pull/592#pullrequestreview-1860000396
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
tests/unit/retry/test_retry_base.pyhttps://github.com/googleapis/python-api-core/pull/592/files/fba807b61f83b33ac0f2861251e47afdd3b41c5b#diff-4bd2dfd3270f206ce10cdab2fbc438e4467dd82d55df7a2daa7e1c59029f101f
vchudnov-ghttps://github.com/vchudnov-g
Feb 2, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1476484692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
daniel-sanchehttps://github.com/daniel-sanche
Feb 2, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1476813850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
google/api_core/retry/retry_base.pyhttps://github.com/googleapis/python-api-core/pull/592/files/fba807b61f83b33ac0f2861251e47afdd3b41c5b#diff-0c2b34f85d94509a7f96f3a5645a00654223d9f3657ca7d687264fcc9b81f522
vchudnov-ghttps://github.com/vchudnov-g
Feb 2, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1476490338
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
daniel-sanchehttps://github.com/daniel-sanche
Feb 2, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1476809026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
vchudnov-ghttps://github.com/vchudnov-g
Feb 5, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1479000233
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
daniel-sanchehttps://github.com/daniel-sanche
Feb 6, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1479204874
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
google/api_core/retry/retry_base.pyhttps://github.com/googleapis/python-api-core/pull/592/files/fba807b61f83b33ac0f2861251e47afdd3b41c5b#diff-0c2b34f85d94509a7f96f3a5645a00654223d9f3657ca7d687264fcc9b81f522
vchudnov-ghttps://github.com/vchudnov-g
Feb 2, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1476493588
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
daniel-sanchehttps://github.com/daniel-sanche
Feb 2, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1476827410
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
pre-2.16.0 behaviourhttps://github.com/googleapis/python-api-core/blob/9866183b42f632dddade9ba6c69f9b3015118dd4/google/api_core/retry.py#L457
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
partheahttps://github.com/parthea
Feb 4, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1477430042
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@daniel-sanchehttps://github.com/daniel-sanche
#592 (comment)https://github.com/googleapis/python-api-core/pull/592#discussion_r1476827410
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
daniel-sanchehttps://github.com/daniel-sanche
Feb 5, 2024https://github.com/googleapis/python-api-core/pull/592#discussion_r1478941085
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
https://github.com/daniel-sanche
added test cases to test_with_delayhttps://github.com/googleapis/python-api-core/pull/592/commits/acf7c43f8cfbdaca330ce64059fd1f3a3b2470a8
acf7c43https://github.com/googleapis/python-api-core/pull/592/commits/acf7c43f8cfbdaca330ce64059fd1f3a3b2470a8
https://github.com/parthea
partheahttps://github.com/parthea
daniel-sanchehttps://github.com/daniel-sanche
partheahttps://github.com/parthea
vchudnov-ghttps://github.com/vchudnov-g
Feb 4, 2024https://github.com/googleapis/python-api-core/pull/592#event-11696419604
https://github.com/daniel-sanche
Merge branch 'main' into fix_replacehttps://github.com/googleapis/python-api-core/pull/592/commits/f6cd41146984d6be7b9aaf67cc5a3ecb85a1acfe
f6cd411https://github.com/googleapis/python-api-core/pull/592/commits/f6cd41146984d6be7b9aaf67cc5a3ecb85a1acfe
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
February 5, 2024 22:07https://github.com/googleapis/python-api-core/pull/592#event-11710420750
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
416203chttps://github.com/googleapis/python-api-core/commit/416203c1888934670bfeccafe5f5469f87314512
Feb 5, 2024https://github.com/googleapis/python-api-core/pull/592#event-11710423907
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
February 5, 2024 22:07https://github.com/googleapis/python-api-core/pull/592#event-11710424073
https://github.com/apps/release-please
release-pleasehttps://github.com/apps/release-please
Feb 4, 2024 https://github.com/googleapis/python-api-core/pull/592#ref-pullrequest-2117280991
chore(main): release 2.17.0 #599 https://github.com/googleapis/python-api-core/pull/599
chore(main): release 2.0.0 #822 https://github.com/googleapis/python-api-core/pull/822
chore(main): release 2.0.0 #823 https://github.com/googleapis/python-api-core/pull/823
https://github.co/hiddenchars
https://github.com/googleapis/python-api-core/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F592
https://github.com/parthea
parthea https://github.com/parthea
https://github.com/googleapis/python-api-core/pull/592/files/fba807b61f83b33ac0f2861251e47afdd3b41c5b
https://github.com/vchudnov-g
vchudnov-g https://github.com/vchudnov-g
https://github.com/googleapis/python-api-core/pull/592/files/fba807b61f83b33ac0f2861251e47afdd3b41c5b
https://github.com/daniel-sanche
daniel-sanche https://github.com/daniel-sanche
size: m https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22size%3A%20m%22
API ignores user defined timeout and applies default timeout https://github.com/googleapis/python-api-core/issues/591
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/592
https://github.com/daniel-sanche
https://github.com/parthea
https://github.com/vchudnov-g
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.