René's URL Explorer Experiment


Title: fix: ensure exception is available when BackgroundConsumer open stream fails by parthea · Pull Request #357 · googleapis/python-api-core · GitHub

Open Graph Title: fix: ensure exception is available when BackgroundConsumer open stream fails by parthea · Pull Request #357 · googleapis/python-api-core

X Title: fix: ensure exception is available when BackgroundConsumer open stream fails by parthea · Pull Request #357 · googleapis/python-api-core

Description: Fixes #268🦕 This PR updates the bidi.py code to reflect what is stated in the comments. The comment for add_done_callback states This occurs when the RPC errors or is successfully terminated. however the done callback was not being called when an error occurs. python-api-core/google/api_core/bidi.py Lines 255 to 264 in 2477ab9 def add_done_callback(self, callback): """Adds a callback that will be called when the RPC terminates. This occurs when the RPC errors or is successfully terminated. Args: callback (Callable[[grpc.Future], None]): The callback to execute. It will be provided with the same gRPC future as the underlying stream which will also be a :class:`grpc.Call`. """ python-api-core/google/api_core/bidi.py Lines 267 to 269 in 2477ab9 def _on_call_done(self, future): for callback in self._callbacks: callback(future)

Open Graph Description: Fixes #268🦕 This PR updates the bidi.py code to reflect what is stated in the comments. The comment for add_done_callback states This occurs when the RPC errors or is successfully terminated. howe...

X Description: Fixes #268🦕 This PR updates the bidi.py code to reflect what is stated in the comments. The comment for add_done_callback states This occurs when the RPC errors or is successfully terminated. howe...

Opengraph URL: https://github.com/googleapis/python-api-core/pull/357

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:59f8cb85-3f8e-f259-8b3c-c4cbe440815c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC70:14FA31:2CCDE2:3FBE57:6A4E6A12
html-safe-nonce463cf1f6985dfb2a01f02d801552895626a83aa59347e932d6fb68903b124ccb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzcwOjE0RkEzMToyQ0NERTI6M0ZCRTU3OjZBNEU2QTEyIiwidmlzaXRvcl9pZCI6IjQ2NDA1Mjc5NjY4NDkxMDAzMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc723433363db7086fee4a7e04b765993d2e3e5b0d02c4785d08d15f3c17a306c
hovercard-subject-tagpull_request:879495438
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/googleapis/python-api-core/pull/357/files
twitter:imagehttps://avatars.githubusercontent.com/u/5184014?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5184014?s=400&v=4
og:image:altFixes #268🦕 This PR updates the bidi.py code to reflect what is stated in the comments. The comment for add_done_callback states This occurs when the RPC errors or is successfully terminated. howe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992456
octolytics-dimension-repository_nwogoogleapis/python-api-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992456
octolytics-dimension-repository_network_root_nwogoogleapis/python-api-core
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-api-core/pull/357/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F357%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fpull%2F357%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=googleapis%2Fpython-api-core
Reloadhttps://github.com/googleapis/python-api-core/pull/357/files
Reloadhttps://github.com/googleapis/python-api-core/pull/357/files
Reloadhttps://github.com/googleapis/python-api-core/pull/357/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
googleapis https://github.com/googleapis
python-api-corehttps://github.com/googleapis/python-api-core
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Fork 97 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Star 144 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Code https://github.com/googleapis/python-api-core
Issues 0 https://github.com/googleapis/python-api-core/issues
Pull requests 0 https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality 0 https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
Code https://github.com/googleapis/python-api-core
Issues https://github.com/googleapis/python-api-core/issues
Pull requests https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
partheahttps://github.com/parthea
mainhttps://github.com/googleapis/python-api-core/tree/main
fix-background-consumer-start-eats-exceptionhttps://github.com/googleapis/python-api-core/tree/fix-background-consumer-start-eats-exception
Conversation 16 https://github.com/googleapis/python-api-core/pull/357
Commits 12 https://github.com/googleapis/python-api-core/pull/357/commits
Checks 0 https://github.com/googleapis/python-api-core/pull/357/checks
Files changed https://github.com/googleapis/python-api-core/pull/357/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
fix: ensure exception is available when BackgroundConsumer open stream fails https://github.com/googleapis/python-api-core/pull/357/files#top
Show all changes 12 commits https://github.com/googleapis/python-api-core/pull/357/files
1a64fff fix: ensure exception is available when BackgroundConsumer open strea… parthea Mar 14, 2022 https://github.com/googleapis/python-api-core/pull/357/commits/1a64fff3fece89f3fa8b8d5c959d489c08c11509
97c2363 chore: fix coverage parthea Mar 15, 2022 https://github.com/googleapis/python-api-core/pull/357/commits/97c236391b50ef4b2f3bad8221f4f117efeaf6aa
2b24714 Merge branch 'main' into fix-background-consumer-start-eats-exception parthea Jun 14, 2022 https://github.com/googleapis/python-api-core/pull/357/commits/2b24714433d2bdcb2fa1a27c24290da248c37e1f
947b657 Merge branch 'main' into fix-background-consumer-start-eats-exception parthea Dec 28, 2022 https://github.com/googleapis/python-api-core/pull/357/commits/947b65778556a71216bf01fbd1b2d40218468b5f
ad1f29f Merge branch 'main' into fix-background-consumer-start-eats-exception rosiezou Feb 3, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/ad1f29f4044ce058c92dc7eaf0667cddbf267351
7ec7832 Merge branch 'main' into fix-background-consumer-start-eats-exception parthea Sep 1, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/7ec7832222f329da5c256cab41869f4a0f12b6e0
c7f63bd Address review comments parthea Oct 13, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/c7f63bd270d81f75abdf0282bd3c4be4de02bdbd
3304ef1 revert parthea Oct 13, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/3304ef10e6a66bc75bfbb182886d1cde7b367421
e120a0c address review feedback parthea Oct 13, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/e120a0cdb589d390848b0711ff21c9ff4aab26a9
753a591 raise grpc.RpcError instead of GoogleAPICallError parthea Oct 13, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/753a591bb7f9603929fc81c6880c58237c23a49c
3c1daa9 🦉 Updates from OwlBot post-processor gcf-owl-bot[bot] Oct 13, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/3c1daa9dc5357bb276304acec5c17b33b09032fd
9423063 Merge branch 'main' into fix-background-consumer-start-eats-exception parthea Oct 13, 2023 https://github.com/googleapis/python-api-core/pull/357/commits/94230632b8f3dcbf6d61bdd1d8dcd8e00a7b8f27
Clear filters https://github.com/googleapis/python-api-core/pull/357/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
bidi.py https://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
test_bidi.py https://github.com/googleapis/python-api-core/pull/357/files#diff-13ad29d4fe411bf57b42bd870cca2c9f33a571814a74693c755e52ad9eefeb49
google/api_core/bidi.pyhttps://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
View file https://github.com/googleapis/python-api-core/blob/94230632b8f3dcbf6d61bdd1d8dcd8e00a7b8f27/google/api_core/bidi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-api-core/pull/357/{{ revealButtonHref }}
https://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
https://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
https://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
https://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
vchudnov-ghttps://github.com/vchudnov-g
Sep 28, 2023https://github.com/googleapis/python-api-core/pull/357/files#r1340514508
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
partheahttps://github.com/parthea
Oct 13, 2023https://github.com/googleapis/python-api-core/pull/357/files#r1358687565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e120a0chttps://github.com/googleapis/python-api-core/commit/e120a0cdb589d390848b0711ff21c9ff4aab26a9
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
Please reload this pagehttps://github.com/googleapis/python-api-core/pull/357/files
https://github.com/googleapis/python-api-core/pull/357/files#diff-769a9f2c04700ff355d77a3292b7ff3cea5ff9bda91d0b31138eeb89fcd4d02d
tests/unit/test_bidi.pyhttps://github.com/googleapis/python-api-core/pull/357/files#diff-13ad29d4fe411bf57b42bd870cca2c9f33a571814a74693c755e52ad9eefeb49
View file https://github.com/googleapis/python-api-core/blob/94230632b8f3dcbf6d61bdd1d8dcd8e00a7b8f27/tests/unit/test_bidi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/googleapis/python-api-core/pull/357/{{ revealButtonHref }}
https://github.com/googleapis/python-api-core/pull/357/files#diff-13ad29d4fe411bf57b42bd870cca2c9f33a571814a74693c755e52ad9eefeb49
https://github.com/googleapis/python-api-core/pull/357/files#diff-13ad29d4fe411bf57b42bd870cca2c9f33a571814a74693c755e52ad9eefeb49
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.