Title: fix: do not error on LROs with no response or error by busunkim96 · Pull Request #258 · googleapis/python-api-core · GitHub
Open Graph Title: fix: do not error on LROs with no response or error by busunkim96 · Pull Request #258 · googleapis/python-api-core
X Title: fix: do not error on LROs with no response or error by busunkim96 · Pull Request #258 · googleapis/python-api-core
Description: The response type should not be google.protobuf.Empty (except for Delete methods), unless it is certain that response data will never be needed. If response data might be added in the future, define an empty message for the RPC response and use that. https://google.aip.dev/151 Some APIs will set done: true but have an empty response and exception. Set the result to an empty message of the expected type instead of erroring. Fixes #257 🦕
Open Graph Description: The response type should not be google.protobuf.Empty (except for Delete methods), unless it is certain that response data will never be needed. If response data might be added in the future, defin...
X Description: The response type should not be google.protobuf.Empty (except for Delete methods), unless it is certain that response data will never be needed. If response data might be added in the future, defin...
Opengraph URL: https://github.com/googleapis/python-api-core/pull/258
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:eb75cf9c-fba0-0e79-15f4-5b1c180089a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4F2:29428:7D5A9A:B828D4:6A4E1816 |
| html-safe-nonce | 2cbe2d88c13628ad3fa8be293f74c6a72cb8c58c4d7b3556981071d647eeb014 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEYyOjI5NDI4OjdENUE5QTpCODI4RDQ6NkE0RTE4MTYiLCJ2aXNpdG9yX2lkIjoiODM3NzEyNDkwNDIwNjQ3MzIzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 40f186f67e02af7e47211542927074f2f193406f230d590d3e99cf28f6c9d665 |
| hovercard-subject-tag | pull_request:717040137 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/googleapis/python-api-core/pull/258/files |
| twitter:image | https://avatars.githubusercontent.com/u/8822365?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8822365?s=400&v=4 |
| og:image:alt | The response type should not be google.protobuf.Empty (except for Delete methods), unless it is certain that response data will never be needed. If response data might be added in the future, defin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992456 |
| octolytics-dimension-repository_nwo | googleapis/python-api-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992456 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-api-core |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ea9187571e3edc5f2780f750631138669441ca50 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width