Title: Metadata type changed from `list` to `tuple` affecting modification via interceptor · Issue #660 · googleapis/python-api-core · GitHub
Open Graph Title: Metadata type changed from `list` to `tuple` affecting modification via interceptor · Issue #660 · googleapis/python-api-core
X Title: Metadata type changed from `list` to `tuple` affecting modification via interceptor · Issue #660 · googleapis/python-api-core
Description: The following change d96eb5c introduces a breaking change by changing the type of metadata from a list to a tuple resulting in users to not be able to modify the metadata via an interceptor. The following showcase tests in the generator ...
Open Graph Description: The following change d96eb5c introduces a breaking change by changing the type of metadata from a list to a tuple resulting in users to not be able to modify the metadata via an interceptor. The fo...
X Description: The following change d96eb5c introduces a breaking change by changing the type of metadata from a list to a tuple resulting in users to not be able to modify the metadata via an interceptor. The fo...
Opengraph URL: https://github.com/googleapis/python-api-core/issues/660
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Metadata type changed from `list` to `tuple` affecting modification via interceptor","articleBody":"The following change https://github.com/googleapis/python-api-core/commit/d96eb5cdd8120bfec97d62b09512c6fecc325be8 introduces a breaking change by changing the type of metadata from a list to a tuple resulting in users to not be able to modify the metadata via an interceptor.\r\n\r\nThe following showcase [tests](https://github.com/googleapis/gapic-generator-python/blob/main/tests/system/test_grpc_interceptor_streams.py) in the generator break, since the interceptor can no longer modify the metadata (or assign it a new value) via this function:\r\n\r\n```python3\r\ndef _add_metadata(self, client_call_details):\r\n if client_call_details.metadata is not None:\r\n client_call_details.metadata.append((self._key, self._value))\r\n\r\n``` \r\n","author":{"url":"https://github.com/ohmayr","@type":"Person","name":"ohmayr"},"datePublished":"2024-05-24T18:25:26.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/660/python-api-core/issues/660"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:41e16446-a2fc-23d5-fe6b-b93f47c2a67f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 990A:244C0:480FF4A:652237C:6A4F7C1C |
| html-safe-nonce | 89375edd9e31697f55396fc6fcb38c16fcb9173fba65149f4db612f066cb7073 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTBBOjI0NEMwOjQ4MEZGNEE6NjUyMjM3Qzo2QTRGN0MxQyIsInZpc2l0b3JfaWQiOiIxNzU3MDcxNTU2MzY4ODkwOTA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8ae724696ffb81b2fdbf6345b9983538a98dc4a8b89729bd1f905901588130a5 |
| hovercard-subject-tag | issue:2316000457 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-api-core/660/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7dde7ddd78563c208dd57520f26bc2edc03cfb88e0bd814dad9abaf7900631a8/googleapis/python-api-core/issues/660 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7dde7ddd78563c208dd57520f26bc2edc03cfb88e0bd814dad9abaf7900631a8/googleapis/python-api-core/issues/660 |
| og:image:alt | The following change d96eb5c introduces a breaking change by changing the type of metadata from a list to a tuple resulting in users to not be able to modify the metadata via an interceptor. The fo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ohmayr |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 226992456 |
| octolytics-dimension-repository_nwo | googleapis/python-api-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 226992456 |
| octolytics-dimension-repository_network_root_nwo | googleapis/python-api-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4b249b445842943ed31549e027f57a8ade9881ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width