René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`mypy` presubmit fails with `types-protobuf==5.x`","articleBody":"The `mypy` [nox session](https://github.com/googleapis/python-api-core/blob/828ffe1d7b2edd36be5e852524adb7f5d1241770/noxfile.py#L175) fails with the [latest version](https://pypi.org/project/types-protobuf/5.26.0.20240422/) of `types-protobuf==5.26.0.20240422` and `types-protobuf==5.26.0.20240420`. This is related to [protobuf 5.x](https://pypi.org/project/protobuf/#history) which includes a breaking change compared with 4.x where `including_default_value_fields` is removed in `MessageToDict` : https://github.com/protocolbuffers/protobuf/commit/26995798757fbfef5cf6648610848e389db1fecf\r\n\r\n\r\nSee the stack trace below and [build log](https://github.com/googleapis/python-api-core/actions/runs/8859767950/job/24329889797?pr=634) from PR https://github.com/googleapis/python-api-core/pull/634\r\n```\r\nRun nox -s mypy\r\nnox \u003e Running session mypy\r\nnox \u003e Creating virtual environment (virtualenv) using python3.10 in .nox/mypy\r\nnox \u003e python -m pip install '.[grpc]' mypy\r\nnox \u003e python -m pip install types-setuptools types-requests 'types-protobuf!=4.24.0.20240106' types-mock types-dataclasses\r\nnox \u003e mypy google tests\r\nmypy.ini: [mypy]: python_version: Python 3.7 is not supported (must be 3.8 or higher)\r\ngoogle/api_core/operations_v1/transports/rest.py:187: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:200: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:268: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:281: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:342: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:355: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:4[14](https://github.com/googleapis/python-api-core/actions/runs/8859767950/job/24329889797?pr=634#step:5:15): error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:424: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\ngoogle/api_core/operations_v1/transports/rest.py:436: error: Unexpected keyword argument \"including_default_value_fields\" for \"MessageToDict\"  [call-arg]\r\n.nox/mypy/lib/python3.10/site-packages/google-stubs/protobuf/json_format.pyi:23: note: \"MessageToDict\" defined here\r\nFound 9 errors in 1 file (checked 97 source files)\r\nnox \u003e Command mypy google tests failed with exit code 1\r\nnox \u003e Session mypy failed.\r\nError: Process completed with exit code 1.\r\n```","author":{"url":"https://github.com/parthea","@type":"Person","name":"parthea"},"datePublished":"2024-04-27T12:34:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/642/python-api-core/issues/642"}