Title: improve __call__ performance benchmarking · Issue #15058 · googleapis/google-cloud-python · GitHub
Open Graph Title: improve __call__ performance benchmarking · Issue #15058 · googleapis/google-cloud-python
X Title: improve __call__ performance benchmarking · Issue #15058 · googleapis/google-cloud-python
Description: In googleapis/python-api-core#527, we improved the performance of _GapicCallable's call method, and added a simple benchmark unit test to prevent performance from regressing too much The test was very simple, using timeit to measure the ...
Open Graph Description: In googleapis/python-api-core#527, we improved the performance of _GapicCallable's call method, and added a simple benchmark unit test to prevent performance from regressing too much The test was v...
X Description: In googleapis/python-api-core#527, we improved the performance of _GapicCallable's call method, and added a simple benchmark unit test to prevent performance from regressing too much The test w...
Opengraph URL: https://github.com/googleapis/google-cloud-python/issues/15058
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"improve __call__ performance benchmarking","articleBody":"In https://github.com/googleapis/python-api-core/issues/527, we improved the performance of _GapicCallable's __call__ method, and added a simple benchmark unit test to prevent performance from regressing too much\r\n\r\nThe test was very simple, using timeit to measure the time to run 10,000 calls, and dailing if it was slower than expected. This doesn't take performance of the worker into account, so the test may flake in different environments. To prevent this, we left a large buffer, but this means smaller regressions won't be caught by the test\r\n\r\n@parthea [suggested opening this issue](https://github.com/googleapis/python-api-core/pull/527#issuecomment-1945082062) to investigate improving the performance tests in the future. If we could test the performance of the old revision and the suggested change as part of the same test, we could make much better assertions on the performance of the library\r\n\r\nCC @ohmayr ","author":{"url":"https://github.com/daniel-sanche","@type":"Person","name":"daniel-sanche"},"datePublished":"2024-02-15T00:14:41.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/15058/google-cloud-python/issues/15058"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7368b296-0721-97ba-3670-66c13dea32ae |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CD18:FE029:4E3944A:6E2D632:6A501FB3 |
| html-safe-nonce | 50791124675ff27879a80a685c2d0818af3e4bf9ef7ccd6572f245ec29fd5599 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDE4OkZFMDI5OjRFMzk0NEE6NkUyRDYzMjo2QTUwMUZCMyIsInZpc2l0b3JfaWQiOiIyMzA5NTI1Mjc1NDM4NzUxNjY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bc3423efe3aab38ea3fbcf280ef82de0ab498e1ab2755ebb9b7a456fa2d47e3c |
| hovercard-subject-tag | issue:3804922809 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/google-cloud-python/15058/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1fd9beaae1358e00d4ca21a381fe50bd98a7a5aefee1e0b7be938bea3cce966b/googleapis/google-cloud-python/issues/15058 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1fd9beaae1358e00d4ca21a381fe50bd98a7a5aefee1e0b7be938bea3cce966b/googleapis/google-cloud-python/issues/15058 |
| og:image:alt | In googleapis/python-api-core#527, we improved the performance of _GapicCallable's call method, and added a simple benchmark unit test to prevent performance from regressing too much The test was v... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | daniel-sanche |
| hostname | github.com |
| expected-hostname | github.com |
| None | a08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069 |
| turbo-cache-control | no-preview |
| go-import | github.com/googleapis/google-cloud-python git https://github.com/googleapis/google-cloud-python.git |
| octolytics-dimension-user_id | 16785467 |
| octolytics-dimension-user_login | googleapis |
| octolytics-dimension-repository_id | 16316451 |
| octolytics-dimension-repository_nwo | googleapis/google-cloud-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16316451 |
| octolytics-dimension-repository_network_root_nwo | googleapis/google-cloud-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1b91b18e7330fc458dfd824c61eaed7daa830d6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width