René's URL Explorer Experiment


Title: Retry decorator should support generator functions · Issue #485 · googleapis/python-api-core · GitHub

Open Graph Title: Retry decorator should support generator functions · Issue #485 · googleapis/python-api-core

X Title: Retry decorator should support generator functions · Issue #485 · googleapis/python-api-core

Description: Is your feature request related to a problem? Please describe. Server streaming libraries return an iterable that can asynchronously yield data from the backend over time. Some of our libraries need to provide a wrapper around the raw st...

Open Graph Description: Is your feature request related to a problem? Please describe. Server streaming libraries return an iterable that can asynchronously yield data from the backend over time. Some of our libraries nee...

X Description: Is your feature request related to a problem? Please describe. Server streaming libraries return an iterable that can asynchronously yield data from the backend over time. Some of our libraries nee...

Opengraph URL: https://github.com/googleapis/python-api-core/issues/485

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Retry decorator should support generator functions","articleBody":" **Is your feature request related to a problem? Please describe.**\r\n\r\nServer streaming libraries [return an iterable](https://github.com/googleapis/python-bigtable/blob/a6cfb021e1b158b81879b115868112875b1e4162/google/cloud/bigtable_v2/services/bigtable/client.py#L471) that can asynchronously yield data from the backend over time. Some of our libraries need to provide a wrapper around the raw stream to do some local processing, before passing the data to the user.\r\n\r\nIt would be useful to wrap this whole pipeline in a [retry decorator](https://github.com/googleapis/python-api-core/blob/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7/google/api_core/retry.py#L222), so that if the stream breaks mid-way through, we can recover and continue yielding data through our generator as if nothing happened. \r\n\r\nUnfortunately, the [current implementation ](https://github.com/googleapis/python-api-core/blob/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7/google/api_core/retry.py#L191) returns the result of the target function directly, so generators will not yield values and exceptions through the retry block\r\n\r\n **Describe the solution you'd like**\r\n\r\nAdd some code to detect when a target function is a generator. If so, Replace: https://github.com/googleapis/python-api-core/blob/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7/google/api_core/retry.py#L191\r\nwith:\r\n```\r\nyield from target()\r\n```\r\n\r\nSome extra work will also be needed to detect generator `.close()`, and async generators\r\n\r\nI plan on putting together a PR for this shortly","author":{"url":"https://github.com/daniel-sanche","@type":"Person","name":"daniel-sanche"},"datePublished":"2023-02-10T21:01:39.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/485/python-api-core/issues/485"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1a05bac1-10e2-0a5a-7416-3eae50da98f8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8878:3092B8:B522D0:B91A1A:6A4DB74C
html-safe-nonce8032e63f29c4b2bfa80465d17d18b2bb5fed5659dfbcfba4ced8f2c24662163c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODc4OjMwOTJCODpCNTIyRDA6QjkxQTFBOjZBNERCNzRDIiwidmlzaXRvcl9pZCI6IjExMDE2Nzc0MjI2NTMwNjA5NDAiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmac3259b863f082afec94c2ea847c31ae87689a8022687309cf88df8837072c9be2
hovercard-subject-tagissue:1580324658
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-api-core/485/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d88ae01004f1c31ea0194f784f2d8019c64961c50e7a8b3a25fbf5272888a0d6/googleapis/python-api-core/issues/485
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d88ae01004f1c31ea0194f784f2d8019c64961c50e7a8b3a25fbf5272888a0d6/googleapis/python-api-core/issues/485
og:image:altIs your feature request related to a problem? Please describe. Server streaming libraries return an iterable that can asynchronously yield data from the backend over time. Some of our libraries nee...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedaniel-sanche
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
go-importgithub.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git
octolytics-dimension-user_id16785467
octolytics-dimension-user_logingoogleapis
octolytics-dimension-repository_id226992456
octolytics-dimension-repository_nwogoogleapis/python-api-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id226992456
octolytics-dimension-repository_network_root_nwogoogleapis/python-api-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32f7b614aca06e6bbd89842b1370df1328264f68
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/googleapis/python-api-core/issues/485#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fissues%2F485
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fpython-api-core%2Fissues%2F485
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=googleapis%2Fpython-api-core
Reloadhttps://github.com/googleapis/python-api-core/issues/485
Reloadhttps://github.com/googleapis/python-api-core/issues/485
Reloadhttps://github.com/googleapis/python-api-core/issues/485
Please reload this pagehttps://github.com/googleapis/python-api-core/issues/485
googleapis https://github.com/googleapis
python-api-corehttps://github.com/googleapis/python-api-core
Notifications https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Fork 97 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Star 144 https://github.com/login?return_to=%2Fgoogleapis%2Fpython-api-core
Code https://github.com/googleapis/python-api-core
Issues 0 https://github.com/googleapis/python-api-core/issues
Pull requests 0 https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality 0 https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
Code https://github.com/googleapis/python-api-core
Issues https://github.com/googleapis/python-api-core/issues
Pull requests https://github.com/googleapis/python-api-core/pulls
Actions https://github.com/googleapis/python-api-core/actions
Projects https://github.com/googleapis/python-api-core/projects
Security and quality https://github.com/googleapis/python-api-core/security
Insights https://github.com/googleapis/python-api-core/pulse
#495https://github.com/googleapis/python-api-core/pull/495
Retry decorator should support generator functionshttps://github.com/googleapis/python-api-core/issues/485#top
#495https://github.com/googleapis/python-api-core/pull/495
https://github.com/daniel-sanche
priority: p2Moderately-important priority. Fix may not be included in next release.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%20request%22
https://github.com/daniel-sanche
daniel-sanchehttps://github.com/daniel-sanche
on Feb 10, 2023https://github.com/googleapis/python-api-core/issues/485#issue-1580324658
return an iterablehttps://github.com/googleapis/python-bigtable/blob/a6cfb021e1b158b81879b115868112875b1e4162/google/cloud/bigtable_v2/services/bigtable/client.py#L471
retry decoratorhttps://github.com/googleapis/python-api-core/blob/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7/google/api_core/retry.py#L222
current implementation https://github.com/googleapis/python-api-core/blob/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7/google/api_core/retry.py#L191
python-api-core/google/api_core/retry.pyhttps://github.com/googleapis/python-api-core/blob/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7/google/api_core/retry.py#L191
b8e75cfhttps://github.com/googleapis/python-api-core/commit/b8e75cff8bf6772ab76ca6f8d3c80dc2580075c7
daniel-sanchehttps://github.com/daniel-sanche
priority: p2Moderately-important priority. Fix may not be included in next release.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22priority%3A%20p2%22
type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.https://github.com/googleapis/python-api-core/issues?q=state%3Aopen%20label%3A%22type%3A%20feature%20request%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.