Title: Requiring `trailing_metadata` is a breaking change · Issue #297 · googleapis/python-api-core · GitHub
Open Graph Title: Requiring `trailing_metadata` is a breaking change · Issue #297 · googleapis/python-api-core
X Title: Requiring `trailing_metadata` is a breaking change · Issue #297 · googleapis/python-api-core
Description: PR #286 added support for showing error status details -- unfortunately, it also breaks Bigtable's unit tests: ___ Test_retry_read_rows_exception.test_w_deadline_exceeded_wrapped_in_grpc ____ self = Open Graph Description: PR #286 added support for showing error status details -- unfortunately, it also breaks Bigtable's unit tests: ___ Test_retry_read_rows_exception.test_w_deadline_exceeded_wrapped_in_grpc ____ self ...
X Description: PR #286 added support for showing error status details -- unfortunately, it also breaks Bigtable's unit tests: ___ Test_retry_read_rows_exception.test_w_deadline_exceeded_wrapped_in_grpc ____ s...
Opengraph URL: https://github.com/googleapis/python-api-core/issues/297
X: @github
Domain: github.com
Links:
Viewport: width=device-width
Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Requiring `trailing_metadata` is a breaking change","articleBody":"PR #286 added support for showing error status details -- unfortunately, it also [breaks Bigtable's unit tests](https://source.cloud.google.com/results/invocations/539e41cd-9cfd-4db7-9f53-f5da66016909/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigtable%2Fpresubmit%2Fpresubmit/log):\r\n\r\n```python\r\n___ Test_retry_read_rows_exception.test_w_deadline_exceeded_wrapped_in_grpc ____\r\n\r\nself = \u003ctests.unit.test_row_data.Test_retry_read_rows_exception testMethod=test_w_deadline_exceeded_wrapped_in_grpc\u003e\r\n\r\n def test_w_deadline_exceeded_wrapped_in_grpc(self):\r\n from google.api_core.exceptions import DeadlineExceeded\r\n\r\n wrapped = DeadlineExceeded(\"testing\")\r\n exception = self._make_grpc_call_error(wrapped)\r\n\u003e self.assertTrue(self._call_fut(exception))\r\n\r\ntests/unit/test_row_data.py:324:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\ntests/unit/test_row_data.py:268: in _call_fut\r\n return _retry_read_rows_exception(exc)\r\ngoogle/cloud/bigtable/row_data.py:333: in _retry_read_rows_exception\r\n exc = exceptions.from_grpc_error(exc)\r\n.nox/unit-3-9/lib/python3.9/site-packages/google/api_core/exceptions.py:537: in from_grpc_error\r\n details=_parse_grpc_error_details(rpc_exc),\r\n.nox/unit-3-9/lib/python3.9/site-packages/google/api_core/exceptions.py:490: in _parse_grpc_error_details\r\n status = rpc_status.from_call(rpc_exc)\r\n.nox/unit-3-9/lib/python3.9/site-packages/grpc_status/rpc_status.py:48: in from_call\r\n if call.trailing_metadata() is None:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\n\r\nself = TestingException(DeadlineExceeded('testing'))\r\n\r\n @abc.abstractmethod\r\n def trailing_metadata(self):\r\n \"\"\"Accesses the trailing metadata sent by the server.\r\n\r\n This method blocks until the value is available.\r\n\r\n Returns:\r\n The trailing :term:`metadata`.\r\n \"\"\"\r\n\u003e raise NotImplementedError()\r\nE NotImplementedError\r\n\r\n.nox/unit-3-9/lib/python3.9/site-packages/grpc/__init__.py:382: NotImplementedError\r\n__________ Test_retry_read_rows_exception.test_w_miss_wrapped_in_grpc __________\r\n\r\nself = \u003ctests.unit.test_row_data.Test_retry_read_rows_exception testMethod=test_w_miss_wrapped_in_grpc\u003e\r\n\r\n def test_w_miss_wrapped_in_grpc(self):\r\n from google.api_core.exceptions import Conflict\r\n\r\n wrapped = Conflict(\"testing\")\r\n exception = self._make_grpc_call_error(wrapped)\r\n\u003e self.assertFalse(self._call_fut(exception))\r\n\r\ntests/unit/test_row_data.py:310:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\ntests/unit/test_row_data.py:268: in _call_fut\r\n return _retry_read_rows_exception(exc)\r\ngoogle/cloud/bigtable/row_data.py:333: in _retry_read_rows_exception\r\n exc = exceptions.from_grpc_error(exc)\r\n.nox/unit-3-9/lib/python3.9/site-packages/google/api_core/exceptions.py:537: in from_grpc_error\r\n details=_parse_grpc_error_details(rpc_exc),\r\n.nox/unit-3-9/lib/python3.9/site-packages/google/api_core/exceptions.py:490: in _parse_grpc_error_details\r\n status = rpc_status.from_call(rpc_exc)\r\n.nox/unit-3-9/lib/python3.9/site-packages/grpc_status/rpc_status.py:48: in from_call\r\n if call.trailing_metadata() is None:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\n\r\nself = TestingException(Conflict('testing'))\r\n\r\n @abc.abstractmethod\r\n def trailing_metadata(self):\r\n \"\"\"Accesses the trailing metadata sent by the server.\r\n\r\n This method blocks until the value is available.\r\n\r\n Returns:\r\n The trailing :term:`metadata`.\r\n \"\"\"\r\n\u003e raise NotImplementedError()\r\nE NotImplementedError\r\n\r\n.nox/unit-3-9/lib/python3.9/site-packages/grpc/__init__.py:382: NotImplementedError\r\n__ Test_retry_read_rows_exception.test_w_service_unavailable_wrapped_in_grpc ___\r\n\r\nself = \u003ctests.unit.test_row_data.Test_retry_read_rows_exception testMethod=test_w_service_unavailable_wrapped_in_grpc\u003e\r\n\r\n def test_w_service_unavailable_wrapped_in_grpc(self):\r\n from google.api_core.exceptions import ServiceUnavailable\r\n\r\n wrapped = ServiceUnavailable(\"testing\")\r\n exception = self._make_grpc_call_error(wrapped)\r\n\u003e self.assertTrue(self._call_fut(exception))\r\n\r\ntests/unit/test_row_data.py:317:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\ntests/unit/test_row_data.py:268: in _call_fut\r\n return _retry_read_rows_exception(exc)\r\ngoogle/cloud/bigtable/row_data.py:333: in _retry_read_rows_exception\r\n exc = exceptions.from_grpc_error(exc)\r\n.nox/unit-3-9/lib/python3.9/site-packages/google/api_core/exceptions.py:537: in from_grpc_error\r\n details=_parse_grpc_error_details(rpc_exc),\r\n.nox/unit-3-9/lib/python3.9/site-packages/google/api_core/exceptions.py:490: in _parse_grpc_error_details\r\n status = rpc_status.from_call(rpc_exc)\r\n.nox/unit-3-9/lib/python3.9/site-packages/grpc_status/rpc_status.py:48: in from_call\r\n if call.trailing_metadata() is None:\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _\r\n\r\nself = TestingException(ServiceUnavailable('testing'))\r\n\r\n @abc.abstractmethod\r\n def trailing_metadata(self):\r\n \"\"\"Accesses the trailing metadata sent by the server.\r\n\r\n This method blocks until the value is available.\r\n\r\n Returns:\r\n The trailing :term:`metadata`.\r\n \"\"\"\r\n\u003e raise NotImplementedError()\r\nE NotImplementedError\r\n\r\n.nox/unit-3-9/lib/python3.9/site-packages/grpc/__init__.py:382: NotImplementedError\r\n```","author":{"url":"https://github.com/tseaver","@type":"Person","name":"tseaver"},"datePublished":"2021-10-27T18:55:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/297/python-api-core/issues/297"}
route-pattern /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) route-controller voltron_issues_fragments route-action issue_layout fetch-nonce v2:7ffb025a-ce17-10b1-eb01-4ebd78f85ecc current-catalog-service-hash 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 request-id 9D94:2E1FD9:C71CB5:1127C2F:6A4DCC6A html-safe-nonce 248a5aa782307344b5aa77f4bf6154c5ccd29c0dd6826a112e3aeccc74609732 visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDk0OjJFMUZEOTpDNzFDQjU6MTEyN0MyRjo2QTREQ0M2QSIsInZpc2l0b3JfaWQiOiIxNDk5NDEwNTA2ODY3MTMzNTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= visitor-hmac 6641cc66bd663b122a8f84cbafa5a0d02bb24c665a3b1980e4a13bd310b29a3c hovercard-subject-tag issue:1037753112 github-keyboard-shortcuts repository,issues,copilot google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I octolytics-url https://collector.github.com/github/collect analytics-location / fb:app_id 1401488693436528 apple-itunes-app app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/googleapis/python-api-core/297/issue_layout twitter:image https://opengraph.githubassets.com/c8dca284b1af5cfeaaec15bdb75117891f8f781de34060f524e7bfad876bbff7/googleapis/python-api-core/issues/297 twitter:card summary_large_image og:image https://opengraph.githubassets.com/c8dca284b1af5cfeaaec15bdb75117891f8f781de34060f524e7bfad876bbff7/googleapis/python-api-core/issues/297 og:image:alt PR #286 added support for showing error status details -- unfortunately, it also breaks Bigtable's unit tests: ___ Test_retry_read_rows_exception.test_w_deadline_exceeded_wrapped_in_grpc ____ self ... og:image:width 1200 og:image:height 600 og:site_name GitHub og:type object og:author:username tseaver hostname github.com expected-hostname github.com None 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 turbo-cache-control no-preview go-import github.com/googleapis/python-api-core git https://github.com/googleapis/python-api-core.git octolytics-dimension-user_id 16785467 octolytics-dimension-user_login googleapis octolytics-dimension-repository_id 226992456 octolytics-dimension-repository_nwo googleapis/python-api-core octolytics-dimension-repository_public true octolytics-dimension-repository_is_fork false octolytics-dimension-repository_network_root_id 226992456 octolytics-dimension-repository_network_root_nwo googleapis/python-api-core turbo-body-classes logged-out env-production page-responsive disable-turbo false browser-stats-url https://api.github.com/_private/browser/stats browser-errors-url https://api.github.com/_private/browser/errors release 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 ui-target full theme-color #1e2327 color-scheme light dark
URLs of crawlers that visited me.